loplugin:stringviewparam extend to comparison operators

which means that some call sites have to change to use
unicode string literals i.e. u"foo" instead of "foo"

Change-Id: Ie51c3adf56d343dd1d1710777f9d2a43ee66221c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106125
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

6 files changed, 6 insertions, 6 deletions

diff --git a/connectivity/source/cpool/ZPoolCollection.cxx b/connectivity/source/cpool/ZPoolCollection.cxx
index 53c1cea0d3c3..34d24b0be4f9 100644
--- a/connectivity/source/cpool/ZPoolCollection.cxx
+++ b/connectivity/source/cpool/ZPoolCollection.cxx
@@ -188,7 +188,7 @@ Reference< XDriver > SAL_CALL OPoolCollection::getDriverByURL( const OUString& _
     return xDriver;
 }
 
-bool OPoolCollection::isDriverPoolingEnabled(const OUString& _sDriverImplName,
+bool OPoolCollection::isDriverPoolingEnabled(std::u16string_view _sDriverImplName,
                                                  Reference< XInterface >& _rxDriverNode)
 {
     bool bEnabled = false;
diff --git a/connectivity/source/cpool/ZPoolCollection.hxx b/connectivity/source/cpool/ZPoolCollection.hxx
index f9078c1baa72..dc54e2f6b171 100644
--- a/connectivity/source/cpool/ZPoolCollection.hxx
+++ b/connectivity/source/cpool/ZPoolCollection.hxx
@@ -88,7 +88,7 @@ namespace connectivity
         static css::uno::Reference< css::uno::XInterface > openNode( const OUString& _rPath,
                                                                                         const css::uno::Reference< css::uno::XInterface >& _xTreeNode) throw();
         bool isPoolingEnabled();
-        bool isDriverPoolingEnabled(const OUString& _sDriverImplName,
+        bool isDriverPoolingEnabled(std::u16string_view _sDriverImplName,
                                         css::uno::Reference< css::uno::XInterface >& _rxDriverNode);
         bool isPoolingEnabledByUrl( const OUString& _sUrl,
                                         css::uno::Reference< css::sdbc::XDriver >& _rxDriver,
diff --git a/connectivity/source/drivers/dbase/DTable.cxx b/connectivity/source/drivers/dbase/DTable.cxx
index f16d2f1ee3eb..4f3e07be5938 100644
--- a/connectivity/source/drivers/dbase/DTable.cxx
+++ b/connectivity/source/drivers/dbase/DTable.cxx
@@ -589,7 +589,7 @@ void ODbaseTable::ReadMemoHeader()
     }
 }
 
-OUString ODbaseTable::getEntry(file::OConnection const * _pConnection,const OUString& _sName )
+OUString ODbaseTable::getEntry(file::OConnection const * _pConnection, std::u16string_view _sName )
 {
     OUString sURL;
     try
diff --git a/connectivity/source/drivers/mysqlc/mysqlc_services.cxx b/connectivity/source/drivers/mysqlc/mysqlc_services.cxx
index de611375c371..6e4e2fbb5e84 100644
--- a/connectivity/source/drivers/mysqlc/mysqlc_services.cxx
+++ b/connectivity/source/drivers/mysqlc/mysqlc_services.cxx
@@ -48,7 +48,7 @@ struct ProviderRequest
     {
     }
 
-    bool CREATE_PROVIDER(const OUString& Implname, const Sequence<OUString>& Services,
+    bool CREATE_PROVIDER(std::u16string_view Implname, const Sequence<OUString>& Services,
                          ::cppu::ComponentInstantiation Factory, createFactoryFunc creator)
     {
         if (!xRet.is() && (Implname == sImplementationName))
diff --git a/connectivity/source/inc/dbase/DTable.hxx b/connectivity/source/inc/dbase/DTable.hxx
index 49b7bcc5a264..872b4d3d8c1b 100644
--- a/connectivity/source/inc/dbase/DTable.hxx
+++ b/connectivity/source/inc/dbase/DTable.hxx
@@ -182,7 +182,7 @@ namespace connectivity::dbase
             virtual void addColumn(const css::uno::Reference< css::beans::XPropertySet>& descriptor) override;
             virtual void dropColumn(sal_Int32 _nPos) override;
 
-            static OUString   getEntry(file::OConnection const * _pConnection,const OUString& _sURL );
+            static OUString   getEntry(file::OConnection const * _pConnection, std::u16string_view _sURL );
             static bool     Drop_Static(const OUString& _sUrl, bool _bHasMemoFields, sdbcx::OCollection* _pIndexes );
 
             virtual void refreshHeader() override;
diff --git a/connectivity/source/parse/sqliterator.cxx b/connectivity/source/parse/sqliterator.cxx
index a91390eca2b8..d7d7512b7acd 100644
--- a/connectivity/source/parse/sqliterator.cxx
+++ b/connectivity/source/parse/sqliterator.cxx
@@ -1919,7 +1919,7 @@ const OSQLParseNode* OSQLParseTreeIterator::getSimpleHavingTree() const
 }
 
 
-Reference< XPropertySet > OSQLParseTreeIterator::findSelectColumn( const OUString & rColumnName )
+Reference< XPropertySet > OSQLParseTreeIterator::findSelectColumn( std::u16string_view rColumnName )
 {
     for (auto const& lookupColumn : *m_aSelectColumns)
     {