summaryrefslogtreecommitdiff
path: root/connectivity
diff options
context:
space:
mode:
authorNoel Grandin <noel@peralex.com>2016-07-22 14:35:27 +0200
committerNoel Grandin <noelgrandin@gmail.com>2016-07-25 06:09:17 +0000
commit938821fb08e427864db6a10642f385bde9803f6c (patch)
tree759da9d0d0905a90f6dac2f0bf750721c17421c4 /connectivity
parent4d4d77a1aad1bcae18bad35dad5308d33d6b2e51 (diff)
new loplugin overrideparam
verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'connectivity')
-rw-r--r--connectivity/source/drivers/file/fcode.cxx6
-rw-r--r--connectivity/source/inc/file/FNumericFunctions.hxx16
-rw-r--r--connectivity/source/inc/file/fcode.hxx6
3 files changed, 14 insertions, 14 deletions
diff --git a/connectivity/source/drivers/file/fcode.cxx b/connectivity/source/drivers/file/fcode.cxx
index a536d0c5b452..47e7cac831d7 100644
--- a/connectivity/source/drivers/file/fcode.cxx
+++ b/connectivity/source/drivers/file/fcode.cxx
@@ -178,7 +178,7 @@ void OOp_NOT::Exec(OCodeStack& rCodeStack)
OOperand* pOperand = rCodeStack.top();
rCodeStack.pop();
- rCodeStack.push(new OOperandResultBOOL(operate(pOperand)));
+ rCodeStack.push(new OOperandResultBOOL(operate(pOperand, nullptr)));
if( typeid(OOperandResult) == typeid(*pOperand))
delete pOperand;
@@ -201,7 +201,7 @@ void OOp_ISNULL::Exec(OCodeStack& rCodeStack)
OOperand* pOperand = rCodeStack.top();
rCodeStack.pop();
- rCodeStack.push(new OOperandResultBOOL(operate(pOperand)));
+ rCodeStack.push(new OOperandResultBOOL(operate(pOperand, nullptr)));
if( typeid(OOperandResult) == typeid(*pOperand))
delete pOperand;
}
@@ -215,7 +215,7 @@ bool OOp_ISNULL::operate(const OOperand* pOperand, const OOperand*) const
bool OOp_ISNOTNULL::operate(const OOperand* pOperand, const OOperand*) const
{
- return !OOp_ISNULL::operate(pOperand);
+ return !OOp_ISNULL::operate(pOperand, nullptr);
}
diff --git a/connectivity/source/inc/file/FNumericFunctions.hxx b/connectivity/source/inc/file/FNumericFunctions.hxx
index a8ab004cd06e..f71885170979 100644
--- a/connectivity/source/inc/file/FNumericFunctions.hxx
+++ b/connectivity/source/inc/file/FNumericFunctions.hxx
@@ -250,7 +250,7 @@ namespace connectivity
class OOp_Cos : public OUnaryOperator
{
protected:
- virtual ORowSetValue operate(const ORowSetValue& lhs = ORowSetValue()) const override;
+ virtual ORowSetValue operate(const ORowSetValue& lhs) const override;
};
/** SIN(X)
@@ -263,7 +263,7 @@ namespace connectivity
class OOp_Sin : public OUnaryOperator
{
protected:
- virtual ORowSetValue operate(const ORowSetValue& lhs = ORowSetValue()) const override;
+ virtual ORowSetValue operate(const ORowSetValue& lhs) const override;
};
/** TAN(X)
Returns the tangent of X, where X is given in radians:
@@ -274,7 +274,7 @@ namespace connectivity
class OOp_Tan : public OUnaryOperator
{
protected:
- virtual ORowSetValue operate(const ORowSetValue& lhs = ORowSetValue()) const override;
+ virtual ORowSetValue operate(const ORowSetValue& lhs) const override;
};
/** ACOS(X)
@@ -290,7 +290,7 @@ namespace connectivity
class OOp_ACos : public OUnaryOperator
{
protected:
- virtual ORowSetValue operate(const ORowSetValue& lhs = ORowSetValue()) const override;
+ virtual ORowSetValue operate(const ORowSetValue& lhs) const override;
};
/** ASIN(X)
@@ -304,7 +304,7 @@ namespace connectivity
class OOp_ASin : public OUnaryOperator
{
protected:
- virtual ORowSetValue operate(const ORowSetValue& lhs = ORowSetValue()) const override;
+ virtual ORowSetValue operate(const ORowSetValue& lhs) const override;
};
/** ATAN(X)
@@ -318,7 +318,7 @@ namespace connectivity
class OOp_ATan : public OUnaryOperator
{
protected:
- virtual ORowSetValue operate(const ORowSetValue& lhs = ORowSetValue()) const override;
+ virtual ORowSetValue operate(const ORowSetValue& lhs) const override;
};
/** ATAN2(Y,X)
@@ -345,7 +345,7 @@ namespace connectivity
class OOp_Degrees : public OUnaryOperator
{
protected:
- virtual ORowSetValue operate(const ORowSetValue& lhs = ORowSetValue()) const override;
+ virtual ORowSetValue operate(const ORowSetValue& lhs) const override;
};
/** RADIANS(X)
@@ -358,7 +358,7 @@ namespace connectivity
class OOp_Radians : public OUnaryOperator
{
protected:
- virtual ORowSetValue operate(const ORowSetValue& lhs = ORowSetValue()) const override;
+ virtual ORowSetValue operate(const ORowSetValue& lhs) const override;
};
}
}
diff --git a/connectivity/source/inc/file/fcode.hxx b/connectivity/source/inc/file/fcode.hxx
index 9d8082a188bb..afd62c78b3d1 100644
--- a/connectivity/source/inc/file/fcode.hxx
+++ b/connectivity/source/inc/file/fcode.hxx
@@ -200,7 +200,7 @@ namespace connectivity
protected:
virtual void Exec(OCodeStack&) override;
- virtual bool operate(const OOperand*, const OOperand* = nullptr) const override;
+ virtual bool operate(const OOperand*, const OOperand*) const override;
};
class OOp_AND : public OBoolOperator
@@ -223,13 +223,13 @@ namespace connectivity
public:
public:
virtual void Exec(OCodeStack&) override;
- virtual bool operate(const OOperand*, const OOperand* = nullptr) const override;
+ virtual bool operate(const OOperand*, const OOperand*) const override;
};
class OOO_DLLPUBLIC_FILE OOp_ISNOTNULL : public OOp_ISNULL
{
public:
- virtual bool operate(const OOperand*, const OOperand* = nullptr) const override;
+ virtual bool operate(const OOperand*, const OOperand*) const override;
};
class OOO_DLLPUBLIC_FILE OOp_LIKE : public OBoolOperator