diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2021-09-23 15:03:45 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2021-09-23 21:58:09 +0200 |
| commit | ebe57117c470a87a6b4201537616bd1379257c02 (patch) | |
| tree | 59d8b55ff2a7d45c6a8292bf076177fe4a85d71f /connectivity/source/sdbcx/VTable.cxx | |
| parent | 262bfd71808b53f008b8ab3307d62ddc5e2b88a1 (diff) | |
leaks of OCollection in dbase import
presumably since...
commit 5c7b954935369cbbd22a6f43be63ac7c0ddbbfdc
Date: Mon Jan 29 13:28:44 2018 +0200
loplugin:useuniqueptr in OTable
OCollection has a unique and nonstandard acquire/release which forwards
to a parent cppu::OWeakObject. So when it would appear to a casual
observer, who assumes that it has an internal refcount, that its
refcount would drop to zero and then get auto-deleted, nothing of the
kind occurs.
Change-Id: Ic292663a61b4d7dbf7636be7ad4c00aed0b5a7fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122528
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'connectivity/source/sdbcx/VTable.cxx')
| -rw-r--r-- | connectivity/source/sdbcx/VTable.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/connectivity/source/sdbcx/VTable.cxx b/connectivity/source/sdbcx/VTable.cxx index 98e2767259f7..7a28bc5f4289 100644 --- a/connectivity/source/sdbcx/VTable.cxx +++ b/connectivity/source/sdbcx/VTable.cxx @@ -164,7 +164,7 @@ Reference< XNameAccess > SAL_CALL OTable::getColumns( ) // allowed } - return m_xColumns; + return m_xColumns.get(); } @@ -236,7 +236,7 @@ Reference< XNameAccess > SAL_CALL OTable::getIndexes( ) // allowed } - return m_xIndexes; + return m_xIndexes.get(); } // XRename |