new loplugin automem

find places where we should be using std::unique_ptr

Change-Id: I5b9defe778fdc4738ecea381215396874db59e66

1 files changed, 91 insertions, 0 deletions

diff --git a/compilerplugins/clang/automem.cxx b/compilerplugins/clang/automem.cxx
new file mode 100644
index 000000000000..7981c7aa4168
--- /dev/null
+++ b/compilerplugins/clang/automem.cxx
@@ -0,0 +1,91 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include <cassert>
+#include <string>
+#include <iostream>
+#include <fstream>
+#include <set>
+#include "plugin.hxx"
+#include "compat.hxx"
+
+/**
+  Find calls to "delete x" where x is a field on an object.
+  Should rather be using std::unique_ptr
+*/
+
+namespace {
+
+class AutoMem:
+    public RecursiveASTVisitor<AutoMem>, public loplugin::Plugin
+{
+public:
+    explicit AutoMem(InstantiationData const & data): Plugin(data) {}
+
+    virtual void run() override
+    {
+        TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
+    }
+
+    bool TraverseCXXDestructorDecl(CXXDestructorDecl* );
+    bool VisitCXXDeleteExpr(const CXXDeleteExpr* );
+private:
+    bool mbInsideDestructor;
+};
+
+bool AutoMem::TraverseCXXDestructorDecl(CXXDestructorDecl* expr)
+{
+    mbInsideDestructor = true;
+    bool ret = RecursiveASTVisitor::TraverseCXXDestructorDecl(expr);
+    mbInsideDestructor = false;
+    return ret;
+}
+
+bool AutoMem::VisitCXXDeleteExpr(const CXXDeleteExpr* expr)
+{
+    if (ignoreLocation( expr ))
+        return true;
+    StringRef aFileName = compiler.getSourceManager().getFilename(compiler.getSourceManager().getSpellingLoc(expr->getLocStart()));
+    if (aFileName.startswith(SRCDIR "/include/salhelper/")
+        || aFileName.startswith(SRCDIR "/include/osl/")
+        || aFileName.startswith(SRCDIR "/salhelper/")
+        || aFileName.startswith(SRCDIR "/store/")
+        || aFileName.startswith(SRCDIR "/sal/"))
+        return true;
+
+    if (mbInsideDestructor)
+        return true;
+
+    const ImplicitCastExpr* pCastExpr = dyn_cast<ImplicitCastExpr>(expr->getArgument());
+    if (!pCastExpr)
+        return true;
+    const MemberExpr* pMemberExpr = dyn_cast<MemberExpr>(pCastExpr->getSubExpr());
+    if (!pMemberExpr)
+        return true;
+    // ignore union games
+    const FieldDecl* pFieldDecl = dyn_cast<FieldDecl>(pMemberExpr->getMemberDecl());
+    if (!pFieldDecl)
+        return true;
+    TagDecl const * td = dyn_cast<TagDecl>(pFieldDecl->getDeclContext());
+    if (td->isUnion())
+        return true;
+
+    report(
+        DiagnosticsEngine::Warning,
+        "calling delete on object field, rather use std::unique_ptr or std::scoped_ptr",
+        expr->getLocStart())
+        << expr->getSourceRange();
+    return true;
+}
+
+loplugin::Plugin::Registration< AutoMem > X("automem", false);
+
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */