diff options
| author | Noel Grandin <noelgrandin@gmail.com> | 2015-06-13 10:16:56 +0200 |
|---|---|---|
| committer | Noel Grandin <noel@peralex.com> | 2015-06-15 14:06:31 +0200 |
| commit | dcf6abfcdf3f4b7aec5796c9f6c806889328135f (patch) | |
| tree | f0d7081b5454bbe58318ec87dcc6b5465ed16965 /compilerplugins | |
| parent | 8f60697cf8e5227d503738e3c186433ac5dacfc8 (diff) | |
cppcheck:unreadVariable
Change-Id: I03981ceba67280e8ed98a9add7f24b3bd958d522
Diffstat (limited to 'compilerplugins')
| -rw-r--r-- | compilerplugins/clang/rendercontext.cxx | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/compilerplugins/clang/rendercontext.cxx b/compilerplugins/clang/rendercontext.cxx index cc2a945769c3..037c7bb2d1fa 100644 --- a/compilerplugins/clang/rendercontext.cxx +++ b/compilerplugins/clang/rendercontext.cxx @@ -93,9 +93,7 @@ bool RenderContext::VisitCXXMemberCallExpr(const CXXMemberCallExpr* pCXXMemberCa } // for calling through a pointer const ImplicitCastExpr *pImplicitCastExpr = dyn_cast<ImplicitCastExpr>(pCXXMemberCallExpr->getImplicitObjectArgument()); - std::string x = "0"; // for debugging if (pImplicitCastExpr) { - x += "1"; QualType aType = pImplicitCastExpr->getSubExpr()->getType(); if (aType->isPointerType()) aType = aType->getPointeeType(); @@ -106,7 +104,6 @@ bool RenderContext::VisitCXXMemberCallExpr(const CXXMemberCallExpr* pCXXMemberCa // for calling through a reference const DeclRefExpr *pDeclRefExpr = dyn_cast<DeclRefExpr>(pCXXMemberCallExpr->getImplicitObjectArgument()); if (pDeclRefExpr) { - x += "2"; QualType aType = pDeclRefExpr->getType(); std::string t2 = aType.getAsString(); if (t2 == "vcl::RenderContext" || t2 == "const vcl::RenderContext") @@ -115,18 +112,15 @@ bool RenderContext::VisitCXXMemberCallExpr(const CXXMemberCallExpr* pCXXMemberCa // for calling through a chain of methods const CXXMemberCallExpr *pMemberExpr = dyn_cast<CXXMemberCallExpr>(pCXXMemberCallExpr->getImplicitObjectArgument()); if (pMemberExpr) { - x += "3"; QualType aType = pMemberExpr->getType(); if (aType->isPointerType()) aType = aType->getPointeeType(); std::string t2 = aType.getAsString(); - x += t2; if (t2 == "vcl::RenderContext" || t2 == "const vcl::RenderContext") return true; } report( DiagnosticsEngine::Warning, - // + x + pCXXMemberCallExpr->getImplicitObjectArgument()->getStmtClassName() "Should be calling OutputDevice method through RenderContext.", pCXXMemberCallExpr->getLocStart()) << pCXXMemberCallExpr->getSourceRange(); |