loplugin:unusedfields improvemements

treat fields touched in operator== as not being important, which
finds some more stuff (but also adds some false+)

Change-Id: I3f5d504d7dec7945a917afbcd58c92df74f03645
Reviewed-on: https://gerrit.libreoffice.org/62020
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 43 insertions, 25 deletions

diff --git a/compilerplugins/clang/unusedfields.untouched.results b/compilerplugins/clang/unusedfields.untouched.results
index 73fd588bd617..5ddb45c81a14 100644
--- a/compilerplugins/clang/unusedfields.untouched.results
+++ b/compilerplugins/clang/unusedfields.untouched.results
@@ -20,6 +20,14 @@ canvas/source/vcl/canvasbitmap.hxx:117
     vclcanvas::CanvasBitmap mxDevice css::uno::Reference<css::rendering::XGraphicDevice>
 canvas/source/vcl/impltools.hxx:117
     vclcanvas::tools::LocalGuard aSolarGuard class SolarMutexGuard
+chart2/source/controller/dialogs/res_DataLabel.hxx:87
+    chart::DataLabelResources m_xDC_Dial std::unique_ptr<weld::CustomWeld>
+chart2/source/controller/dialogs/tp_AxisLabel.hxx:53
+    chart::SchAxisLabelTabPage m_xFlOrient std::unique_ptr<weld::Label>
+chart2/source/controller/dialogs/tp_RangeChooser.hxx:88
+    chart::RangeChooserTabPage m_xFT_Range std::unique_ptr<weld::Label>
+chart2/source/controller/dialogs/tp_TitleRotation.hxx:38
+    chart::SchAlignmentTabPage m_xFtTextDirection std::unique_ptr<weld::Label>
 chart2/source/controller/inc/RangeSelectionListener.hxx:63
     chart::RangeSelectionListener m_aControllerLockGuard class chart::ControllerLockGuardUNO
 comphelper/source/container/enumerablemap.cxx:298
@@ -40,9 +48,9 @@ cui/source/dialogs/colorpicker.cxx:714
     cui::ColorPickerDialog m_xColorField std::unique_ptr<weld::CustomWeld>
 cui/source/dialogs/colorpicker.cxx:716
     cui::ColorPickerDialog m_xColorPreview std::unique_ptr<weld::CustomWeld>
-cui/source/inc/align.hxx:98
+cui/source/inc/align.hxx:97
     svx::AlignmentTabPage m_xBoxDirection std::unique_ptr<weld::Widget>
-cui/source/inc/cfg.hxx:575
+cui/source/inc/cfg.hxx:574
     SvxNewToolbarDialog m_xBtnOK std::unique_ptr<weld::Button>
 cui/source/inc/cuicharmap.hxx:104
     SvxCharacterMap m_xShowChar std::unique_ptr<weld::CustomWeld>
@@ -64,9 +72,9 @@ cui/source/inc/cuitabarea.hxx:710
     SvxColorTabPage m_xCtlPreviewNew std::unique_ptr<weld::CustomWeld>
 cui/source/inc/FontFeaturesDialog.hxx:53
     cui::FontFeaturesDialog m_xPreviewWindow std::unique_ptr<weld::CustomWeld>
-cui/source/inc/page.hxx:105
+cui/source/inc/page.hxx:104
     SvxPageDescPage m_xOrientationFT std::unique_ptr<weld::Label>
-cui/source/inc/page.hxx:135
+cui/source/inc/page.hxx:134
     SvxPageDescPage m_xBspWin std::unique_ptr<weld::CustomWeld>
 cui/source/inc/paragrph.hxx:67
     SvxStdParagraphTabPage m_xRightLabel std::unique_ptr<weld::Label>
@@ -78,7 +86,7 @@ cui/source/inc/paragrph.hxx:159
     SvxParaAlignTabPage m_xPropertiesFL std::unique_ptr<weld::Widget>
 cui/source/inc/swpossizetabpage.hxx:88
     SvxSwPosSizeTabPage m_xExampleWN std::unique_ptr<weld::CustomWeld>
-cui/source/inc/textattr.hxx:69
+cui/source/inc/textattr.hxx:66
     SvxTextAttrPage m_xCtlPosition std::unique_ptr<weld::CustomWeld>
 cui/source/inc/transfrm.hxx:104
     SvxPositionSizeTabPage m_xCtlPos std::unique_ptr<weld::CustomWeld>
@@ -124,13 +132,13 @@ include/svtools/PlaceEditDialog.hxx:48
     PlaceEditDialog m_xBTCancel std::unique_ptr<weld::Button>
 include/svtools/unoevent.hxx:162
     SvEventDescriptor xParentRef css::uno::Reference<css::uno::XInterface>
-include/svx/ClassificationDialog.hxx:63
-    svx::ClassificationDialog m_nInsertMarkings const sal_Int16
+include/svtools/wizardmachine.hxx:119
+    svt::OWizardPage m_xContainer std::unique_ptr<weld::Container>
 include/svx/colorwindow.hxx:132
     ColorWindow mxColorSetWin std::unique_ptr<weld::CustomWeld>
 include/svx/colorwindow.hxx:133
     ColorWindow mxRecentColorSetWin std::unique_ptr<weld::CustomWeld>
-include/svx/hdft.hxx:87
+include/svx/hdft.hxx:86
     SvxHFPage m_xBspWin std::unique_ptr<weld::CustomWeld>
 include/vcl/font/Feature.hxx:102
     vcl::font::Feature m_eType const enum vcl::font::FeatureType
@@ -193,47 +201,49 @@ sal/osl/unx/thread.cxx:94
 sal/osl/unx/thread.cxx:112
     osl_thread_global_st m_priority const struct osl_thread_priority_st
 sc/inc/formulalogger.hxx:42
-    sc::FormulaLogger maMessages std::vector<OUString>
+    sc::FormulaLogger maMessages const std::vector<OUString>
 sc/inc/interpretercontext.hxx:32
     ScInterpreterContext mrDoc const class ScDocument &
 sc/qa/unit/ucalc_column.cxx:104
     aInputs aName const char *
 sc/source/core/data/document.cxx:1244
-    (anonymous namespace)::BroadcastRecalcOnRefMoveHandler aSwitch sc::AutoCalcSwitch
+    (anonymous namespace)::BroadcastRecalcOnRefMoveHandler aSwitch const sc::AutoCalcSwitch
 sc/source/core/data/document.cxx:1245
-    (anonymous namespace)::BroadcastRecalcOnRefMoveHandler aBulk class ScBulkBroadcast
+    (anonymous namespace)::BroadcastRecalcOnRefMoveHandler aBulk const class ScBulkBroadcast
 sc/source/filter/html/htmlpars.cxx:3029
     (anonymous namespace)::CSSHandler::MemStr mp const char *
 sc/source/filter/html/htmlpars.cxx:3030
     (anonymous namespace)::CSSHandler::MemStr mn size_t
 sc/source/filter/inc/sheetdatacontext.hxx:62
-    oox::xls::SheetDataContext aReleaser class SolarMutexReleaser
-sc/source/ui/inc/crdlg.hxx:33
+    oox::xls::SheetDataContext aReleaser const class SolarMutexReleaser
+sc/source/ui/inc/crdlg.hxx:32
     ScColOrRowDlg m_xBtnRows std::unique_ptr<weld::RadioButton>
 sc/source/ui/inc/delcodlg.hxx:39
     ScDeleteContentsDlg m_xBtnOk std::unique_ptr<weld::Button>
-sc/source/ui/inc/docsh.hxx:462
+sc/source/ui/inc/docsh.hxx:456
     ScDocShellModificator mpProtector std::unique_ptr<ScRefreshTimerProtector>
 sc/source/ui/inc/instbdlg.hxx:66
     ScInsertTableDlg m_xBtnBehind std::unique_ptr<weld::RadioButton>
-sd/source/ui/animations/CustomAnimationDialog.cxx:1743
+sd/source/ui/animations/CustomAnimationDialog.cxx:1746
     sd::CustomAnimationEffectTabPage mxContainer std::unique_ptr<weld::Container>
-sd/source/ui/animations/CustomAnimationDialog.cxx:1749
-    sd::CustomAnimationEffectTabPage mxFTSound std::unique_ptr<weld::Label>
 sd/source/ui/animations/CustomAnimationDialog.cxx:1752
+    sd::CustomAnimationEffectTabPage mxFTSound std::unique_ptr<weld::Label>
+sd/source/ui/animations/CustomAnimationDialog.cxx:1755
     sd::CustomAnimationEffectTabPage mxFTAfterEffect std::unique_ptr<weld::Label>
-sd/source/ui/animations/CustomAnimationDialog.cxx:2273
+sd/source/ui/animations/CustomAnimationDialog.cxx:2276
     sd::CustomAnimationDurationTabPage mxContainer std::unique_ptr<weld::Container>
-sd/source/ui/animations/CustomAnimationDialog.cxx:2274
+sd/source/ui/animations/CustomAnimationDialog.cxx:2277
     sd::CustomAnimationDurationTabPage mxFTStart std::unique_ptr<weld::Label>
-sd/source/ui/animations/CustomAnimationDialog.cxx:2276
+sd/source/ui/animations/CustomAnimationDialog.cxx:2279
     sd::CustomAnimationDurationTabPage mxFTStartDelay std::unique_ptr<weld::Label>
-sd/source/ui/animations/CustomAnimationDialog.cxx:2639
+sd/source/ui/animations/CustomAnimationDialog.cxx:2642
     sd::CustomAnimationTextAnimTabPage mxContainer std::unique_ptr<weld::Container>
-sd/source/ui/animations/CustomAnimationDialog.cxx:2640
+sd/source/ui/animations/CustomAnimationDialog.cxx:2643
     sd::CustomAnimationTextAnimTabPage mxFTGroupText std::unique_ptr<weld::Label>
-sd/source/ui/animations/CustomAnimationDialog.hxx:150
+sd/source/ui/animations/CustomAnimationDialog.hxx:148
     sd::SdPropertySubControl mxContainer std::unique_ptr<weld::Container>
+sd/source/ui/animations/CustomAnimationDialog.hxx:149
+    sd::SdPropertySubControl mnType sal_Int32
 sd/source/ui/dlg/PhotoAlbumDialog.hxx:60
     sd::SdPhotoAlbumDialog m_xImg std::unique_ptr<weld::CustomWeld>
 sd/source/ui/inc/custsdlg.hxx:43
@@ -328,6 +338,14 @@ sw/source/uibase/inc/dbui.hxx:31
     PrintMonitor m_xDocName std::unique_ptr<weld::Label>
 sw/source/uibase/inc/drpcps.hxx:141
     SwDropCapsPage m_xPict std::unique_ptr<weld::CustomWeld>
+sw/source/uibase/inc/frmpage.hxx:227
+    SwGrfExtPage m_xFlAngle std::unique_ptr<weld::Frame>
+sw/source/uibase/inc/frmpage.hxx:296
+    SwFrameAddPage m_xDescriptionFT std::unique_ptr<weld::Label>
+sw/source/uibase/inc/frmpage.hxx:298
+    SwFrameAddPage m_xPrevFT std::unique_ptr<weld::Label>
+sw/source/uibase/inc/frmpage.hxx:300
+    SwFrameAddPage m_xNextFT std::unique_ptr<weld::Label>
 sw/source/uibase/inc/insfnote.hxx:38
     SwInsFootNoteDlg m_xNumberFrame std::unique_ptr<weld::Widget>
 sw/source/uibase/inc/num.hxx:55
@@ -338,7 +356,7 @@ sw/source/uibase/inc/outline.hxx:98
     SwOutlineSettingsTabPage m_xPreviewWIN std::unique_ptr<weld::CustomWeld>
 sw/source/uibase/inc/pggrid.hxx:44
     SwTextGridPage m_xExampleWN std::unique_ptr<weld::CustomWeld>
-sw/source/uibase/inc/regionsw.hxx:233
+sw/source/uibase/inc/regionsw.hxx:232
     SwSectionIndentTabPage m_xPreviewWin std::unique_ptr<weld::CustomWeld>
 sw/source/uibase/inc/splittbl.hxx:30
     SwSplitTableDlg m_xHorzBox std::unique_ptr<weld::RadioButton>
@@ -372,7 +390,7 @@ vcl/unx/generic/print/prtsetup.hxx:73
     RTSPaperPage m_xContainer std::unique_ptr<weld::Widget>
 vcl/unx/generic/print/prtsetup.hxx:108
     RTSDevicePage m_xContainer std::unique_ptr<weld::Widget>
-vcl/unx/gtk3/gtk3gtkinst.cxx:2398
+vcl/unx/gtk3/gtk3gtkinst.cxx:2403
     CrippledViewport viewport GtkViewport
 vcl/unx/gtk/a11y/atkhypertext.cxx:29
     (anonymous) atk_hyper_link const AtkHyperlink