loplugin:unusedfields

Change-Id: I42a55562747e6097c1193e285da67235f5364bea
Reviewed-on: https://gerrit.libreoffice.org/55610
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 114 insertions, 50 deletions

diff --git a/compilerplugins/clang/unusedfields.untouched.results b/compilerplugins/clang/unusedfields.untouched.results
index e2cb089eb3a9..8327a541b2d5 100644
--- a/compilerplugins/clang/unusedfields.untouched.results
+++ b/compilerplugins/clang/unusedfields.untouched.results
@@ -5,9 +5,9 @@ avmedia/source/vlc/wrapper/Types.hxx:44
 avmedia/source/vlc/wrapper/Types.hxx:45
     libvlc_event_t::(anonymous union)::(anonymous) dummy2 const char *
 avmedia/source/vlc/wrapper/Types.hxx:46
-    libvlc_event_t::(anonymous) padding struct (anonymous struct at /home/noel/libo3/avmedia/source/vlc/wrapper/Types.hxx:43:7)
+    libvlc_event_t::(anonymous) padding struct (anonymous struct at /home/noel/libo/avmedia/source/vlc/wrapper/Types.hxx:43:7)
 avmedia/source/vlc/wrapper/Types.hxx:47
-    libvlc_event_t u union (anonymous union at /home/noel/libo3/avmedia/source/vlc/wrapper/Types.hxx:41:5)
+    libvlc_event_t u union (anonymous union at /home/noel/libo/avmedia/source/vlc/wrapper/Types.hxx:41:5)
 avmedia/source/vlc/wrapper/Types.hxx:53
     libvlc_track_description_t psz_name char *
 basctl/source/inc/dlged.hxx:122
@@ -32,7 +32,7 @@ chart2/source/view/inc/GL3DRenderer.hxx:65
     chart::opengl3D::LightSource pad2 float
 chart2/source/view/inc/GL3DRenderer.hxx:66
     chart::opengl3D::LightSource pad3 float
-comphelper/source/container/enumerablemap.cxx:299
+comphelper/source/container/enumerablemap.cxx:298
     comphelper::MapEnumeration m_xKeepMapAlive Reference<class com::sun::star::uno::XInterface>
 connectivity/source/drivers/evoab2/EApi.h:122
     (anonymous) address_format char *
@@ -46,17 +46,47 @@ cppu/source/threadpool/threadpool.cxx:355
     _uno_ThreadPool dummy sal_Int32
 cppu/source/typelib/typelib.cxx:62
     AlignSize_Impl nInt16 sal_Int16
+cui/source/dialogs/colorpicker.cxx:721
+    cui::ColorPickerDialog m_xColorField std::unique_ptr<weld::CustomWeld>
+cui/source/dialogs/colorpicker.cxx:723
+    cui::ColorPickerDialog m_xColorPreview std::unique_ptr<weld::CustomWeld>
+cui/source/inc/cfg.hxx:577
+    SvxNewToolbarDialog m_xBtnOK std::unique_ptr<weld::Button>
+cui/source/inc/cuicharmap.hxx:104
+    SvxCharacterMap m_xShowChar std::unique_ptr<weld::CustomWeld>
+cui/source/inc/cuicharmap.hxx:105
+    SvxCharacterMap m_xRecentCharView std::unique_ptr<weld::CustomWeld> [16]
+cui/source/inc/cuicharmap.hxx:106
+    SvxCharacterMap m_xFavCharView std::unique_ptr<weld::CustomWeld> [16]
+cui/source/inc/cuicharmap.hxx:108
+    SvxCharacterMap m_xShowSetArea std::unique_ptr<weld::CustomWeld>
+cui/source/inc/cuicharmap.hxx:110
+    SvxCharacterMap m_xSearchSetArea std::unique_ptr<weld::CustomWeld>
 cui/source/inc/insrc.hxx:31
     SvxInsRowColDlg m_xBeforeBtn std::unique_ptr<weld::RadioButton>
+cui/source/inc/swpossizetabpage.hxx:88
+    SvxSwPosSizeTabPage m_xExampleWN std::unique_ptr<weld::CustomWeld>
+cui/source/inc/textattr.hxx:69
+    SvxTextAttrPage m_xCtlPosition std::unique_ptr<weld::CustomWeld>
+cui/source/inc/transfrm.hxx:102
+    SvxPositionSizeTabPage m_xCtlPos std::unique_ptr<weld::CustomWeld>
+cui/source/inc/transfrm.hxx:189
+    SvxAngleTabPage m_xCtlRect std::unique_ptr<weld::CustomWeld>
+cui/source/inc/transfrm.hxx:192
+    SvxAngleTabPage m_xCtlAngle std::unique_ptr<weld::CustomWeld>
 dbaccess/source/sdbtools/inc/connectiondependent.hxx:116
     sdbtools::ConnectionDependentComponent::EntryGuard m_aMutexGuard ::osl::MutexGuard
 emfio/source/emfuno/xemfparser.cxx:60
     emfio::emfreader::XEmfParser context_ uno::Reference<uno::XComponentContext>
 extensions/source/scanner/scanner.hxx:44
     ScannerManager maProtector osl::Mutex
+filter/source/xsltdialog/xmlfiltertabpagebasic.hxx:36
+    XMLFilterTabPageBasic m_xContainer std::unique_ptr<weld::Widget>
+filter/source/xsltdialog/xmlfiltertabpagexslt.hxx:48
+    XMLFilterTabPageXSLT m_xContainer std::unique_ptr<weld::Widget>
 include/drawinglayer/primitive2d/textlayoutdevice.hxx:61
     drawinglayer::primitive2d::TextLayouterDevice maSolarGuard class SolarMutexGuard
-include/editeng/unotext.hxx:613
+include/editeng/unotext.hxx:612
     SvxUnoTextRangeEnumeration mxParentText css::uno::Reference<css::text::XText>
 include/LibreOfficeKit/LibreOfficeKitGtk.h:33
     _LOKDocView aDrawingArea GtkDrawingArea
@@ -70,31 +100,17 @@ include/sfx2/msg.hxx:117
     SfxType0 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
 include/sfx2/msg.hxx:119
     SfxType0 nAttribs sal_uInt16
-include/svtools/genericunodialog.hxx:219
+include/sfx2/tabdlg.hxx:238
+    SfxTabDialogController m_xApplyBtn std::unique_ptr<weld::Button>
+include/svtools/genericunodialog.hxx:218
     svt::UnoDialogEntryGuard m_aGuard ::osl::MutexGuard
+include/svtools/PlaceEditDialog.hxx:48
+    PlaceEditDialog m_xBTCancel std::unique_ptr<weld::Button>
 include/svtools/unoevent.hxx:162
     SvEventDescriptor xParentRef css::uno::Reference<css::uno::XInterface>
 include/svx/ClassificationDialog.hxx:63
     svx::ClassificationDialog m_nInsertMarkings sal_Int16
-include/vcl/pdfwriter.hxx:548
-    vcl::PDFWriter::PDFSignContext m_pDerEncoded sal_Int8 *
-include/vcl/pdfwriter.hxx:550
-    vcl::PDFWriter::PDFSignContext m_nDerEncoded sal_Int32
-include/vcl/pdfwriter.hxx:552
-    vcl::PDFWriter::PDFSignContext m_pByteRange1 void *
-include/vcl/pdfwriter.hxx:554
-    vcl::PDFWriter::PDFSignContext m_nByteRange1 sal_Int32
-include/vcl/pdfwriter.hxx:556
-    vcl::PDFWriter::PDFSignContext m_pByteRange2 void *
-include/vcl/pdfwriter.hxx:558
-    vcl::PDFWriter::PDFSignContext m_nByteRange2 sal_Int32
-include/vcl/pdfwriter.hxx:559
-    vcl::PDFWriter::PDFSignContext m_aSignTSA class rtl::OUString
-include/vcl/pdfwriter.hxx:560
-    vcl::PDFWriter::PDFSignContext m_aSignPassword class rtl::OUString
-include/vcl/pdfwriter.hxx:562
-    vcl::PDFWriter::PDFSignContext m_rCMSHexBuffer class rtl::OStringBuffer &
-include/vcl/uitest/uiobject.hxx:262
+include/vcl/uitest/uiobject.hxx:268
     TabPageUIObject mxTabPage VclPtr<class TabPage>
 include/xmloff/formlayerexport.hxx:173
     xmloff::OOfficeFormsExport m_pImpl std::unique_ptr<OFormsRootExport>
@@ -128,7 +144,7 @@ libreofficekit/qa/gtktiledviewer/gtv-main-toolbar.hxx:36
     GtvMainToolbarClass parentClass GtkBoxClass
 lotuswordpro/source/filter/clone.hxx:23
     detail::has_clone::(anonymous) a char [2]
-opencl/source/openclwrapper.cxx:306
+opencl/source/openclwrapper.cxx:305
     openclwrapper::(anonymous namespace)::OpenCLEnv mpOclCmdQueue cl_command_queue [1]
 pyuno/source/module/pyuno_impl.hxx:224
     pyuno::(anonymous) ob_base PyObject
@@ -152,27 +168,41 @@ sc/inc/formulalogger.hxx:42
     sc::FormulaLogger maMessages std::vector<OUString>
 sc/inc/interpretercontext.hxx:23
     ScInterpreterContext mrDoc const class ScDocument &
-sc/qa/unit/ucalc_column.cxx:103
+sc/qa/unit/ucalc_column.cxx:104
     aInputs aName const char *
-sc/source/core/data/document.cxx:1262
+sc/source/core/data/document.cxx:1248
     (anonymous namespace)::BroadcastRecalcOnRefMoveHandler aSwitch sc::AutoCalcSwitch
-sc/source/core/data/document.cxx:1263
+sc/source/core/data/document.cxx:1249
     (anonymous namespace)::BroadcastRecalcOnRefMoveHandler aBulk class ScBulkBroadcast
-sc/source/core/data/formulacell.cxx:1741
+sc/source/core/data/formulacell.cxx:1756
     (anonymous namespace)::StackCleaner pInt std::unique_ptr<ScInterpreter>
-sc/source/filter/inc/orcusinterface.hxx:559
-    ScOrcusFactory maRefResolver class ScOrcusRefResolver
 sc/source/filter/inc/sheetdatacontext.hxx:61
     oox::xls::SheetDataContext aReleaser class SolarMutexReleaser
-sc/source/ui/inc/docsh.hxx:445
+sc/source/ui/inc/crdlg.hxx:33
+    ScColOrRowDlg m_xBtnRows std::unique_ptr<weld::RadioButton>
+sc/source/ui/inc/delcodlg.hxx:39
+    ScDeleteContentsDlg m_xBtnOk std::unique_ptr<weld::Button>
+sc/source/ui/inc/docsh.hxx:460
     ScDocShellModificator mpProtector std::unique_ptr<ScRefreshTimerProtector>
+sc/source/ui/inc/instbdlg.hxx:66
+    ScInsertTableDlg m_xBtnBehind std::unique_ptr<weld::RadioButton>
+sd/source/ui/dlg/PhotoAlbumDialog.hxx:60
+    sd::SdPhotoAlbumDialog m_xImg std::unique_ptr<weld::CustomWeld>
+sd/source/ui/inc/custsdlg.hxx:43
+    SdCustomShowDlg m_xBtnHelp std::unique_ptr<weld::Button>
+sd/source/ui/inc/custsdlg.hxx:45
+    SdCustomShowDlg m_xBtnOK std::unique_ptr<weld::Button>
+sd/source/ui/inc/custsdlg.hxx:75
+    SdDefineCustomShowDlg m_xBtnCancel std::unique_ptr<weld::Button>
+sd/source/ui/inc/custsdlg.hxx:76
+    SdDefineCustomShowDlg m_xBtnHelp std::unique_ptr<weld::Button>
 sd/source/ui/remotecontrol/ZeroconfService.hxx:36
     sd::ZeroconfService port uint
 sd/source/ui/slidesorter/view/SlsLayouter.cxx:61
     sd::slidesorter::view::Layouter::Implementation mpTheme std::shared_ptr<view::Theme>
-sd/source/ui/table/TableDesignPane.hxx:113
+sd/source/ui/table/TableDesignPane.hxx:106
     sd::TableDesignPane aImpl class sd::TableDesignWidget
-sd/source/ui/view/DocumentRenderer.cxx:1319
+sd/source/ui/view/DocumentRenderer.cxx:1321
     sd::DocumentRenderer::Implementation mxObjectShell SfxObjectShellRef
 sd/source/ui/view/viewshel.cxx:1215
     sd::KeepSlideSorterInSyncWithPageChanges m_aDrawLock sd::slidesorter::view::class SlideSorterView::DrawLock
@@ -182,14 +212,24 @@ sd/source/ui/view/viewshel.cxx:1217
     sd::KeepSlideSorterInSyncWithPageChanges m_aUpdateLock sd::slidesorter::controller::class PageSelector::UpdateLock
 sd/source/ui/view/viewshel.cxx:1218
     sd::KeepSlideSorterInSyncWithPageChanges m_aContext sd::slidesorter::controller::class SelectionObserver::Context
-sd/source/ui/view/ViewShellBase.cxx:191
+sd/source/ui/view/ViewShellBase.cxx:192
     sd::ViewShellBase::Implementation mpPageCacheManager std::shared_ptr<slidesorter::cache::PageCacheManager>
-sfx2/source/doc/doctempl.cxx:115
+sfx2/source/doc/doctempl.cxx:114
     DocTempl::DocTempl_EntryData_Impl mxObjShell class SfxObjectShellLock
-sfx2/source/view/viewfrm.cxx:159
+sfx2/source/view/viewfrm.cxx:158
     (anonymous namespace)::SfxEditDocumentDialog m_xEditDocument std::unique_ptr<weld::Button>
-sfx2/source/view/viewfrm.cxx:160
+sfx2/source/view/viewfrm.cxx:159
     (anonymous namespace)::SfxEditDocumentDialog m_xCancel std::unique_ptr<weld::Button>
+starmath/inc/dialog.hxx:347
+    SmSymbolDialog m_xSymbolSetDisplayArea std::unique_ptr<weld::CustomWeld>
+starmath/inc/dialog.hxx:349
+    SmSymbolDialog m_xSymbolDisplay std::unique_ptr<weld::CustomWeld>
+starmath/inc/dialog.hxx:426
+    SmSymDefineDialog m_xOldSymbolDisplay std::unique_ptr<weld::CustomWeld>
+starmath/inc/dialog.hxx:427
+    SmSymDefineDialog m_xSymbolDisplay std::unique_ptr<weld::CustomWeld>
+starmath/inc/dialog.hxx:429
+    SmSymDefineDialog m_xCharsetDisplayArea std::unique_ptr<weld::CustomWeld>
 starmath/inc/smmod.hxx:69
     SmModule mpLocSymbolData std::unique_ptr<SmLocalizedSymbolData>
 starmath/inc/view.hxx:218
@@ -206,18 +246,40 @@ svl/source/crypto/cryptosign.cxx:280
     (anonymous namespace)::(anonymous) statusString SECItem
 svl/source/crypto/cryptosign.cxx:281
     (anonymous namespace)::(anonymous) failInfo SECItem
+svtools/source/control/valueimp.hxx:81
+    SvtValueSetItem mpData void *
 svtools/source/svhtml/htmlkywd.cxx:558
-    HTML_OptionEntry  union HTML_OptionEntry::(anonymous at /home/noel/libo3/svtools/source/svhtml/htmlkywd.cxx:558:5)
+    HTML_OptionEntry  union HTML_OptionEntry::(anonymous at /home/noel/libo/svtools/source/svhtml/htmlkywd.cxx:558:5)
 svtools/source/svhtml/htmlkywd.cxx:560
     HTML_OptionEntry::(anonymous) sToken const sal_Char *
 svtools/source/svhtml/htmlkywd.cxx:561
     HTML_OptionEntry::(anonymous) pUToken const class rtl::OUString *
+svx/source/inc/datanavi.hxx:610
+    svxform::AddInstanceDialog m_xURLFT std::unique_ptr<weld::Label>
 sw/source/core/crsr/crbm.cxx:64
     (anonymous namespace)::CursorStateHelper m_aSaveState class SwCursorSaveState
-sw/source/core/frmedt/fetab.cxx:77
+sw/source/core/frmedt/fetab.cxx:79
     TableWait m_pWait const std::unique_ptr<SwWait>
-sw/source/core/layout/dbg_lay.cxx:164
+sw/source/core/layout/dbg_lay.cxx:169
     SwImplEnterLeave nAction enum DbgAction
+sw/source/ui/envelp/labfmt.hxx:75
+    SwLabFormatPage m_xPreview std::unique_ptr<weld::CustomWeld>
+sw/source/ui/inc/mmresultdialogs.hxx:72
+    SwMMResultPrintDialog m_xPrinterFT std::unique_ptr<weld::Label>
+sw/source/ui/misc/impfnote.hxx:44
+    SwEndNoteOptionPage m_xPosFT std::unique_ptr<weld::Label>
+sw/source/uibase/inc/dbui.hxx:31
+    PrintMonitor m_xDocName std::unique_ptr<weld::Label>
+sw/source/uibase/inc/insfnote.hxx:38
+    SwInsFootNoteDlg m_xNumberFrame std::unique_ptr<weld::Widget>
+sw/source/uibase/inc/num.hxx:55
+    SwNumPositionTabPage m_xPositionFrame std::unique_ptr<weld::Widget>
+sw/source/uibase/inc/num.hxx:82
+    SwNumPositionTabPage m_xPreviewWIN std::unique_ptr<weld::CustomWeld>
+sw/source/uibase/inc/outline.hxx:98
+    SwOutlineSettingsTabPage m_xPreviewWIN std::unique_ptr<weld::CustomWeld>
+sw/source/uibase/inc/regionsw.hxx:234
+    SwSectionIndentTabPage m_xPreviewWin std::unique_ptr<weld::CustomWeld>
 sw/source/uibase/inc/splittbl.hxx:30
     SwSplitTableDlg m_xHorzBox std::unique_ptr<weld::RadioButton>
 sw/source/uibase/inc/splittbl.hxx:31
@@ -236,21 +298,23 @@ uui/source/unknownauthdlg.hxx:36
     UnknownAuthDialog m_xOptionButtonDontAccept std::unique_ptr<weld::RadioButton>
 vcl/inc/opengl/zone.hxx:46
     OpenGLVCLContextZone aZone class OpenGLZone
-vcl/inc/unx/cpdmgr.hxx:60
-    psp::CPDPrinterOption name class rtl::OUString
-vcl/inc/unx/cpdmgr.hxx:61
-    psp::CPDPrinterOption default_value class rtl::OUString
-vcl/inc/unx/cpdmgr.hxx:62
-    psp::CPDPrinterOption num_supported_values int
-vcl/inc/unx/cpdmgr.hxx:63
-    psp::CPDPrinterOption supported_values std::vector<OUString>
+vcl/inc/salprn.hxx:44
+    SalPrinterQueueInfo mpPortName std::unique_ptr<OUString>
+vcl/source/app/salvtables.cxx:463
+    SalInstanceContainer m_xContainer VclPtr<vcl::Window>
 vcl/source/gdi/jobset.cxx:34
     ImplOldJobSetupData cDeviceName char [32]
 vcl/source/gdi/jobset.cxx:35
     ImplOldJobSetupData cPortName char [32]
 vcl/source/uitest/uno/uitest_uno.cxx:35
     UITestUnoObj mpUITest std::unique_ptr<UITest>
-vcl/unx/gtk3/gtk3gtkinst.cxx:1937
+vcl/unx/generic/print/prtsetup.hxx:73
+    RTSPaperPage m_xContainer std::unique_ptr<weld::Widget>
+vcl/unx/generic/print/prtsetup.hxx:108
+    RTSDevicePage m_xContainer std::unique_ptr<weld::Widget>
+vcl/unx/gtk3/gtk3gtkinst.cxx:2166
     CrippledViewport viewport GtkViewport
 vcl/unx/gtk/a11y/atkhypertext.cxx:29
     (anonymous) atk_hyper_link AtkHyperlink
+writerperfect/inc/WPFTEncodingDialog.hxx:37
+    writerperfect::WPFTEncodingDialog m_xBtnOk std::unique_ptr<weld::Button>