loplugin:unusedenumconstants improvements

add some unit tests, and improve the heuristics

Change-Id: I95aa97a87e178ce8d506bd245710d0ae66ad08a4
Reviewed-on: https://gerrit.libreoffice.org/63647
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 101 insertions, 145 deletions

diff --git a/compilerplugins/clang/unusedenumconstants.untouched.results b/compilerplugins/clang/unusedenumconstants.untouched.results
index b586272daa6b..d31d48928b5a 100644
--- a/compilerplugins/clang/unusedenumconstants.untouched.results
+++ b/compilerplugins/clang/unusedenumconstants.untouched.results
@@ -1,5 +1,3 @@
-dbaccess/source/filter/xml/xmlEnums.hxx:31
-    enum dbaxml::XMLDocTokens XML_TOK_DOC_META
 drawinglayer/source/tools/emfpbrush.hxx:32
     enum emfplushelper::EmfPlusHatchStyle HatchStyleVertical
 drawinglayer/source/tools/emfpbrush.hxx:33
@@ -80,213 +78,171 @@ drawinglayer/source/tools/emfpbrush.hxx:82
     enum emfplushelper::EmfPlusHatchStyle HatchStyleOutlinedDiamond
 drawinglayer/source/tools/emfpbrush.hxx:83
     enum emfplushelper::EmfPlusHatchStyle HatchStyleSolidDiamond
-drawinglayer/source/tools/emfphelperdata.cxx:101
+drawinglayer/source/tools/emfpimage.hxx:31
     emfplushelper::ImageDataType ImageDataTypeUnknown
-drawinglayer/source/tools/emfphelperdata.hxx:110
-    enum emfplushelper::UnitType UnitTypeWorld
-drawinglayer/source/tools/emfphelperdata.hxx:111
-    enum emfplushelper::UnitType UnitTypeDisplay
-drawinglayer/source/tools/emfphelperdata.hxx:113
-    enum emfplushelper::UnitType UnitTypePoint
-drawinglayer/source/tools/emfphelperdata.hxx:114
-    enum emfplushelper::UnitType UnitTypeInch
-drawinglayer/source/tools/emfphelperdata.hxx:115
-    enum emfplushelper::UnitType UnitTypeDocument
-drawinglayer/source/tools/emfphelperdata.hxx:116
-    enum emfplushelper::UnitType UnitTypeMillimeter
-include/connectivity/dbtools.hxx:831
+include/connectivity/dbtools.hxx:822
     enum connectivity::dbase::DBFType dBaseIVMemo
 include/editeng/borderline.hxx:128
     enum SvxBorderLineStyle BORDER_LINE_STYLE_MAX
-include/i18nutil/transliteration.hxx:46
+include/i18nutil/transliteration.hxx:45
     enum TransliterationFlags NumToTextLower_zh_CN
-include/i18nutil/transliteration.hxx:48
+include/i18nutil/transliteration.hxx:47
     enum TransliterationFlags NumToTextUpper_zh_CN
-include/i18nutil/transliteration.hxx:50
+include/i18nutil/transliteration.hxx:49
     enum TransliterationFlags NumToTextLower_zh_TW
-include/i18nutil/transliteration.hxx:52
+include/i18nutil/transliteration.hxx:51
     enum TransliterationFlags NumToTextUpper_zh_TW
-include/i18nutil/transliteration.hxx:54
+include/i18nutil/transliteration.hxx:53
     enum TransliterationFlags NumToTextFormalHangul_ko
-include/i18nutil/transliteration.hxx:56
+include/i18nutil/transliteration.hxx:55
     enum TransliterationFlags NumToTextFormalLower_ko
-include/i18nutil/transliteration.hxx:58
+include/i18nutil/transliteration.hxx:57
     enum TransliterationFlags NumToTextFormalUpper_ko
-include/i18nutil/transliteration.hxx:118
+include/i18nutil/transliteration.hxx:117
     enum TransliterationFlags smallToLarge_ja_JP
-include/i18nutil/transliteration.hxx:120
+include/i18nutil/transliteration.hxx:119
     enum TransliterationFlags largeToSmall_ja_JP
-include/LibreOfficeKit/LibreOfficeKitEnums.h:38
-    LibreOfficeKitTileMode LOK_TILEMODE_RGBA
+include/LibreOfficeKit/LibreOfficeKitEnums.h:628
+    LibreOfficeKitExtTextInputType LOK_EXT_TEXTINPUT_POS
 include/oox/ole/axfontdata.hxx:39
     enum AxFontFlags Disabled
 include/oox/ole/axfontdata.hxx:40
     enum AxFontFlags AutoColor
-include/svx/cube3d.hxx:57
-    enum CubeFaces Full
-include/unotools/eventcfg.hxx:33
+include/unotools/eventcfg.hxx:29
     enum GlobalEventId STARTAPP
-include/unotools/eventcfg.hxx:34
+include/unotools/eventcfg.hxx:30
     enum GlobalEventId CLOSEAPP
+include/vcl/syswin.hxx:54
+    enum WindowStateState FullScreen
 libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx:61
-    enum (anonymous at /home/noel/libo3/libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx:59:1) PROP_0
+    enum (anonymous at /media/noel/disk2/libo6/libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx:59:1) PROP_0
 libreofficekit/source/gtk/lokdocview.cxx:287
-    enum (anonymous at /home/noel/libo3/libreofficekit/source/gtk/lokdocview.cxx:285:1) PROP_0
-sc/source/filter/xml/xmlimprt.hxx:89
-    enum ScXMLCondFormatsTokens XML_TOK_CONDFORMATS_CONDFORMAT
-sc/source/filter/xml/xmlimprt.hxx:94
-    enum ScXMLCondFormatTokens XML_TOK_CONDFORMAT_COLORSCALE
-sc/source/filter/xml/xmlimprt.hxx:95
-    enum ScXMLCondFormatTokens XML_TOK_CONDFORMAT_DATABAR
-sc/source/filter/xml/xmlimprt.hxx:96
-    enum ScXMLCondFormatTokens XML_TOK_CONDFORMAT_CONDITION
-sc/source/filter/xml/xmlimprt.hxx:97
-    enum ScXMLCondFormatTokens XML_TOK_CONDFORMAT_ICONSET
-sc/source/filter/xml/xmlimprt.hxx:98
-    enum ScXMLCondFormatTokens XML_TOK_CONDFORMAT_DATE
-sc/source/filter/xml/xmlimprt.hxx:103
-    enum ScXMLCondFormatAttrTokens XML_TOK_CONDFORMAT_TARGET_RANGE
-sc/source/filter/xml/xmlimprt.hxx:108
-    enum ScXMLCondDateAttrTokens XML_TOK_COND_DATE_VALUE
-sc/source/filter/xml/xmlimprt.hxx:109
-    enum ScXMLCondDateAttrTokens XML_TOK_COND_DATE_STYLE
-sc/source/filter/xml/xmlimprt.hxx:114
-    enum ScXMLConditionAttrTokens XML_TOK_CONDITION_VALUE
-sc/source/filter/xml/xmlimprt.hxx:115
-    enum ScXMLConditionAttrTokens XML_TOK_CONDITION_APPLY_STYLE_NAME
-sc/source/filter/xml/xmlimprt.hxx:116
-    enum ScXMLConditionAttrTokens XML_TOK_CONDITION_BASE_CELL_ADDRESS
-sc/source/filter/xml/xmlimprt.hxx:121
-    enum ScXMLColorScaleFormatTokens XML_TOK_COLORSCALE_COLORSCALEENTRY
-sc/source/filter/xml/xmlimprt.hxx:126
-    enum ScXMLColorScaleEntryAttrTokens XML_TOK_COLORSCALEENTRY_TYPE
-sc/source/filter/xml/xmlimprt.hxx:127
-    enum ScXMLColorScaleEntryAttrTokens XML_TOK_COLORSCALEENTRY_VALUE
-sc/source/filter/xml/xmlimprt.hxx:128
-    enum ScXMLColorScaleEntryAttrTokens XML_TOK_COLORSCALEENTRY_COLOR
-sc/source/filter/xml/xmlimprt.hxx:133
-    enum ScXMLFormattingFormatTokens XML_TOK_DATABAR_DATABARENTRY
-sc/source/filter/xml/xmlimprt.hxx:134
-    enum ScXMLFormattingFormatTokens XML_TOK_FORMATTING_ENTRY
-sc/source/filter/xml/xmlimprt.hxx:139
-    enum ScXMLDataBarAttrTokens XML_TOK_DATABAR_POSITIVE_COLOR
-sc/source/filter/xml/xmlimprt.hxx:140
-    enum ScXMLDataBarAttrTokens XML_TOK_DATABAR_NEGATIVE_COLOR
-sc/source/filter/xml/xmlimprt.hxx:141
-    enum ScXMLDataBarAttrTokens XML_TOK_DATABAR_GRADIENT
-sc/source/filter/xml/xmlimprt.hxx:142
-    enum ScXMLDataBarAttrTokens XML_TOK_DATABAR_AXISPOSITION
-sc/source/filter/xml/xmlimprt.hxx:143
-    enum ScXMLDataBarAttrTokens XML_TOK_DATABAR_SHOWVALUE
-sc/source/filter/xml/xmlimprt.hxx:144
-    enum ScXMLDataBarAttrTokens XML_TOK_DATABAR_AXISCOLOR
-sc/source/filter/xml/xmlimprt.hxx:145
-    enum ScXMLDataBarAttrTokens XML_TOK_DATABAR_MINLENGTH
-sc/source/filter/xml/xmlimprt.hxx:146
-    enum ScXMLDataBarAttrTokens XML_TOK_DATABAR_MAXLENGTH
-sc/source/filter/xml/xmlimprt.hxx:151
-    enum ScXMLDataBarEntryAttrTokens XML_TOK_DATABARENTRY_TYPE
-sc/source/filter/xml/xmlimprt.hxx:152
-    enum ScXMLDataBarEntryAttrTokens XML_TOK_DATABARENTRY_VALUE
-sc/source/filter/xml/xmlimprt.hxx:157
-    enum ScXMLIconSetAttrTokens XML_TOK_ICONSET_TYPE
-sc/source/filter/xml/xmlimprt.hxx:158
-    enum ScXMLIconSetAttrTokens XML_TOK_ICONSET_SHOWVALUE
-svgio/inc/svgstyleattributes.hxx:104
-    enum svgio::svgreader::FontVariant FontVariant_notset
-svgio/inc/svgstyleattributes.hxx:105
-    enum svgio::svgreader::FontVariant FontVariant_normal
-svgio/inc/svgstyleattributes.hxx:106
-    enum svgio::svgreader::FontVariant FontVariant_small_caps
-sw/inc/poolfmt.hxx:97
+    enum (anonymous at /media/noel/disk2/libo6/libreofficekit/source/gtk/lokdocview.cxx:285:1) PROP_0
+sc/source/ui/StatisticsDialogs/RegressionDialog.cxx:105
+    enum (anonymous namespace)::ScRegType LINEAR
+sw/inc/poolfmt.hxx:96
     enum RES_POOLFMT RES_POOL_CHRFMT
-sw/inc/poolfmt.hxx:98
+sw/inc/poolfmt.hxx:97
     enum RES_POOLFMT RES_POOL_FRMFMT
-sw/inc/poolfmt.hxx:99
+sw/inc/poolfmt.hxx:98
     enum RES_POOLFMT RES_POOL_TXTCOLL
-sw/inc/poolfmt.hxx:100
+sw/inc/poolfmt.hxx:99
     enum RES_POOLFMT RES_POOL_PAGEFMT
-sw/inc/poolfmt.hxx:102
+sw/inc/poolfmt.hxx:101
     enum RES_POOLFMT RES_POOL_PARFMT
-sw/inc/poolfmt.hxx:103
+sw/inc/poolfmt.hxx:102
     enum RES_POOLFMT RES_POOL_GRFFMT
-sw/inc/poolfmt.hxx:104
+sw/inc/poolfmt.hxx:103
     enum RES_POOLFMT RES_POOLFMT_END
-sw/inc/poolfmt.hxx:210
+sw/inc/poolfmt.hxx:209
     enum RES_POOL_TABSTYLE_TYPE RES_POOLTABLESTYLE_BLACK1
-sw/inc/poolfmt.hxx:211
+sw/inc/poolfmt.hxx:210
     enum RES_POOL_TABSTYLE_TYPE RES_POOLTABLESTYLE_BLACK2
-sw/inc/poolfmt.hxx:212
+sw/inc/poolfmt.hxx:211
     enum RES_POOL_TABSTYLE_TYPE RES_POOLTABLESTYLE_BLUE
-sw/inc/poolfmt.hxx:213
+sw/inc/poolfmt.hxx:212
     enum RES_POOL_TABSTYLE_TYPE RES_POOLTABLESTYLE_BROWN
-sw/inc/poolfmt.hxx:214
+sw/inc/poolfmt.hxx:213
     enum RES_POOL_TABSTYLE_TYPE RES_POOLTABLESTYLE_CURRENCY
-sw/inc/poolfmt.hxx:215
+sw/inc/poolfmt.hxx:214
     enum RES_POOL_TABSTYLE_TYPE RES_POOLTABLESTYLE_CURRENCY_3D
-sw/inc/poolfmt.hxx:216
+sw/inc/poolfmt.hxx:215
     enum RES_POOL_TABSTYLE_TYPE RES_POOLTABLESTYLE_CURRENCY_GRAY
-sw/inc/poolfmt.hxx:217
+sw/inc/poolfmt.hxx:216
     enum RES_POOL_TABSTYLE_TYPE RES_POOLTABLESTYLE_CURRENCY_LAVENDER
-sw/inc/poolfmt.hxx:218
+sw/inc/poolfmt.hxx:217
     enum RES_POOL_TABSTYLE_TYPE RES_POOLTABLESTYLE_CURRENCY_TURQUOISE
-sw/inc/poolfmt.hxx:219
+sw/inc/poolfmt.hxx:218
     enum RES_POOL_TABSTYLE_TYPE RES_POOLTABLESTYLE_GRAY
-sw/inc/poolfmt.hxx:220
+sw/inc/poolfmt.hxx:219
     enum RES_POOL_TABSTYLE_TYPE RES_POOLTABLESTYLE_GREEN
-sw/inc/poolfmt.hxx:221
+sw/inc/poolfmt.hxx:220
     enum RES_POOL_TABSTYLE_TYPE RES_POOLTABLESTYLE_LAVENDER
-sw/inc/poolfmt.hxx:222
+sw/inc/poolfmt.hxx:221
     enum RES_POOL_TABSTYLE_TYPE RES_POOLTABLESTYLE_RED
-sw/inc/poolfmt.hxx:223
+sw/inc/poolfmt.hxx:222
     enum RES_POOL_TABSTYLE_TYPE RES_POOLTABLESTYLE_TURQUOISE
-sw/inc/poolfmt.hxx:224
+sw/inc/poolfmt.hxx:223
     enum RES_POOL_TABSTYLE_TYPE RES_POOLTABLESTYLE_YELLOW
-sw/inc/poolfmt.hxx:226
+sw/inc/poolfmt.hxx:225
     enum RES_POOL_TABSTYLE_TYPE RES_POOLTABLESTYLE_LO6_ACADEMIC
-sw/inc/poolfmt.hxx:227
+sw/inc/poolfmt.hxx:226
     enum RES_POOL_TABSTYLE_TYPE RES_POOLTABLESTYLE_LO6_BOX_LIST_BLUE
-sw/inc/poolfmt.hxx:228
+sw/inc/poolfmt.hxx:227
     enum RES_POOL_TABSTYLE_TYPE RES_POOLTABLESTYLE_LO6_BOX_LIST_GREEN
-sw/inc/poolfmt.hxx:229
+sw/inc/poolfmt.hxx:228
     enum RES_POOL_TABSTYLE_TYPE RES_POOLTABLESTYLE_LO6_BOX_LIST_RED
-sw/inc/poolfmt.hxx:230
+sw/inc/poolfmt.hxx:229
     enum RES_POOL_TABSTYLE_TYPE RES_POOLTABLESTYLE_LO6_BOX_LIST_YELLOW
-sw/inc/poolfmt.hxx:231
+sw/inc/poolfmt.hxx:230
     enum RES_POOL_TABSTYLE_TYPE RES_POOLTABLESTYLE_LO6_ELEGANT
-sw/inc/poolfmt.hxx:232
+sw/inc/poolfmt.hxx:231
     enum RES_POOL_TABSTYLE_TYPE RES_POOLTABLESTYLE_LO6_FINANCIAL
-sw/inc/poolfmt.hxx:233
+sw/inc/poolfmt.hxx:232
     enum RES_POOL_TABSTYLE_TYPE RES_POOLTABLESTYLE_LO6_SIMPLE_GRID_COLUMNS
-sw/inc/poolfmt.hxx:234
+sw/inc/poolfmt.hxx:233
     enum RES_POOL_TABSTYLE_TYPE RES_POOLTABLESTYLE_LO6_SIMPLE_GRID_ROWS
-sw/inc/poolfmt.hxx:235
+sw/inc/poolfmt.hxx:234
     enum RES_POOL_TABSTYLE_TYPE RES_POOLTABLESTYLE_LO6_SIMPLE_LIST_SHADED
-sw/source/ui/fldui/fldref.cxx:745
+sw/source/ui/fldui/fldref.cxx:756
     enum FMT_REF_IDX FMT_REF_PAGE_IDX
-sw/source/ui/fldui/fldref.cxx:746
+sw/source/ui/fldui/fldref.cxx:757
     enum FMT_REF_IDX FMT_REF_CHAPTER_IDX
-sw/source/ui/fldui/fldref.cxx:747
+sw/source/ui/fldui/fldref.cxx:758
     enum FMT_REF_IDX FMT_REF_TEXT_IDX
-sw/source/ui/fldui/fldref.cxx:748
+sw/source/ui/fldui/fldref.cxx:759
     enum FMT_REF_IDX FMT_REF_UPDOWN_IDX
-sw/source/ui/fldui/fldref.cxx:750
+sw/source/ui/fldui/fldref.cxx:761
     enum FMT_REF_IDX FMT_REF_ONLYNUMBER_IDX
-sw/source/ui/fldui/fldref.cxx:751
+sw/source/ui/fldui/fldref.cxx:762
     enum FMT_REF_IDX FMT_REF_ONLYCAPTION_IDX
-sw/source/uibase/utlui/content.cxx:803
+sw/source/uibase/utlui/content.cxx:824
     enum STR_CONTEXT_IDX IDX_STR_LINK_REGION
-sw/source/uibase/utlui/content.cxx:804
+sw/source/uibase/utlui/content.cxx:825
     enum STR_CONTEXT_IDX IDX_STR_COPY_REGION
-sw/source/uibase/utlui/content.cxx:809
+sw/source/uibase/utlui/content.cxx:830
     enum STR_CONTEXT_IDX IDX_STR_INACTIVE
-sw/source/uibase/utlui/glbltree.cxx:147
+sw/source/uibase/utlui/glbltree.cxx:146
     enum GLOBAL_CONTEXT_IDX IDX_STR_UPDATE_INDEX
-sw/source/uibase/utlui/glbltree.cxx:148
+sw/source/uibase/utlui/glbltree.cxx:147
     enum GLOBAL_CONTEXT_IDX IDX_STR_UPDATE_LINK
-sw/source/uibase/utlui/glbltree.cxx:149
+sw/source/uibase/utlui/glbltree.cxx:148
     enum GLOBAL_CONTEXT_IDX IDX_STR_UPDATE_ALL
-vcl/source/gdi/CommonSalLayout.cxx:384
+vcl/inc/salptype.hxx:44
+    enum SalPrinterError General
+vcl/inc/unx/saldisp.hxx:65
+    srv_vendor_t vendor_none
+vcl/source/gdi/CommonSalLayout.cxx:129
     enum (anonymous namespace)::VerticalOrientation Rotated
-xmloff/source/style/ImageStyle.cxx:45
+vcl/unx/gtk3/gtk3gtkinst.cxx:2524
+    enum (anonymous at /media/noel/disk2/libo6/vcl/unx/gtk3/gtk3gtkinst.cxx:2522:1) PROP_0
+vcl/unx/gtk3/gtk3gtkinst.cxx:2529
+    enum (anonymous at /media/noel/disk2/libo6/vcl/unx/gtk3/gtk3gtkinst.cxx:2522:1) PROP_SHADOW_TYPE
+writerfilter/source/ooxml/OOXMLFactory.hxx:36
+    enum writerfilter::ooxml::ResourceType NoResource
+writerfilter/source/ooxml/OOXMLFactory.hxx:37
+    enum writerfilter::ooxml::ResourceType Table
+writerfilter/source/ooxml/OOXMLFactory.hxx:38
+    enum writerfilter::ooxml::ResourceType Stream
+writerfilter/source/ooxml/OOXMLFactory.hxx:41
+    enum writerfilter::ooxml::ResourceType Properties
+writerfilter/source/ooxml/OOXMLFactory.hxx:45
+    enum writerfilter::ooxml::ResourceType Shape
+writerfilter/source/ooxml/OOXMLFactory.hxx:47
+    enum writerfilter::ooxml::ResourceType Value
+writerfilter/source/ooxml/OOXMLFactory.hxx:48
+    enum writerfilter::ooxml::ResourceType XNote
+writerfilter/source/ooxml/OOXMLFactory.hxx:49
+    enum writerfilter::ooxml::ResourceType TextTableCell
+writerfilter/source/ooxml/OOXMLFactory.hxx:50
+    enum writerfilter::ooxml::ResourceType TextTableRow
+writerfilter/source/ooxml/OOXMLFactory.hxx:51
+    enum writerfilter::ooxml::ResourceType TextTable
+writerfilter/source/ooxml/OOXMLFactory.hxx:52
+    enum writerfilter::ooxml::ResourceType PropertyTable
+writerfilter/source/ooxml/OOXMLFactory.hxx:53
+    enum writerfilter::ooxml::ResourceType Math
+writerfilter/source/ooxml/OOXMLFactory.hxx:54
+    enum writerfilter::ooxml::ResourceType Any
+xmloff/source/style/HatchStyle.cxx:49
     enum SvXMLTokenMapAttrs XML_TOK_TABSTOP_END