Add loplugin:consttobool assert-related tests

...and improve diagnostics a bit

Change-Id: I3233aa1752620ddbe6fbeff93b15565921f0bc2e
Reviewed-on: https://gerrit.libreoffice.org/82767
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

1 files changed, 5 insertions, 0 deletions

diff --git a/compilerplugins/clang/consttobool.cxx b/compilerplugins/clang/consttobool.cxx
index 8f7823aa8816..21fde3f547b1 100644
--- a/compilerplugins/clang/consttobool.cxx
+++ b/compilerplugins/clang/consttobool.cxx
@@ -207,6 +207,11 @@ public:
             suggestion = true;
             replacement = false;
         }
+        else if (res.isLValue())
+        {
+            suggestion = true;
+            replacement = true;
+        }
         else
         {
             suggestion = false;