diff options
author | Miklos Vajna <vmiklos@collabora.com> | 2025-07-07 10:52:26 +0200 |
---|---|---|
committer | Miklos Vajna <vmiklos@collabora.com> | 2025-07-07 16:41:44 +0200 |
commit | d7bf3a17cb27da1a58163e9db657f0a8d8344901 (patch) | |
tree | 4516854641508b3ea7d52d2bd461beeab94aef88 /codemaker | |
parent | 73cecab6b4d9c7feceaf9b8a337b004f7dcb4334 (diff) |
tdf#166319 sw interdependent redlines: fix redo of accept of ins-then-fmt's fmtHEADmaster
The bugdoc has <ins>AA<format>BB</format>CC</ins>, go to middle of BB,
accept, undo, redo: there is no format redline in the document, but
there should be one.
What happens is that the "accept" action creates an SwUndoAcceptRedline
with the default depth = 0, but then it carefully calls
lcl_DeleteInnerRedline() in
sw::DocumentRedlineManager::AcceptRedlineRange() instead of a plain
accept.
The undo action already knows how to only accept the underlying redline,
so fix the problem in sw::DocumentRedlineManager::AcceptRedlineRange()
by correctly recording the UI action with depth = 1, which gives us both
working undo & redo.
The exec of the undo action's redo calls
sw::DocumentRedlineManager::AcceptRedline(), which now calls the same
lcl_DeleteInnerRedline() as the original UI action, so this looks
consistent now.
Change-Id: Ibb21c0745f3dd0aacec7cf7448c7c85245dbee69
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187480
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Diffstat (limited to 'codemaker')
0 files changed, 0 insertions, 0 deletions