diff options
| author | Noel Grandin <noel@peralex.com> | 2014-06-18 12:14:29 +0200 |
|---|---|---|
| committer | Noel Grandin <noel@peralex.com> | 2014-06-24 11:34:21 +0200 |
| commit | e2080e70fe8b085f18e868e46340454720fa94ca (patch) | |
| tree | 4038d1d57b41b68a47d5ebbbe6ad390648ec6303 /chart2 | |
| parent | f910280b8704ed9c289150a4ca3c8d60e15d0d97 (diff) | |
new compilerplugin returnbyref
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }
Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
Diffstat (limited to 'chart2')
| -rw-r--r-- | chart2/source/view/charttypes/GL3DBarChart.cxx | 6 | ||||
| -rw-r--r-- | chart2/source/view/main/OpenglShapeFactory.cxx | 6 |
2 files changed, 6 insertions, 6 deletions
diff --git a/chart2/source/view/charttypes/GL3DBarChart.cxx b/chart2/source/view/charttypes/GL3DBarChart.cxx index 808bb90df0c1..f29202eeae13 100644 --- a/chart2/source/view/charttypes/GL3DBarChart.cxx +++ b/chart2/source/view/charttypes/GL3DBarChart.cxx @@ -301,10 +301,10 @@ void GL3DBarChart::render() if(!mbValidContext) return; - mrWindow.getContext()->makeCurrent(); + mrWindow.getContext().makeCurrent(); Size aSize = mrWindow.GetSizePixel(); mpRenderer->SetSize(aSize); - mrWindow.getContext()->setWinSize(aSize); + mrWindow.getContext().setWinSize(aSize); if(mbNeedsNewRender) { for(boost::ptr_vector<opengl3D::Renderable3DObject>::iterator itr = maShapes.begin(), @@ -319,7 +319,7 @@ void GL3DBarChart::render() } mpRenderer->ProcessUnrenderedShape(mbNeedsNewRender); mbNeedsNewRender = false; - mrWindow.getContext()->swapBuffers(); + mrWindow.getContext().swapBuffers(); } void GL3DBarChart::update() diff --git a/chart2/source/view/main/OpenglShapeFactory.cxx b/chart2/source/view/main/OpenglShapeFactory.cxx index a340b01df232..827b8929389c 100644 --- a/chart2/source/view/main/OpenglShapeFactory.cxx +++ b/chart2/source/view/main/OpenglShapeFactory.cxx @@ -459,15 +459,15 @@ bool OpenglShapeFactory::preRender(OpenGLWindow* pWindow) return false; pWindow->Show(); - pWindow->getContext()->makeCurrent(); + pWindow->getContext().makeCurrent(); Size aSize = pWindow->GetSizePixel(); - pWindow->getContext()->setWinSize(aSize); + pWindow->getContext().setWinSize(aSize); return true; } void OpenglShapeFactory::postRender(OpenGLWindow* pWindow) { - pWindow->getContext()->swapBuffers(); + pWindow->getContext().swapBuffers(); } void OpenglShapeFactory::clearPage(uno::Reference< drawing::XShapes > xRootShape) |