summaryrefslogtreecommitdiff
path: root/chart2
diff options
context:
space:
mode:
authorKohei Yoshida <kohei.yoshida@gmail.com>2012-09-24 16:09:10 -0400
committerKohei Yoshida <kohei.yoshida@gmail.com>2012-09-24 19:26:41 -0400
commit8baaff5c798984b0fa7fe7a764491ca27765623e (patch)
tree0292f0ef5cf1991e71f421365b29fd75d4ef53a5 /chart2
parentb174048ebd041175efd121751fddfb053d476c80 (diff)
fdo#55298: We should only treat empty values as continuation of previous ones.
For better Excel compatibility. Change-Id: I3bc44f65127d3f020894dc29e5c6549bb257f218
Diffstat (limited to 'chart2')
-rw-r--r--chart2/source/tools/ExplicitCategoriesProvider.cxx12
1 files changed, 8 insertions, 4 deletions
diff --git a/chart2/source/tools/ExplicitCategoriesProvider.cxx b/chart2/source/tools/ExplicitCategoriesProvider.cxx
index 5bb991a47513..9cc82b6f383a 100644
--- a/chart2/source/tools/ExplicitCategoriesProvider.cxx
+++ b/chart2/source/tools/ExplicitCategoriesProvider.cxx
@@ -284,7 +284,7 @@ std::vector< ComplexCategory > lcl_DataSequenceToComplexCategoryVector(
sal_Int32 nCurrentCount=0;
for( sal_Int32 nN=0; nN<nMaxCount; nN++ )
{
- OUString aCurrent = rStrings[nN];
+ const OUString& aCurrent = rStrings[nN];
if( bCreateSingleCategories || ::std::find( rLimitingBorders.begin(), rLimitingBorders.end(), nN ) != rLimitingBorders.end() )
{
aResult.push_back( ComplexCategory(aPrevious,nCurrentCount) );
@@ -293,14 +293,18 @@ std::vector< ComplexCategory > lcl_DataSequenceToComplexCategoryVector(
}
else
{
- if( !aCurrent.isEmpty() && aPrevious != aCurrent )
+ // Empty value is interpreted as a continuation of the previous
+ // category. Note that having the same value as the previous one
+ // does not equate to a continuation of the category.
+
+ if (aCurrent.isEmpty())
+ ++nCurrentCount;
+ else
{
aResult.push_back( ComplexCategory(aPrevious,nCurrentCount) );
nCurrentCount=1;
aPrevious = aCurrent;
}
- else
- nCurrentCount++;
}
}
if( nCurrentCount )