summaryrefslogtreecommitdiff
path: root/chart2/source/view/main/DrawModelWrapper.cxx
diff options
context:
space:
mode:
authorJustin Luth <justin.luth@collabora.com>2021-04-06 16:40:25 +0200
committerJustin Luth <justin_luth@sil.org>2021-04-09 11:20:35 +0200
commit28a9a92105f3155d82fd9e31095efabd3ec706ea (patch)
tree6824ff80dd25865ada4b52acca71dc2373223bb6 /chart2/source/view/main/DrawModelWrapper.cxx
parent3236020c4b8bed68dcf57210c0437f43f4160130 (diff)
tdf#139495 doc import: prevent negative Int forced into uInt
Don't cast a negative number into a sal_uInt16 and expect good results. (ww8import test) But for bug 139495 (and ww8export3), the problem area is also related to pHdFormat->SetFormatAttr(SwFormatFrameSize... which takes an awt::Size which consists of Longs. So they should accept negative numbers. Likely the result is being treated as a uInt somewhere. And a negative height doesn't mean very much anyway. There seems to be a fundamental difference between Word and LO here. Word sets the page margins, but that is irrelevant to the header/footer, which have their own distance from the edge. In LO, the header starts at the page margin, and the body text must follow the header, (In Word, the body text can start above the header, as seen in the ww8export3 unit test.) [FYI: DOC format (since forever) seems to ignore the header size, allowing the content to at least overlap with the body text, but DOCX doesn't have that. Likely this is #112727# using floating frames hack. So I'd better not keep messing around in here.] Change-Id: Ie7bffec8a3de25958cf1f311ff2c8338d4870d99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113681 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
Diffstat (limited to 'chart2/source/view/main/DrawModelWrapper.cxx')
0 files changed, 0 insertions, 0 deletions