diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2018-10-21 15:53:34 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2018-10-22 12:42:07 +0200 |
| commit | 4347b5975283ca1a591b6c3d4559ed360e187022 (patch) | |
| tree | d607931cc2143988fe344f32b8f311bcf4f3ef51 /chart2/source/model/template/StockChartTypeTemplate.cxx | |
| parent | b55fda6d9eb83460382c0da74eb5cd3a3d03cd7f (diff) | |
pvs-studio: V728 An excessive check can be simplified
for...
"The '(A && !B) || (!A && B)' expression is equivalent to the 'bool(A) != bool(B)' expression"
subcases, where the args are already bool
Change-Id: Ica8b5c4974c513f7f7ad8acf17ca931e85ebc8af
Reviewed-on: https://gerrit.libreoffice.org/62146
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'chart2/source/model/template/StockChartTypeTemplate.cxx')
| -rw-r--r-- | chart2/source/model/template/StockChartTypeTemplate.cxx | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/chart2/source/model/template/StockChartTypeTemplate.cxx b/chart2/source/model/template/StockChartTypeTemplate.cxx index 33fd369aad34..3a592071169f 100644 --- a/chart2/source/model/template/StockChartTypeTemplate.cxx +++ b/chart2/source/model/template/StockChartTypeTemplate.cxx @@ -438,11 +438,7 @@ sal_Bool SAL_CALL StockChartTypeTemplate::matchesTemplate( break; } - if( xCandleStickChartType.is() && - ( ( bHasVolume && - xVolumeChartType.is() ) || - ( ! bHasVolume && - ! xVolumeChartType.is() ))) + if (xCandleStickChartType.is() && bHasVolume == xVolumeChartType.is()) { bResult = true; |