diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-05-10 09:08:07 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-05-10 11:34:18 +0200 |
| commit | 0e384e1080381e894b590fd0a6d453568715e8fa (patch) | |
| tree | 1f91b14d4140219c6bfcaacf85d755facdc34d40 /basic | |
| parent | 6ede622ab6d2393c3ec90fcaa6e2487232b8c1a8 (diff) | |
loplugin:unnecessaryvirtual improvements
look for virtual methods where all of the overrides of the method are
empty
Change-Id: I87d99a0b647700a8d53498e0ab5f0437d3508553
Reviewed-on: https://gerrit.libreoffice.org/54060
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'basic')
| -rw-r--r-- | basic/source/comp/codegen.cxx | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/basic/source/comp/codegen.cxx b/basic/source/comp/codegen.cxx index 9e38c02a7cb9..4e13f6a83336 100644 --- a/basic/source/comp/codegen.cxx +++ b/basic/source/comp/codegen.cxx @@ -391,7 +391,6 @@ public: virtual void processOpCode1( SbiOpcode eOp, T nOp1 ) = 0; virtual void processOpCode2( SbiOpcode eOp, T nOp1, T nOp2 ) = 0; virtual bool processParams() = 0; - virtual void end() = 0; }; template <class T> PCodeVisitor< T >::~PCodeVisitor() @@ -448,7 +447,6 @@ public: visitor.processOpCode2( eOp, nOp1, nOp2 ); } } - visitor.end(); } }; @@ -465,7 +463,6 @@ public: virtual void processOpCode0( SbiOpcode /*eOp*/ ) override { ++m_nNumOp0; } virtual void processOpCode1( SbiOpcode /*eOp*/, T /*nOp1*/ ) override { ++m_nNumSingleParams; } virtual void processOpCode2( SbiOpcode /*eOp*/, T /*nOp1*/, T /*nOp2*/ ) override { ++m_nNumDoubleParams; } - virtual void end() override {} S offset() { typedef decltype(T(1) + S(1)) larger_t; // type capable to hold both value ranges of T and S @@ -526,7 +523,6 @@ public: } virtual bool processParams() override { return true; } - virtual void end() override {} // yeuch, careful here, you can only call // GetBuffer on the returned SbiBuffer once, also // you (as the caller) get to own the memory |