new loplugin: externalandnotdefined

Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.

Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2

4 files changed, 5 insertions, 8 deletions

diff --git a/basctl/source/basicide/baside2.cxx b/basctl/source/basicide/baside2.cxx
index e9f44adc8b4e..d820fe91f1f6 100644
--- a/basctl/source/basicide/baside2.cxx
+++ b/basctl/source/basicide/baside2.cxx
@@ -18,6 +18,7 @@
  */
 
 #include "baside2.hxx"
+#include "baside3.hxx"
 #include "brkdlg.hxx"
 #include "iderdll.hxx"
 #include "iderdll2.hxx"
@@ -506,8 +507,6 @@ bool ModulWindow::SaveBasicSource()
     return bDone;
 }
 
-extern bool implImportDialog( Window* pWin, const OUString& rCurPath, const ScriptDocument& rDocument, const OUString& aLibName ); // defined in baside3.cxx
-
 bool ModulWindow::ImportDialog()
 {
     const ScriptDocument& rDocument = GetDocument();
diff --git a/basctl/source/basicide/baside3.cxx b/basctl/source/basicide/baside3.cxx
index 470219c5aba6..ab106f611beb 100644
--- a/basctl/source/basicide/baside3.cxx
+++ b/basctl/source/basicide/baside3.cxx
@@ -33,6 +33,7 @@
 #include "localizationmgr.hxx"
 #include "propbrw.hxx"
 #include "objdlg.hxx"
+#include "managelang.hxx"
 
 #include <basic/basmgr.hxx>
 #include <com/sun/star/resource/StringResourceWithLocation.hpp>
@@ -863,9 +864,6 @@ bool DialogWindow::SaveDialog()
     return bDone;
 }
 
-extern bool localesAreEqual( const ::com::sun::star::lang::Locale& rLocaleLeft,
-                             const ::com::sun::star::lang::Locale& rLocaleRight );
-
 std::vector< lang::Locale > implGetLanguagesOnlyContainedInFirstSeq
     ( const Sequence< lang::Locale >& aFirstSeq, const Sequence< lang::Locale >& aSecondSeq )
 {
diff --git a/basctl/source/basicide/localizationmgr.cxx b/basctl/source/basicide/localizationmgr.cxx
index c34ac55a60a5..34d8acbcad55 100644
--- a/basctl/source/basicide/localizationmgr.cxx
+++ b/basctl/source/basicide/localizationmgr.cxx
@@ -24,6 +24,7 @@
 #include "basobj.hxx"
 #include "iderdll.hxx"
 #include "dlged.hxx"
+#include "managelang.hxx"
 
 #include <com/sun/star/resource/XStringResourceSupplier.hpp>
 #include <com/sun/star/frame/XLayoutManager.hpp>
@@ -184,9 +185,6 @@ OUString implCreatePureResourceId
     return aPureIdStr;
 }
 
-extern bool localesAreEqual( const ::com::sun::star::lang::Locale& rLocaleLeft,
-                             const ::com::sun::star::lang::Locale& rLocaleRight );
-
 // Works on xStringResourceManager's current language for SET_IDS/RESET_IDS,
 // anyway only one language should exist when calling this method then,
 // either the first one for mode SET_IDS or the last one for mode RESET_IDS
diff --git a/basctl/source/inc/baside3.hxx b/basctl/source/inc/baside3.hxx
index 3faed784013e..e5fb443c08ce 100644
--- a/basctl/source/inc/baside3.hxx
+++ b/basctl/source/inc/baside3.hxx
@@ -50,6 +50,8 @@ class DlgEdView;
 class DialogWindowLayout;
 class ObjectCatalog;
 
+bool implImportDialog( Window* pWin, const OUString& rCurPath, const ScriptDocument& rDocument, const OUString& aLibName );
+
 class DialogWindow: public BaseWindow
 {
 private: