diff options
| author | Tim Retout <tim@retout.co.uk> | 2012-02-14 22:19:46 +0000 |
|---|---|---|
| committer | Michael Meeks <michael.meeks@suse.com> | 2012-02-15 15:14:39 +0000 |
| commit | dda1f40a64506ba66772ac7b6c9d58d7775db656 (patch) | |
| tree | ebe06faf4f6d60815bcd92907317971fe8d96533 | |
| parent | 1893585d243c7daf5c8782ec6c90c26142d428e8 (diff) | |
Turn on strictures for some installer Perl modules.
| -rw-r--r-- | solenv/bin/modules/installer/copyproject.pm | 3 | ||||
| -rw-r--r-- | solenv/bin/modules/installer/exiter.pm | 3 | ||||
| -rw-r--r-- | solenv/bin/modules/installer/files.pm | 5 | ||||
| -rw-r--r-- | solenv/bin/modules/installer/logger.pm | 3 |
4 files changed, 13 insertions, 1 deletions
diff --git a/solenv/bin/modules/installer/copyproject.pm b/solenv/bin/modules/installer/copyproject.pm index 8157db4983f8..2e4f93a1677d 100644 --- a/solenv/bin/modules/installer/copyproject.pm +++ b/solenv/bin/modules/installer/copyproject.pm @@ -27,6 +27,9 @@ package installer::copyproject; +use strict; +use warnings; + use installer::control; use installer::converter; use installer::files; diff --git a/solenv/bin/modules/installer/exiter.pm b/solenv/bin/modules/installer/exiter.pm index 18b3b31481e7..243bef4c93b1 100644 --- a/solenv/bin/modules/installer/exiter.pm +++ b/solenv/bin/modules/installer/exiter.pm @@ -27,6 +27,9 @@ package installer::exiter; +use strict; +use warnings; + use installer::files; use installer::globals; use installer::logger; diff --git a/solenv/bin/modules/installer/files.pm b/solenv/bin/modules/installer/files.pm index 73ea26738b05..379144ebc916 100644 --- a/solenv/bin/modules/installer/files.pm +++ b/solenv/bin/modules/installer/files.pm @@ -27,6 +27,9 @@ package installer::files; +use strict; +use warnings; + use installer::exiter; use installer::logger; @@ -58,7 +61,7 @@ sub read_file # Don't use "my @localfile = <IN>" here, because # perl has a problem with the internal "large_and_huge_malloc" function # when calling perl using MacOS 10.5 with a perl built with MacOS 10.4 - while ( $line = <IN> ) { + while ( my $line = <IN> ) { push @localfile, $line; } diff --git a/solenv/bin/modules/installer/logger.pm b/solenv/bin/modules/installer/logger.pm index c5982c6a05f9..01303697beff 100644 --- a/solenv/bin/modules/installer/logger.pm +++ b/solenv/bin/modules/installer/logger.pm @@ -27,6 +27,9 @@ package installer::logger; +use strict; +use warnings; + use installer::files; use installer::globals; |