summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStephan Bergmann <sbergman@redhat.com>2012-06-22 11:57:12 +0200
committerCaolán McNamara <caolanm@redhat.com>2012-06-25 14:45:58 +0100
commitcf5ac1ad17bd8d2e9c8b585254302ecc053a9547 (patch)
tree3e13d159409d8ced77ae47151d7d82d86584478e
parenteaf9cbd403f375f9b69e1c7ed8503d3bc23bcc6e (diff)
fdo#50682: Setting DYLD_LIBRARY_PATH in python script appears unnecessary
...and apparently has negative consequences (system CFNetwork framework picking up LO libsqlite3.dylib instead of system one, as DYLD_LIBRARY_PATH overrides recorded installnames). Contrary to the old comment ("so that 'import pyuno' finds libpyuno.so"), what setting LD_LIBRARY_PATH on Linux is still necessary for is so that python.bin (a stripped version of the python executable from external python module) finds libpython2.6.so, as it lacks an RPATH. ('import pyuno' finds pyuno.so apparently on PYTHONPATH, anyway, and pyuno.so in turn dlopen's libpython.{dylib,so} with full path.) (This might make dc82cf021f76ea83ff7a4bcb2d7525f2e111f0cc "Make PyUNO work --with-macox-version-min-required=10.6" irrelevant.) Change-Id: I1c3a6c61d4cc976d85956e587497a13a77689128 (cherry picked from commit a164d246f2ed941fbdef19ec5b47dac1bab25509) Signed-off-by: Caolán McNamara <caolanm@redhat.com>
-rw-r--r--pyuno/zipcore/python.sh9
1 files changed, 5 insertions, 4 deletions
diff --git a/pyuno/zipcore/python.sh b/pyuno/zipcore/python.sh
index 22edea89108f..6626e3e07681 100644
--- a/pyuno/zipcore/python.sh
+++ b/pyuno/zipcore/python.sh
@@ -43,10 +43,6 @@ cd "$sd_cwd"
PATH=$sd_prog${PATH+:$PATH}
export PATH
-# Set %%OOO_LIBRARY_PATH_VAR%% so that "import pyuno" finds libpyuno.so:
-%%OOO_LIBRARY_PATH_VAR%%=$sd_prog:$sd_prog/../ure-link/lib${%%OOO_LIBRARY_PATH_VAR%%:+:$%%OOO_LIBRARY_PATH_VAR%%}
-export %%OOO_LIBRARY_PATH_VAR%%
-
# Set UNO_PATH so that "officehelper.bootstrap()" can find soffice executable:
: ${UNO_PATH=$sd_prog}
export UNO_PATH
@@ -57,6 +53,11 @@ export UNO_PATH
export URE_BOOTSTRAP
NONMACSECTION
+# Set %%OOO_LIBRARY_PATH_VAR%% so that python.bin finds libpython2.6.so (this
+# can go once python.bin contains a proper RPATH):
+%%OOO_LIBRARY_PATH_VAR%%=$sd_prog${%%OOO_LIBRARY_PATH_VAR%%:+:$%%OOO_LIBRARY_PATH_VAR%%}
+export %%OOO_LIBRARY_PATH_VAR%%
+
PYTHONPATH=$sd_prog:$sd_prog/python-core-%%PYVERSION%%/lib:$sd_prog/python-core-%%PYVERSION%%/lib/lib-dynload:$sd_prog/python-core-%%PYVERSION%%/lib/lib-tk:$sd_prog/python-core-%%PYVERSION%%/lib/site-packages${PYTHONPATH+:$PYTHONPATH}
export PYTHONPATH
PYTHONHOME=$sd_prog/python-core-%%PYVERSION%%