tdf#88360: sw: fix crash on closing help in Navigator window

SwContentTree::pActiveShell is not cleared because of a check that the
shell exists, which is only done in the special case bIsConstant.

* at most one of bIsActive or bIsConstant is true
* the only place that calls SetActiveShell() if bIsConstant is true
  already checks this condition

So remove the unnecessary check from SetActiveShell()

Change-Id: Id3b3b98bd38303b5afc529cc8be669872bd354b7

1 files changed, 6 insertions, 9 deletions

diff --git a/sw/source/uibase/utlui/content.cxx b/sw/source/uibase/utlui/content.cxx
index 7e82523886a5..b2a8e34b02c4 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -2220,15 +2220,12 @@ void SwContentTree::SetActiveShell(SwWrtShell* pSh)
     }
     else if(bIsConstant)
     {
-        if(!lcl_FindShell(pActiveShell))
-        {
-            if (pActiveShell)
-                EndListening(*pActiveShell->GetView().GetDocShell());
-            pActiveShell = pSh;
-            bIsActive = true;
-            bIsConstant = false;
-            bClear = true;
-        }
+        if (pActiveShell)
+            EndListening(*pActiveShell->GetView().GetDocShell());
+        pActiveShell = pSh;
+        bIsActive = true;
+        bIsConstant = false;
+        bClear = true;
     }
     // Only if it is the active view, the array will be deleted and
     // the screen filled new.