diff options
authorMichael Stahl <>2020-04-07 18:33:34 +0200
committerMichael Stahl <>2020-04-08 10:57:52 +0200
commit6c7245e789f973cf6dad03f7008ab3f9d12d350c (patch)
parent969ebe1c5801fa194ee29ffc7abfad7363ebd08f (diff)
tdf#131684 sw_redlinehide: fix SwUndoDelete for entire doc in section
The problem is that in SwUndoDelete::UndoImpl(), at the start there is only one content node with a frame in the layout, and there is a special case with m_nReplaceDummy being set so this SwTextFrame gets deleted by the MoveNodes() call in line 969 that moves it into the newly inserted section. As a result of that, MakeFrames() won't do anything because it can't find an existing frame in the same section. In this case, MoveNodes() should leave the frame alone, as it is beyond the end of the deletion and excluded from MakeFrames() - if it wasn't merged before then it doesn't need action, if it was merged before (in a different document maybe) the RecreateStartTextFrames() ought to fix it. (regression from 723728cd358693b8f4bc9d913541aa4479f2bd48 which disabled immediate creation of frames in Copy_()) Change-Id: Iabe2fb1810b0df898b1f57b3d850c3503c79c5d0 Reviewed-on: Tested-by: Jenkins Reviewed-by: Michael Stahl <>
1 files changed, 2 insertions, 1 deletions
diff --git a/sw/source/core/undo/undel.cxx b/sw/source/core/undo/undel.cxx
index ba1d9210359d..6b4b4b3786de 100644
--- a/sw/source/core/undo/undel.cxx
+++ b/sw/source/core/undo/undel.cxx
@@ -965,7 +965,8 @@ void SwUndoDelete::UndoImpl(::sw::UndoRedoContext & rContext)
SwNodeIndex aMvIdx(rDoc.GetNodes(), nMoveIndex);
SwNodeRange aRg( aPos.nNode, 0, aPos.nNode, 1 );
pMovedNode = &aPos.nNode.GetNode();
- rDoc.GetNodes().MoveNodes(aRg, rDoc.GetNodes(), aMvIdx);
+ // tdf#131684 without deleting frames
+ rDoc.GetNodes().MoveNodes(aRg, rDoc.GetNodes(), aMvIdx, false);
rDoc.GetNodes().Delete( aMvIdx);