summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Stahl <mstahl@redhat.com>2018-01-17 11:11:01 +0100
committerMichael Stahl <mstahl@redhat.com>2018-01-17 11:11:49 +0100
commit665ffc01e124029dc1412cc31e67878f697902ac (patch)
tree34eb0c700770ba5ef69ba952d68a1ee232f4ee1d
parent3f84927c1cdadffe1eebb9cd6843587245588b91 (diff)
tdf#114939 sal: document the bug in endSHA()
Change-Id: I58df3705c1e07737747b6f8e3ce91d5278018cbb
-rw-r--r--sal/rtl/digest.cxx2
1 files changed, 2 insertions, 0 deletions
diff --git a/sal/rtl/digest.cxx b/sal/rtl/digest.cxx
index e3db60461d5e..fbacbc9838dd 100644
--- a/sal/rtl/digest.cxx
+++ b/sal/rtl/digest.cxx
@@ -1047,6 +1047,8 @@ static void endSHA(DigestContextSHA *ctx)
i += 1;
+ // tdf#114939 NB: this is WRONG and should be ">" not ">=" but is not
+ // fixed as this buggy SHA1 implementation is needed for compatibility
if (i >= (DIGEST_LBLOCK_SHA - 2))
{
for (; i < DIGEST_LBLOCK_SHA; i++)