diff options
| author | Xisco Fauli <xiscofauli@libreoffice.org> | 2021-01-29 12:42:09 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2021-01-29 21:10:09 +0100 |
| commit | 3e1a46699e3b0868e2748f28e244b4d7de4fe775 (patch) | |
| tree | a6fc9c95bf418cd2cc21389e9d15c39d0b98d110 | |
| parent | 249695375316ab9c8a66e811482721d9699aff2a (diff) | |
tdf#139996: do not crash if no slide is selected
when no slide is selected, SyncPageSelectionToDocument(xSelection).first
returns SAL_MAX_UINT16, which is greater than 0
Change-Id: I20225dc3c89a34358949f991d1548e11803c3131
Change-Id: I787d46ff97a6a1401c5bc4ffc136aefc4bbeea29
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110154
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
| -rw-r--r-- | sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx b/sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx index 05a571592ce3..25f3acafa9f0 100644 --- a/sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx +++ b/sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx @@ -797,6 +797,11 @@ void SlideSorterViewShell::ExecMovePageUp (SfxRequest& /*rReq*/) // SdDrawDocument MovePages is based on SdPage IsSelected, so // transfer the SlideSorter selection to SdPages sal_uInt16 firstSelectedPageNo = SyncPageSelectionToDocument(xSelection).first; + + // In case no slide is selected + if (firstSelectedPageNo == SAL_MAX_UINT16) + return; + // Now compute human page number from internal page number firstSelectedPageNo = (firstSelectedPageNo - 1) / 2; |