diff options
author | Jorge Zapata <jorgeluis.zapata@gmail.com> | 2024-01-19 21:52:42 +0100 |
---|---|---|
committer | Jorge Zapata <jorgeluis.zapata@gmail.com> | 2024-03-12 10:03:58 +0100 |
commit | 8fc6521932b7731e5eb4748b45a46b5290d4b604 (patch) | |
tree | 4b0434918034f2f50aa7a709b93f9f8cc42b2724 | |
parent | d44802aec495f24f3f92252a7453ad6a6a64f898 (diff) |
Add future FIXMEs
Part-of: <https://gitlab.freedesktop.org/gstreamer/orc/-/merge_requests/148>
-rw-r--r-- | orc/orcprogram.c | 1 | ||||
-rw-r--r-- | orc/orctarget.h | 8 |
2 files changed, 7 insertions, 2 deletions
diff --git a/orc/orcprogram.c b/orc/orcprogram.c index b414e8f..0e577db 100644 --- a/orc/orcprogram.c +++ b/orc/orcprogram.c @@ -738,6 +738,7 @@ void orc_program_set_var_alignment (OrcProgram *program, int var, int alignment) { program->vars[var].alignment = alignment; + /* FIXME: this is not correct */ if (program->vars[var].alignment >= 16) { program->vars[var].is_aligned = TRUE; } diff --git a/orc/orctarget.h b/orc/orctarget.h index 0b0f43d..2e2860c 100644 --- a/orc/orctarget.h +++ b/orc/orctarget.h @@ -87,10 +87,14 @@ struct _OrcTarget { void (*load_constant)(OrcCompiler *compiler, int reg, int size, int value); const char * (*get_flag_name)(int shift); void (*flush_cache) (OrcCode *code); + /* FIXME or you either support the size, or provide a better function to also + * handle 64 bits constants, but there is no need to add another API for + * one specific case. Use a _full passing also the size. + */ void (*load_constant_long)(OrcCompiler *compiler, int reg, OrcConstant *constant); - - void *_unused[5]; + void *target_data; + void *_unused[4]; }; |