summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTim-Philipp Müller <tim@centricular.net>2006-12-14 15:45:56 +0000
committerTim-Philipp Müller <tim@centricular.net>2006-12-14 15:45:56 +0000
commitbc2cdd57d549ab3ba59782e9b395d0cd683fd3ac (patch)
tree5e031a1ee99d192ff1b063de7bc29dad1f00d6eb
parent22f148e7b8b9f18779154ad666f715aac2b34d97 (diff)
gst/modplug/libmodplug/sndfile.cpp: Fix potential buffer overflow (CVE-2006-4192) (#385788).
Original commit message from CVS: * gst/modplug/libmodplug/sndfile.cpp: Fix potential buffer overflow (CVE-2006-4192) (#385788).
-rw-r--r--ChangeLog5
-rw-r--r--gst/modplug/libmodplug/sndfile.cpp2
2 files changed, 6 insertions, 1 deletions
diff --git a/ChangeLog b/ChangeLog
index 68dcd4fae..10367842f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2006-12-14 Tim-Philipp Müller <tim at centricular dot net>
+
+ * gst/modplug/libmodplug/sndfile.cpp:
+ Fix potential buffer overflow (CVE-2006-4192) (#385788).
+
2006-12-13 Wim Taymans <wim@fluendo.com>
* gst/qtdemux/qtdemux.c: (gst_qtdemux_get_duration),
diff --git a/gst/modplug/libmodplug/sndfile.cpp b/gst/modplug/libmodplug/sndfile.cpp
index 5dc141795..23eeac7e3 100644
--- a/gst/modplug/libmodplug/sndfile.cpp
+++ b/gst/modplug/libmodplug/sndfile.cpp
@@ -1081,7 +1081,7 @@ UINT CSoundFile::ReadSample(MODINSTRUMENT *pIns, UINT nFlags, LPCSTR lpMemFile,
{
UINT len = 0, mem = pIns->nLength+6;
- if ((!pIns) || (pIns->nLength < 4) || (!lpMemFile)) return 0;
+ if ((!pIns) || ((int)pIns->nLength < 4) || (!lpMemFile)) return 0;
if (pIns->nLength > MAX_SAMPLE_LENGTH) pIns->nLength = MAX_SAMPLE_LENGTH;
pIns->uFlags &= ~(CHN_16BIT|CHN_STEREO);
if (nFlags & RSF_16BIT)