DBus server: abort when user didn't provide password (MB#10475)mb10475

When user didn't provide password, sync ui sends a hash without
'password' key-value pair in the response. Abort the current sync
process under this situation.

1 files changed, 6 insertions, 1 deletions

diff --git a/src/syncevo-dbus-server.cpp b/src/syncevo-dbus-server.cpp
index 5db2cc1a..335796e4 100644
--- a/src/syncevo-dbus-server.cpp
+++ b/src/syncevo-dbus-server.cpp
@@ -3470,7 +3470,12 @@ string Session::askPassword(const string &passwordName,
     boost::shared_ptr<InfoReq> req = m_server.createInfoReq("password", params, this);
     std::map<string, string> response;
     if(req->wait(response) == InfoReq::ST_OK) {
-        return response["password"];
+        std::map<string, string>::iterator it = response.find("password");
+        if (it == response.end()) {
+            SE_THROW_EXCEPTION_STATUS(StatusException, "user didn't provide password, abort", SyncMLStatus(sysync::LOCERR_USERABORT));
+        } else {
+            return it->second;
+        }
     } 
 
     SE_THROW_EXCEPTION_STATUS(StatusException, "can't get the password from clients. The password request is '" + req->getStatusStr() + "'", STATUS_PASSWORD_TIMEOUT);