diff options
author | Thomas Haller <thaller@redhat.com> | 2020-02-14 10:50:25 +0100 |
---|---|---|
committer | Thomas Haller <thaller@redhat.com> | 2020-02-14 11:04:46 +0100 |
commit | de62da297e506b1c5ad9b7dcc9132c681d089efe (patch) | |
tree | 7fb2357eb790bfeed23ef653955e76f5ca85e95e /src/devices/nm-device-infiniband.c | |
parent | d165787b54eb0d3577fe20be174c9e67901ed53a (diff) |
all: drop explicit casts from _GET_PRIVATE() macro calls
The _GET_PRIVATE() macros are all implemented based on
_NM_GET_PRIVATE(). That macro tries to be more type safe and uses
_Generic() to do the right thing. Explicitly casting is not only
unnecessary, it defeats these (static) type checks.
Don't do that.
Diffstat (limited to 'src/devices/nm-device-infiniband.c')
-rw-r--r-- | src/devices/nm-device-infiniband.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/devices/nm-device-infiniband.c b/src/devices/nm-device-infiniband.c index 9f79d9bbf6..0ef74d252c 100644 --- a/src/devices/nm-device-infiniband.c +++ b/src/devices/nm-device-infiniband.c @@ -43,7 +43,7 @@ struct _NMDeviceInfinibandClass { G_DEFINE_TYPE (NMDeviceInfiniband, nm_device_infiniband, NM_TYPE_DEVICE) -#define NM_DEVICE_INFINIBAND_GET_PRIVATE(self) _NM_GET_PRIVATE (self, NMDeviceInfiniband, NM_IS_DEVICE_INFINIBAND) +#define NM_DEVICE_INFINIBAND_GET_PRIVATE(self) _NM_GET_PRIVATE (self, NMDeviceInfiniband, NM_IS_DEVICE_INFINIBAND, NMDevice) /*****************************************************************************/ @@ -52,7 +52,7 @@ get_generic_capabilities (NMDevice *device) { guint32 caps = NM_DEVICE_CAP_CARRIER_DETECT; - if (NM_DEVICE_INFINIBAND_GET_PRIVATE ((NMDeviceInfiniband *) device)->is_partition) + if (NM_DEVICE_INFINIBAND_GET_PRIVATE (device)->is_partition) caps |= NM_DEVICE_CAP_IS_SOFTWARE; return caps; @@ -223,7 +223,7 @@ create_and_realize (NMDevice *device, const NMPlatformLink **out_plink, GError **error) { - NMDeviceInfinibandPrivate *priv = NM_DEVICE_INFINIBAND_GET_PRIVATE ((NMDeviceInfiniband *) device); + NMDeviceInfinibandPrivate *priv = NM_DEVICE_INFINIBAND_GET_PRIVATE (device); NMSettingInfiniband *s_infiniband; int r; @@ -281,7 +281,7 @@ unrealize (NMDevice *device, GError **error) g_return_val_if_fail (NM_IS_DEVICE_INFINIBAND (device), FALSE); - priv = NM_DEVICE_INFINIBAND_GET_PRIVATE ((NMDeviceInfiniband *) device); + priv = NM_DEVICE_INFINIBAND_GET_PRIVATE (device); if (priv->p_key < 0) { g_set_error (error, NM_DEVICE_ERROR, NM_DEVICE_ERROR_FAILED, @@ -309,7 +309,7 @@ get_property (GObject *object, guint prop_id, { switch (prop_id) { case PROP_IS_PARTITION: - g_value_set_boolean (value, NM_DEVICE_INFINIBAND_GET_PRIVATE ((NMDeviceInfiniband *) object)->is_partition); + g_value_set_boolean (value, NM_DEVICE_INFINIBAND_GET_PRIVATE (object)->is_partition); break; default: G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec); @@ -323,7 +323,7 @@ set_property (GObject *object, guint prop_id, { switch (prop_id) { case PROP_IS_PARTITION: - NM_DEVICE_INFINIBAND_GET_PRIVATE ((NMDeviceInfiniband *) object)->is_partition = g_value_get_boolean (value); + NM_DEVICE_INFINIBAND_GET_PRIVATE (object)->is_partition = g_value_get_boolean (value); break; default: G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec); |