diff options
| author | Aleksander Morgado <aleksander@aleksander.es> | 2020-10-14 14:24:35 +0200 |
|---|---|---|
| committer | Aleksander Morgado <aleksander@aleksander.es> | 2020-10-14 14:24:35 +0200 |
| commit | 781cc706cad1fae080ad952b2a357e480fe04da8 (patch) | |
| tree | 09e9176bdc5eccdeadd1061f5c6ed7222cb8390d | |
| parent | 327f509f04224c105ab2227317270ce6b998d9ed (diff) | |
broadband-modem-qmi: ensure GError is initialized to NULL
(ModemManager:21568): GLib-WARNING **: 22:11:27.828: GError set over the top of a previous GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an error is NULL before it's set.
The overwriting error message was: QMI protocol error (94): 'NotSupported'
[21568]: <warn> [1582841487.829678] [modem0] couldn't load facility locks: (NULL)
[21568]: <debug> [1582841487.830746] [modem0] loading UE mode of operation for EPS...
[21568]: <debug> [1582841487.832138] [modem0/ttyUSB2/at] device open count is 2 (open)
Segmentation fault
This issue is only applicable in the mm-1-14 branch.
Fixes cd686f10e049cf0494678f4d87e17e62e8f53e76.
| -rw-r--r-- | src/mm-broadband-modem-qmi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mm-broadband-modem-qmi.c b/src/mm-broadband-modem-qmi.c index 03edd66d..ccf85a94 100644 --- a/src/mm-broadband-modem-qmi.c +++ b/src/mm-broadband-modem-qmi.c @@ -2172,7 +2172,7 @@ get_sim_lock_status_via_pin_status_ready (QmiClientDms *client, LoadEnabledFacilityLocksContext *ctx; QmiMessageDmsUimGetPinStatusOutput *output; QmiDmsUimPinStatus current_status; - GError *error; + GError *error = NULL; gboolean pin1_enabled; gboolean pin2_enabled; |