summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAdam Jackson <ajax@redhat.com>2008-06-24 13:16:53 -0400
committerAdam Jackson <ajax@redhat.com>2008-06-24 13:16:53 -0400
commitf6af6dd2f76c12b56ec166bb771457b9f08fe246 (patch)
treef6e96975c3fbadf1d46f236e51682abbf7ecc522
parent21e464ec682ab23ba20ddf6bd72c6db214cfbe01 (diff)
Bug #14898: Don't abuse the sprintf() implementation.
The thing you're printing into should not itself appear in the list of things to print from, that's bad juju. Just use strcat().
-rw-r--r--modules/om/generic/omGeneric.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/modules/om/generic/omGeneric.c b/modules/om/generic/omGeneric.c
index f036252f..7d1cf30f 100644
--- a/modules/om/generic/omGeneric.c
+++ b/modules/om/generic/omGeneric.c
@@ -615,7 +615,8 @@ get_rotate_fontname(
for(field_num = 0 ; field_num < CHARSET_ENCODING_FIELD &&
fields[field_num] ; field_num++) {
- sprintf(rotate_font_ptr, "%s-%s", rotate_font_ptr, fields[field_num]);
+ strcat(rotate_font_ptr, "-");
+ strcat(rotate_font_ptr, fields[field_num]);
}
if(pattern)