summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChris Wilson <chris@chris-wilson.co.uk>2012-01-10 10:38:43 +0000
committerChris Wilson <chris@chris-wilson.co.uk>2012-01-10 17:08:16 +0000
commit8dd913fd3a093b54fc024fea2b31a3db2518db8d (patch)
treeae82747a6478f60a5a262d087b5d3362604e2786
parent21948578d0d87f38447ef1ae44fada406949bca8 (diff)
sna: Add reminder about possible future tiling optimisations
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
-rw-r--r--src/sna/sna_accel.c11
1 files changed, 8 insertions, 3 deletions
diff --git a/src/sna/sna_accel.c b/src/sna/sna_accel.c
index e7ac2151..6200dd32 100644
--- a/src/sna/sna_accel.c
+++ b/src/sna/sna_accel.c
@@ -1079,8 +1079,8 @@ sna_drawable_move_region_to_cpu(DrawablePtr drawable,
region->extents.y2 - region->extents.y1));
if ((flags & MOVE_WRITE) == 0 &&
- region->extents.x2 - region->extents.x1 == 1 &&
- region->extents.y2 - region->extents.y1 == 1) {
+ region->extents.x2 - region->extents.x1 == 1 &&
+ region->extents.y2 - region->extents.y1 == 1) {
/* Often associated with synchronisation, KISS */
sna_read_boxes(sna,
priv->gpu_bo, 0, 0,
@@ -6753,12 +6753,17 @@ sna_poly_fill_rect_tiled_blt(DrawablePtr drawable,
tile_width = tile->drawable.width;
tile_height = tile->drawable.height;
- if (tile_width == 1 && tile_height == 1)
+ if ((tile_width | tile_height) == 1)
return sna_poly_fill_rect_blt(drawable, bo, damage,
gc, get_pixel(tile),
n, rect,
extents, clipped);
+ /* XXX [248]x[238] tiling can be reduced to a pattern fill.
+ * Also we can do the lg2 reduction for BLT and use repeat modes for
+ * RENDER.
+ */
+
if (!sna_pixmap_move_to_gpu(tile, MOVE_READ))
return FALSE;