diff options
| author | David Zeuthen <zeuthen@gmail.com> | 2013-01-08 14:08:48 -0500 |
|---|---|---|
| committer | David Zeuthen <zeuthen@gmail.com> | 2013-01-08 14:08:48 -0500 |
| commit | 0db2a95450784555d4c9991cc965111297412f84 (patch) | |
| tree | e23789c9e8310ca34a825aa38eff51703b78a70c | |
| parent | 5c948990803cbd47a534f3c29df4f2ea644c5437 (diff) | |
Don't leak UDisksLinuxDevice when handling uevent
This is a pretty big leak as it involves the struct udev_device
instance for the event. FWIW, it's pretty easy to trigger this with
developer-setups with lots of uevents - on the upside, this mostly
only happens on developer setups so there's that.
This memory leak was reported in
https://bugzilla.redhat.com/show_bug.cgi?id=892980
and it was reported as being "huge" and "insane" (!).
Signed-off-by: David Zeuthen <zeuthen@gmail.com>
| -rw-r--r-- | src/udiskslinuxprovider.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/udiskslinuxprovider.c b/src/udiskslinuxprovider.c index 9600d04..677a193 100644 --- a/src/udiskslinuxprovider.c +++ b/src/udiskslinuxprovider.c @@ -202,7 +202,6 @@ on_idle_with_probed_uevent (gpointer user_data) udisks_linux_provider_handle_uevent (request->provider, g_udev_device_get_action (request->udev_device), request->udisks_device); - request->udisks_device = NULL; /* adopted */ probe_request_free (request); return FALSE; /* remove source */ } |