summaryrefslogtreecommitdiff
authorColin Walters <walters@verbum.org>2013-06-11 19:21:13 (GMT)
committer Hans de Goede <hdegoede@redhat.com>2013-08-02 09:45:36 (GMT)
commit99a2628b0ff04e0aadd130e45aa2598c4df64690 (patch) (side-by-side diff)
tree0c6261a86d41f8f6d022029e5fdbfaedded3bc32
parentec872de2a1866106c595e1725ce60fe91229872a (diff)
downloadvd_agent-99a2628b0ff04e0aadd130e45aa2598c4df64690.zip
vd_agent-99a2628b0ff04e0aadd130e45aa2598c4df64690.tar.gz
Not having the virtio channel is not an error; instead silently do nothing
Fedora for example bundles the SPICE agent by default; however, we don't want to spew an error when running non-virtualized, or with plain VNC. Let's just silently exit; while we could change LOG_ERR -> LOG_INFO or something, that's still pointless noise in most people's syslog. Someone who was debugging a misconfigured SPICE setup would pretty quickly notice that they were missing the virtio port. (This patch is part of a larger initiative to reduce error spew on default startup in common deployment scenarios such as KVM+VNC.) Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (more/less context) (ignore whitespace changes)
-rw-r--r--src/vdagent.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/src/vdagent.c b/src/vdagent.c
index 9e238d3..10ebf6e 100644
--- a/src/vdagent.c
+++ b/src/vdagent.c
@@ -226,9 +226,7 @@ int main(int argc, char *argv[])
LOG_USER);
if (file_test(portdev) != 0) {
- syslog(LOG_ERR, "Missing virtio device '%s': %s",
- portdev, strerror(errno));
- return 1;
+ return 0;
}
if (do_daemonize)