diff options
author | Oliver Sander <oliver.sander@tu-dresden.de> | 2020-02-14 23:37:35 +0100 |
---|---|---|
committer | Oliver Sander <oliver.sander@tu-dresden.de> | 2020-02-15 08:57:20 +0100 |
commit | ef5a9f53959d71be273fb9ee0956f516f6d3d39c (patch) | |
tree | 3d2bd8e819dd5001779460c04a11e4052fadd59d /cpp | |
parent | 5539aeba90d8e5b2ea78444495deaefc900d299c (diff) |
Use std::unique_ptr to pass around LinkDest objects
This provides no functional changes, but it makes the pointer
ownership easier to understand.
Diffstat (limited to 'cpp')
-rw-r--r-- | cpp/poppler-document.cpp | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/cpp/poppler-document.cpp b/cpp/poppler-document.cpp index 9c7dc03b..1a0d9e6f 100644 --- a/cpp/poppler-document.cpp +++ b/cpp/poppler-document.cpp @@ -1010,14 +1010,12 @@ std::map<std::string, destination> document::create_destination_map() const const int nDests = catalog->numDests(); for (int i = 0; i < nDests; ++i ) { std::string key(catalog->getDestsName (i)); - LinkDest *link_dest = catalog->getDestsDest (i); + std::unique_ptr<LinkDest> link_dest = catalog->getDestsDest (i); if (link_dest) { - destination dest(new destination_private(link_dest, d->doc)); + destination dest(new destination_private(link_dest.get(), d->doc)); m.emplace(std::move(key), std::move(dest)); - - delete link_dest; } } @@ -1026,14 +1024,12 @@ std::map<std::string, destination> document::create_destination_map() const for (int i = 0; i < nDestsNameTree; ++i ) { std::string key(catalog->getDestNameTreeName (i)->c_str (), catalog->getDestNameTreeName (i)->getLength ()); - LinkDest *link_dest = catalog->getDestNameTreeDest (i); + std::unique_ptr<LinkDest> link_dest = catalog->getDestNameTreeDest (i); if (link_dest) { - destination dest(new destination_private(link_dest, d->doc)); + destination dest(new destination_private(link_dest.get(), d->doc)); m.emplace(std::move(key), std::move(dest)); - - delete link_dest; } } |