Age | Commit message (Collapse) | Author | Files | Lines |
|
plymouth calls `grantpt()` when setting up the pseudoterminal it uses
for boot logging and console broadcasting. `grantpt()` traditionally
sets up the access permissions and file mode of the created slave
pseudoterminal device node.
That call is unnecessary for two reasons:
1. The kernel automatically sets up the correct permissions at open
time on modern Linux.
2. plymouthd runs as root anyway
Furthermore, it seems like, for some unknown reason, the call may be
interfering with the shutdown process.
This commit drops the call, since it's unnecessary, and potentially
even problematic.
|
|
ply_terminal_session_open_console, Since this is a feature from a bygone
time which is no longer in use without ply_terminal_session_run.
|
|
a bygone time which is no longer in use
|
|
We want to append to it now.
|
|
This reverts commit fc5cd88767db61805519fef53182386ba56c6405.
It's better to let the admin of the system decide the permissions,
than forcefully change them.
|
|
I don't like the GNU coding style and I'm not sure why I chose it.
This commit changes things over to use 8 space tabs and 'if () {'
style braces.
|
|
They're fairly bitrotten, don't tie into make check,
and aren't that useful.
Drop them for now, until we can come up with a better
story.
|
|
This prevents a scary close(-1) in straces.
|
|
When we stop redirecting console messages, we temporarly open
/dev/console. We don't ever close it.
This commit fixes that.
|
|
|
|
Currently, we give up on boot logging after a tty disconnect.
This commit makes the terminal session reattach to the tty, and
continue logging.
|
|
In truth, we can get hangups at any time during boot. It doesn't
mean the session is done, so use better terminology.
|
|
It was a really lame small wrapper around creating pseudoterminals.
The wrapper didn't buy anything and the name ply-terminal would be
better used for managing tty settings, etc.
|
|
Otherwise we hit an assert next time we attach
|
|
This is coming from the drop-nash branch. It lets
the caller of plymouth not have to create a pty master.
|
|
Revert accidental commit from:
6b9011d164201951af27f65163519b194d301572
|
|
It was causing some problems on hide-splash before
that should be better now.
|
|
This reverts commit 65aae81e942f63f075e08910f2e8fb0a2b2c3230.
|
|
Previously, we did it manually using the ioctl
straight from main.c. Now, there's a
ply_terminal_session_detach call that does it
for us. This allows us to detach from the terminal
during --hide-splash, and reattach during --show-splash
|
|
It seems like there may be cases where it's better
to not do the whole TIOCCONS song and dance. This
provides an escape hatch.
|
|
We store a link to the boot log in /var/spool/plymouth so that
the viewer can detect if boot up failed. It will do this by
checking if /var/log/boot.log and /var/spool/plymouth/boot.log
are the same file
|
|
Before we were only making it readable by root, but
that doesn't make sense. It's not secret information
or anything.
|
|
|
|
Make ply_terminal_session_new() not require argv.
|
|
Drop set_output_buffer api and propagate boot output to splash plugins
|
|
|
|
This is because we still need access to /dev/pts/1 until
right before exec
|
|
|
|
|