summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRuss Allbery <rra@debian.org>2016-09-22 23:44:02 +0200
committerDan Nicholson <dbn.lists@gmail.com>2017-03-19 09:56:25 -0500
commit3b96e7434c6d3b86443782efde053fb2ae2f7fba (patch)
tree282450fd850898a2feb0a625b23bb9e2a13c011a
parentc424a4cf3765936ef623755dd6134187c99d37cd (diff)
Make PKG_CHECK_MODULES report the module name instead of the variable prefix
In Autoconf output from PKG_CHECK_MODULES in pkg.m4, the "checking for" message refers to the first argument of PKG_CHECK_MODULES, the variable prefix, instead of the second argument, the module being checked for. This results in strange output (like ALL CAPS module names) in various packages. And when probing for modules, one can't always use a variable prefix that matches the module name (since ‘-’ and other characters aren't allowed in variable names), so the Autoconf output is going to refer to something odd. The status output should reference the module name being probed for, both because it looks nicer and because, when debugging problems, this references the actual thing being probed for on the system, rather than an internal implementation detail. Signed-off-by: Guillem Jover <guillem@hadrons.org> https://bugs.freedesktop.org/show_bug.cgi?id=98334
-rw-r--r--pkg.m4.in2
1 files changed, 1 insertions, 1 deletions
diff --git a/pkg.m4.in b/pkg.m4.in
index eb44361..2b341dd 100644
--- a/pkg.m4.in
+++ b/pkg.m4.in
@@ -142,7 +142,7 @@ AC_ARG_VAR([$1][_CFLAGS], [C compiler flags for $1, overriding pkg-config])dnl
AC_ARG_VAR([$1][_LIBS], [linker flags for $1, overriding pkg-config])dnl
pkg_failed=no
-AC_MSG_CHECKING([for $1])
+AC_MSG_CHECKING([for $2])
_PKG_CONFIG([$1][_CFLAGS], [cflags], [$2])
_PKG_CONFIG([$1][_LIBS], [libs], [$2])