blob: 1a46fdd3dee8db44673c77bb84c8507c41c5898b (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include <set>
#include "check.hxx"
#include "plugin.hxx"
/** Look for static OUString and OUString[], they can be more efficiently declared as:
static const OUStringLiteral our_aLBEntryMap[] = {" ", ", "};
static const OUStringLiteral sName("name");
which is more efficient at startup time.
*/
namespace {
class StringStatic
: public loplugin::FilteringPlugin<StringStatic>
{
public:
explicit StringStatic(loplugin::InstantiationData const& rData):
FilteringPlugin(rData) {}
void run() override;
bool VisitVarDecl(VarDecl const*);
bool VisitReturnStmt(ReturnStmt const*);
private:
std::set<VarDecl const *> potentialVars;
std::set<VarDecl const *> excludeVars;
};
void StringStatic::run()
{
StringRef fn(handler.getMainFileName());
// passing around pointers to global OUString
if (loplugin::hasPathnamePrefix(fn, SRCDIR "/filter/source/svg/"))
return;
// has a mix of literals and refs to external OUStrings
if (loplugin::isSamePathname(fn, SRCDIR "/ucb/source/ucp/webdav-neon/ContentProperties.cxx"))
return;
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
for (auto const & pVarDecl : excludeVars) {
potentialVars.erase(pVarDecl);
}
for (auto const & varDecl : potentialVars) {
report(DiagnosticsEngine::Warning,
"rather declare this using OUStringLiteral or char[]",
varDecl->getLocation())
<< varDecl->getSourceRange();
}
}
bool StringStatic::VisitVarDecl(VarDecl const* varDecl)
{
if (ignoreLocation(varDecl)) {
return true;
}
QualType qt = varDecl->getType();
if (!varDecl->hasGlobalStorage()
|| !varDecl->isThisDeclarationADefinition()
|| !qt.isConstQualified()) {
return true;
}
if (qt->isArrayType()) {
qt = qt->getAsArrayTypeUnsafe()->getElementType();
}
if (!loplugin::TypeCheck(qt).Class("OUString").Namespace("rtl").GlobalNamespace()) {
return true;
}
if (varDecl->hasInit()) {
Expr const * expr = varDecl->getInit();
while (true) {
if (ExprWithCleanups const * exprWithCleanups = dyn_cast<ExprWithCleanups>(expr)) {
expr = exprWithCleanups->getSubExpr();
}
else if (CastExpr const * castExpr = dyn_cast<CastExpr>(expr)) {
expr = castExpr->getSubExpr();
}
else if (MaterializeTemporaryExpr const * materializeExpr = dyn_cast<MaterializeTemporaryExpr>(expr)) {
expr = materializeExpr->GetTemporaryExpr();
}
else if (CXXBindTemporaryExpr const * bindExpr = dyn_cast<CXXBindTemporaryExpr>(expr)) {
expr = bindExpr->getSubExpr();
}
else if (CXXConstructExpr const * constructExpr = dyn_cast<CXXConstructExpr>(expr)) {
if (constructExpr->getNumArgs() != 1) {
return true;
}
expr = constructExpr->getArg(0);
} else if (isa<CallExpr>(expr)) {
return true;
} else {
break;
}
}
}
potentialVars.insert(varDecl);
return true;
}
bool StringStatic::VisitReturnStmt(ReturnStmt const * returnStmt)
{
if (ignoreLocation(returnStmt)) {
return true;
}
if (!returnStmt->getRetValue()) {
return true;
}
DeclRefExpr const * declRef = dyn_cast<DeclRefExpr>(returnStmt->getRetValue());
if (!declRef) {
return true;
}
VarDecl const * varDecl = dyn_cast<VarDecl>(declRef->getDecl());
if (varDecl) {
excludeVars.insert(varDecl);
}
return true;
}
loplugin::Plugin::Registration<StringStatic> X("stringstatic");
} // namespace
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|
