summaryrefslogtreecommitdiff
path: root/sc
AgeCommit message (Collapse)AuthorFilesLines
17 hourstdf#158914 add back reusing weakly cached ScAccessibleCellsPatrick Luby3-4/+67
While commit 8e886993f32b7db11a99bdecf06451e6de6c3842 fixed tdf#157568, moving the selected cell rapidly creates a large number of stale ScAccessibleCell instances that aren't deleted until the Calc document is closed. So reduce memory usage by adding back the ScAccessibleCell cache that was in commit f22cb3dfab413a2917cd810b8e1b8f644a016327 now that a new fix for tdf#157568 has been implemented. The new fix for tdf#157568 is to do the following: - Check if the edit engine text has changed. If the input string is different than the edit engine's existing text, force update of the edit engine's text. Otherwise, the edit engine will still to be set to its existing text. - Before a cell loses focus, check if any accessible text changes have occurred and fire text and value changed notifications if needed. Change-Id: I106ad0138d5d834367be59ca625d41a692696d4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167961 Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
17 hourstdf#68034: sc_goal_seek: Add unittestXisco Fauli1-0/+25
Change-Id: I675d59cd7e22c09ea1c673e016d71f8d3ed404a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168890 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
21 hourstdf#161511: sc_goal_seek: Add unittestXisco Fauli3-0/+128
Change-Id: Icc05195a4870d5bb4f8c5ffc9b3bcae89367a89d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168866 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
22 hourstdf#68034: set the variable cell to value temporarily if neededMike Kaganski1-14/+18
Change-Id: I35fed710862ed87c477686e26bc8c82379c5e5a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168854 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
24 hoursCppunitTest_sc_copypaste: inherit from ScModelTestBaseXisco Fauli2-167/+78
Change-Id: I0847ba4455cec24332030e87244c0d9c9ad2ad2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168859 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
25 hoursCppunitTest_sc_jumbosheets_test: inherit from ScModelTestBaseXisco Fauli1-73/+40
Change-Id: Ifc35741c0d46dfbf3366696ea70284c382617a8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168861 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
33 hoursFlatten a bitMike Kaganski1-128/+124
Change-Id: If021f2edf8e4029d22118a2ed369b21a3a7215da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168836 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
35 hourstdf#161338: Pass a flag to ScDocument::Solver to avoid #NA! on errorMike Kaganski3-19/+6
This fixes the remaining problems: 1. It didn't restore variable cells with text of formulas properly. 2. Undoing after accepting the "closest value" dialog gave #NA! in the variable cell. This doesn't change the behavior of XGoalSeek::seekGoal. Change-Id: Ic9fbd3c99e6491b1c54b2e3b334090e51b1be661 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168763 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
44 hoursLet ScDocShell::GetLinkUpdateModeState honor isUntrustedRefererStephan Bergmann1-1/+8
Change-Id: I358911ad5180548767eadac3d15d0583598fe5e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168814 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2 daystdf#161511: create column if not existsMike Kaganski1-1/+1
Change-Id: I56a4792beab4c98a676b10d975fcd9be3fbef3ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168767 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
3 daystdf#161462 Remember Goal Seek settingsRafael Lima2-4/+41
Each time the user opens the Goal Seek dialogs, all settings are reset. This patch makes these settings be remembered during the same session. Change-Id: I60a121b4001f4666ee25ab807fdc3860cf798296 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168683 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
3 daystdf#161338 Do not change variable cell when Goal Seek failsRafael Lima1-1/+9
When Goal Seek fails, N/A error is inserted in the cell even if the user chooses No in the message dialog. Note that the solver definition in ScDocument::Solver forcefully inserts N/A when the solver fails, which seems to be usefull when creating scripts that use the Goal Seek. However, this behavior is not usefull when using the UI. This patch restores the original value of the variable cell when Goal Seek fails. Change-Id: I52d83b9de9b13667a81dd4a3ae8ab1c8545d6958 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168537 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
4 daysITEM: Change SfxItemSet to use unordered_setArmin Le Grand (allotropia)3-44/+13
With all the changes done for Items we can now do deeper basic changes to the ItemSet itself with manageable risk. I already did https://gerrit.libreoffice.org/c/core/+/166455 aka 'ITEM: Add measurements for SfxItemSet usages' to get some statistical information about the fill/usage grade of the ItemSet's fixed PtrArray to SfxPoolItems, check that out to get an own picture. Those results show that an average usage is between some extremes ranging from 0% to 50%, but when using more checks and using multiple files/interactions/edits in all applications we end up with around typical 12%-19% of that array used, the rest is nullptr's. Thus I thought about one of the initial ideas of this series of changes (ITEM), to use a std::unordered_map (A) instead of that fixed array of SfxPoolItem Ptr's (B). Tthat again was for a complete type-based rewrite, which I once did a POC, but the code cannot be adapted to that, just too much work. Those are very different in architecture, (B) is done since a long time (since ever), but as pointed out above, (A) is now possible. There are many aspects to it, let's grep some: Speed (iterate): (A) and (B) are both linear. (A) has less entries, but may touch different mem areas (buckets). (B) is linear, but many empty spaces which are usually uselessly iterated. Speed (access Item by WhichID): (A) is hashed by WhichID, so mostly linear for unordered_set/hash. (B) is in a linear array, but has to calculate the offset for each WhichID access. So I guess speed will mostly equal out. Memory: (A) will be dynamically allocated (buckets), but stl is highly optimized and may even re-use areas, has to provide some extra info but will need less places for Items since it's dynamic and can start empty. (B) will be allocated once (except AllItemSet) and may even be 'derived' to the ItemSet (SfxItemSetFixed), but has to allocate all space at once. I can go in lots of more detail here, but due to the results of the statistics I just made a test now, including measuring some results (will include in gerrit, not here). I used two pro versions for that. That way I have some data now. Result is: - It is now possible to do this, it runs stable :-) - Speed: As expected, mostly no change - Memory: Depending on usage, 0% to 25% less, usually around 8-10% Side effects: - SfxAllItemSet could be done without WhichRanges, thus without expensive 'merges' - SfxItemSetFixed is not needed. While the idea is good, it needs a lot of extra stuff - Access to Items is linear if set - WhichRanges: Still needed, but for vaildity checking/filtering of ItemSet content - WhichRanges: Worth to think about if these are needed at all, probably just exist for historical reasons since allocation/number of added Items was never ever dynamic -> just not allocatable Putting the current version on gerrit, may still trigger some UTs (checked SW/SC/SD...) I did not like that functionality at ItemSet that hands out a vector of the set items for cases where to avoid iterating and deleting items at the same time at an ItemSet, so changed to using a local vector of remembered WhichIDs and deleting after the iterator is done. I also saw some strange usages of SfxItemIter in sw which i will have to check. Since there are still problems with UTs which I can not reproduce locally I have now added asserts to the case that an ItemSet gets changed with still having active SfxItemIter(s). That is always an error, but with the architecture of that fixed array of ItemPtrs did not have devastating effects (purely by coincidence). With that asserts, UTs run well in SC and SD, but in SW I get 11 (eleven!) asserts from the UTs, all of them from 'ITEM: SfxItemSet ClearItem' BTW. I guess these have to be fixed before thinking about this change... Good news is that all 11 cases were the same in SW, in SwHistorySetAttrSet::SwHistorySetAttrSet which does some strange things using two SfxItemIter in parallel. Thus SW UTs are also clear and I see no more errors caused by ItemSets being changed while SfxItemIters are alive. Bad news is that I still have errors to hunt... NOTE: Have now cleaned all UTs, this showed that there are some unexpected side-effects of the Items being processed in another order when SfxItemIter is used, also found one case where a WhichRangesContainer is constructed for a SfxItemSet using the set items from another ItemSet and SfxItemIter to do so. There *might* be more cases not covered by UTs. NOTE: While speed stays the same and mem is reduced up to 25% (see measurements in 1st comment) another *important* aspect is that this frees the way for using ItemSets *without* WhichRanges - these are necessary mainly to create that fixed array of pointers to the Items in a *manageable* size. With a dynamic structure like unordered_set there is in principle *no need* anymore to use WhichRanges to pre-define the Items a Set could hold. There is one exception: We have cases where one ItemSet is set at another one with defined WhichRanges to *filter* the contained Items - these would have to be identified. This is a rare case and we would have to check cases where an ItemSet gets set at another ItemSet. This would be as if all ItemSets would be AllItemSets in principle - much easier for everyone. NOTE: Waited for 24.8 split just to not take unnecessary risks. Change-Id: I75b0ac1d8a4495a3ee93c1117bdf618702785990 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166972 Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Tested-by: Jenkins
4 daystdf#161496 - Fix single ocPush tokens in LET function Name valuesBalazs Varga2-137/+321
If the Name - Name Value pairs contains already an ocPush result no need to interpret, so the Calculation parameter can reuse it. Change-Id: I55465d674eb31aea7c3123c889250c9fa127f1fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168661 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
5 daystdf#158914 sc a11y: Remember new cell text againMichael Weghorn1-1/+2
commit 5f9a955042822d05af5c04b2c852738c7e1e21a2 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Fri Jun 7 13:03:19 2024 +0200 tdf#158914 sc a11y: Send TEXT_CHANGED event when text changes had made sending a `AccessibleEventId::VALUE_CHANGED` event conditional on the cell having a *numerical* value. Assigning the new string to `m_strCurCellValue` should always happen independent of this, though, as this is the string value, not the numerical value. Thanks to Patrick Luby for noting the difference in [1]. [1] https://gerrit.libreoffice.org/c/core/+/167961/comment/1af95eb6_7db33e0b/ Change-Id: I1d1da2caeb7f2199251599313ec4412d7b6e47b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168635 Tested-by: Jenkins Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
5 daystdf#161457 - Fix autofilter result is wrong when cells containBalazs Varga4-4/+46
formatted rounded values. Filtered formatted values were not sorted with the rounded values but with the original values and the duplicated values caused wrong filter results. Regression from commit: 2d1df9f3dccc10f13b8585ad18afce1542ebc4d1 (tdf#117276 sc: Show hidden filter elements as inactive elements) Change-Id: I7540ba5fa98e6bbe0b014448bf2449432261d542 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168592 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
6 daystdf#161454 - Fix new array functions handle empty matrix cellsBalazs Varga5-99/+400
Newly added calc array functions didn't handle empty matrix cells as empty cells but they were handled as empty strings. Change-Id: Ie24a38dd8c3f947cfe10ba05b234807891453824 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168591 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
6 daysRelated: tdf#137543 - fix LET function jump count numberBalazs Varga3-3/+3
Clean-up and fix wrong jump count. Change-Id: Ie64ff95f63c17d2726b3a522af981bcaea2a9a32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168590 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
6 daysofz#69444 Integer-overflowCaolán McNamara1-7/+7
Change-Id: I24d93f4c61256cd0750ab01cf5a8f313e875d35b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168580 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
7 dayscid#1603563 Unchecked return valueCaolán McNamara1-1/+1
Change-Id: Ie41d77d8809b28e44b2fa084f2f9e6cdfb6e167f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168579 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
8 daysprep AutoFill menu in kit mode onlyCaolán McNamara1-26/+29
Change-Id: Id533d78e1433b616ce661e855dad0d571d24cf8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168524 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
8 daysadd AutoFill menu items - LOK_CALLBACK_CONTEXT_MENUBayram Çiçek1-0/+29
- added AutoFill menu items "Copy cells" and "Fill series" - send information with LOK_CALLBACK_CONTEXT_MENU Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com> Change-Id: I3118f5535f74cfa4ab049e643930df83512b6850 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168086 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit a3f4d31783721f61b8436c5f8032321b4c97de1a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168531 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
8 daystdf#158914 sc a11y: Send TEXT_CHANGED event when text changesMichael Weghorn1-4/+17
Don't always send an `AccessibleEventId::VALUE_CHANGED` event when the string value of a Calc cell changes, but send a `AccessibleEventId::TEXT_CHANGED` event instead. Only send an `AccessibleEventId::VALUE_CHANGED` event in addition if the cell actually has value data, as the `XAccessibleValue` interface and the related `VALUE_CHANGED` event are meant to handle numerical values only. Together with changes like the one in PS 11 of [1], sending the `TEXT_CHANGE` event might help with missing text updates on the AT side, e.g. the NVDA or Accerciser scenarios described in [2], s. further discussion there. [1] https://gerrit.libreoffice.org/c/core/+/167961 [2] https://gerrit.libreoffice.org/c/core/+/167961/comments/16394c5a_338dbbf2 Change-Id: Ideba61a9200100c66d55fa18e81ea28e75092905 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168526 Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
9 daysRelated: tdf#137543 - Add new LET function to CalcBalazs Varga4-9/+59
Fix parsing name strings in Let function, so the invalid names will be parsed as an ocBad - svString like before. follow-up commit: 521a56d8d1e12b7471fda6b62b21d51776c9fbaf Change-Id: If4645584500ffd85556695b12fa7c99eaa8f7662 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168503 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
9 daystdf#137543 - Add new LET function to CalcBalazs Varga18-5/+4562
Add new LET function to Calc which assigns names to calculation results. TODO: oasis proposal Change-Id: Ia0d56a30751a44a72e364a28b64fd8f617e997dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168349 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
10 dayscid#1603200 Uninitialized scalar variableCaolán McNamara2-52/+47
cid#1603199 Uninitialized scalar variable and other fixups for: commit fbe8071e4f6be57d3e372d69a4c7cc4d37a83eb9 Date: Sat Oct 15 14:20:31 2022 +0200 refactor functions: return optional instead of bool Change-Id: I192017d0fc710ada7686e4c6dd313727b02f3889 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168453 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
10 daysannot: improve PDF annotation export and clean-up PDFNote classTomaž Vajngerl1-3/+4
Add support for exporting more PDF annotation types and props. Prefix member variables in PDFNote class, extract it out of pdfwriter.hxx file into it's own header file. Change-Id: I99fb4cbb0c68fcec6585c9c21d81daaef26344cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168418 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
11 daysResolves tdf#161395 - Rename Whole Number to IntegerHeiko Tietze5-8/+8
Change-Id: Id4cce115823781e5f2a4870d38d1f456cdf417a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168395 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
11 daysrefactor functions: return optional instead of boolAndrea Rosetti3-205/+207
Change-Id: Ic4ff3ddaac161df13bf1e3e1372811a0685ec6c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141417 Reviewed-by: Jonathan Clark <jonathan@libreoffice.org> Reviewed-by: Hossein <hossein@libreoffice.org> Tested-by: Jenkins
11 daysRelated: tdf#128425 tdf#127293 - Extend function wizard descriptionBalazs Varga3-229/+181
about match_mode and search_mode options. Also do not allow wildcard match mode with binary search mode as it was decided at the odf meetings. Change-Id: Iadc1b6735ae62bb07675a664d9954ebc27519691 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168366 Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins
11 dayssfx2: use SAL_RET_MAYBENULL in GetDispatcher() and GetFrame()Xisco Fauli2-41/+48
Change-Id: Ic9876dbdd0dc0ce887a6eb135bd411f8e3dc9e12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168288 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
12 dayscid#1459023 Dereference null return valueCaolán McNamara1-1/+1
Change-Id: I3ff5f121a76a30d07a80b46d469b669010318701 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168388 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
12 daystdf#160371: sc_subsequent_filters_test2: Add unittestXisco Fauli2-0/+13
Change-Id: Ife3a319359391f0614260170c9ddfbac16e13cbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168379 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
12 daystdf#161301: sc_subsequent_filters_test2: Add unittestXisco Fauli2-0/+13
Change-Id: I9eece5baa5c283caee74131151519c5e72e9cc45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168376 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
12 daystdf#158789: sc_mathematical_functions: Add unittestXisco Fauli1-0/+18
Change-Id: Ia19dadffa511cb012e4d0271e1e3768e1e374be0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168365 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
12 daysloplugin:ostr in scNoel Grandin53-656/+660
Change-Id: I72438d38c75a7facb9bd5f9cfb7be1213ac3d141 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168356 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
12 daysRename 'Organizer' to 'General' in style dialogsSamuel Mehrbrodt3-3/+3
This tab page has general information about the style - name, inheritance, etc. Change-Id: Ie06cf8b149a369117c5102ba7e2aae0d97249b83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166773 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
13 dayscid#1602446 silence Unchecked return valueCaolán McNamara1-1/+1
Change-Id: Idddff2f08dda1d43a197824fca82b69f7c212648 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168345 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
14 daysResolves: tdf#158789 operate on query array if no extra array or range givenEike Rathke1-1/+21
Also push error and bail out early if there was an error, or more important pResultMatrix is nullptr. Change-Id: I1094ed9d14795ea1bc3f4ff61d687cc28d0b94fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168300 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
14 daysloplugin:ostr in sc/../viewNoel Grandin30-122/+125
Change-Id: I24e84cd42e3f55761fbc1fb8ae9b2cf3fc7bd385 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168309 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
14 daysloplugin:ostr in sc/../docshellNoel Grandin14-63/+63
Change-Id: I181b23558eedd690492d804619a0f9345d1d532f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168308 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-06-01loplugin:ostr in sc/../drawfuncNoel Grandin14-42/+42
Change-Id: I5191883a86a004f2e7c283dc0e0e77de2f7eda04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168281 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-06-01Resolves tdf#152923 - Make column header outstanding from backgroundHeiko Tietze2-19/+14
* Background color made darker/lighter depending on system settings * Separator lines with less contrast (ShadowColor instead of DarkShadowColor) * Extra line for selection removed as it extends the actual header * Todo: Vertical header starts at a few pixels distance to the edge (patchset 4 fails) Change-Id: If3c47b77ad0bca2db1c25ec46b488a2e338b8133 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168225 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-05-31sc: use SAL_RET_MAYBENULL in GetTabViewShell()Xisco Fauli1-1/+1
Change-Id: Icbe2b301aea66a74baf100609f726fc0a6e824c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168292 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-31partial revert to restore existence of Expander wrappersCaolán McNamara12-0/+16
partial revert of: commit 8288d2e3061327fd91e241c0b514cd973e3fcea8 Date: Mon Nov 21 11:04:53 2022 +0200 loplugin:unusedfields because the existence of the welded expander wrappers matters for some of the backends to fully work Change-Id: Ie75e27329a47f708514466401e24eae6ddcd4c0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168208 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-05-31loplugin:ostr in sc/../miscdlgsNoel Grandin36-433/+443
Change-Id: I9cc24ed6692d9495e6ace3ccacbbe488ef82eea6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168282 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-05-31Related: tdf#161301 strip single stray leading "[$]" garbage from formatCodeEike Rathke1-0/+16
Which is the case if the actual format code is in an x16r2:formatCode16 attribute that isn't handled yet. Change-Id: Id35e774f8ccb167af2a46a8cc0f7611da76d708c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168232 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2024-05-31tdf#114398 ods export: output <text:line-break/> when CELLTYPE_EDITJustin Luth1-0/+5
assume regression since LO 4.2 based on LO 7.5 a7589f621fcbe6305335730d2dd86b9230a18594 for tdf#103829. Change-Id: I12726697565722e132941875fb32cad95c8f9768 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168270 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-05-31sc: Reduce number of calls to GetMarkedObjectList()Xisco Fauli20-106/+122
From 152 to 102 Change-Id: I43907965e5b1ef0819495d6a1e7b18597a1b5947 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168283 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-05-31Resolves tdf#160324 - Larger hitarea for column headerHeiko Tietze1-4/+1
Finalizes patch I6d527d2b0d0de3b48f123b626ebf0b6ce60299a5 Change-Id: Iff5cd4f6252e42cf8fad0aa2f37f70db0b8a15ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168210 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-15 15:02:47 +0000