summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2016-04-12SVG: Clean up this code a litle bitXisco Fauli2-7/+6
Change-Id: Ib941321d43a9a04d57f3c7c4a55528927fed5036 Reviewed-on: https://gerrit.libreoffice.org/24009 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
2016-04-12tdf#91794 removed OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar5-60/+14
I removed all the OSL_DEBUG_LEVEL > 1 conditionals by SAL_INFOs or OSL_DEBUG_LEVEL > 0 Change-Id: I261644a179e763612204bbb0e54a869fa1a62298 Reviewed-on: https://gerrit.libreoffice.org/23035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-04-12tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar3-39/+16
I removed OSL_DEBUG_LEVEL > 1 conditionals by SAL_INFO(..)s or OSL_DEBUG_LEVEL > 0 and made sure that it doesn't break the build Change-Id: I3eccdd769ff32e57e12209706e5fbbdd9638de54 Reviewed-on: https://gerrit.libreoffice.org/23068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-04-12tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar2-26/+14
I replaced OSL_DEBUG_LEVEL > 1 to OSL_DEBUG_LEVEL > 0 conditionals as suggested in easyhack. I didn't convert those fprintf statements because they were required for debug output formatting according to me Change-Id: I54d5b0873f527fd04d736eeb01d18f73eb9be74f Reviewed-on: https://gerrit.libreoffice.org/23069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-04-12tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar3-13/+11
I disentangled my previous patch to make one patch per module. I also modified the patch according to new directions given by Sweet5hark Change-Id: Id690f7c1e87230e4d10e1c9fe472f35d1d1caa8b Reviewed-on: https://gerrit.libreoffice.org/22924 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-04-12lp#1566050: prevent cyclic reference zombiesBjoern Michaelsen1-0/+1
regression, likely from 2660d24a07866e083c5135ea263030f3e3a2e729: 1/ Since that change mxAccessible in ScCsvGrid holds a rtl::Reference on a ScAccessibleCsvGrid 2/ Which in turn holds a VclPtr<> (aka a rtl::Reference with lipstick) on the ScCsvControl These are a circular references, making both of them live forever and leak past the point where on LibreOffice close all of Vcl is long gone, when these are dtored. Clearing mxAccessible on disposing should help. Change-Id: Iebb2635ec4ea143e7f0dbfebad2e6141a68e72e8 Reviewed-on: https://gerrit.libreoffice.org/24020 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-12clang-tidy performance-unnecessary-value-param in basctlNoel Grandin7-69/+59
Change-Id: Ie48eb08edd1335661d1ef57ae652713143951317
2016-04-12clang-tidy performance-unnecessary-value-param in frameworkNoel Grandin10-20/+20
Change-Id: I80987ea1bfac7478574de46ee30fc58fcc17eb68
2016-04-12clang-tidy performance-unnecessary-value-param in starmathNoel Grandin8-16/+16
Change-Id: Ic8d319dac1d18f548d47ac84e489c04412a38d1a
2016-04-12clang-tidy performance-unnecessary-value-param in sdNoel Grandin39-130/+130
Change-Id: Id55410931305a9695a001977a5227b430a984e99
2016-04-12clang-tidy performance-unnecessary-value-param in filterNoel Grandin21-38/+38
Change-Id: I6818f6c9593bfe7105cc194fcf6f69131046e4f3
2016-04-12clang-tidy performance-unnecessary-value-param in dbaccessNoel Grandin19-24/+24
Change-Id: I9cec61867b4e6e8abde7749047974c6de87b9669
2016-04-12clang-tidy performance-unnecessary-value-param in cuiNoel Grandin20-26/+26
Change-Id: I93a09bf8e475ec1aa2ebf7754c7048c81696922b
2016-04-12clang-tidy performance-unnecessary-value-param in chart2Noel Grandin44-122/+121
Change-Id: Id33dce9714737dd28ce48c22f966c9747c2db20b
2016-04-12clang-tidy performance-unnecessary-value-param in writerfilterNoel Grandin39-166/+165
Change-Id: I1f61be80ac1ebe42668580b09a261e7e3af1a403
2016-04-12vcl: split out part of ImplGetTabRect into new functionDouglas Mencken2-154/+170
Change-Id: I387417bf8fdfa85379b6d8eaa32738d0ed7ab519 Reviewed-on: https://gerrit.libreoffice.org/23900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-04-12tdf#96887 enhance SolarMutex AcquireWithWait for WindowsArmin Le Grand3-93/+34
Currently the Windows-specific method ImplSalYieldMutexAcquireWithWait() uses a messaging mechanism to learn about the SolarMutex being free again. This is not reliable when the MessageQueue overflows (MS allows 10000 messages per queue). It is more safe to use MsgWaitForMultipleObjects. This also allows to not only wait for the SolarMutex to be freed, but also to detect when SendMessage() is used which needs to lead to a reschedule to not block current Window handling. Change-Id: Id317dda62aaa1fe7677d8d28929e6936e5a22705 Reviewed-on: https://gerrit.libreoffice.org/23921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-04-12tdf#99224 PPTX export: implement support for images with textMiklos Vajna3-1/+15
In case an image had text, then ShapeExport::WriteGraphicObjectShapePart() wanted to write "only the text", but PowerPointShapeExport::WriteTextShape() had no idea how to write an image, so at the end nothing was exported. Change-Id: I6c1ad0b41d4c5dc260b952322fb8a59e7f175603
2016-04-12clang-tidy performance-unnecessary-value-param in scNoel Grandin27-90/+90
Change-Id: Ia2255e1e3f7a8834a4b5d2a6bbab2c6dd498d356
2016-04-12Revert "tdf#88206: use variadic variants for cppu helper"Stephan Bergmann7-13/+13
This reverts commit cf1ecad26d22e3dc5f556f976bdc49a31bfa5630. Library_mysqlc is external_code, so cannot use these LIBO_INTERNAL_ONLY features.
2016-04-12tdf#99135 VML import: handle image cropMiklos Vajna5-0/+49
The spec says in theory a % suffix could be also supported, but let's wait till that is seen in a real-world document. Change-Id: Ie026915e38dcb03c99085a1740075364b00e1c8d
2016-04-12give tools::ResId a shave and a haircutNoel Grandin4-34/+17
m_nRT2 and m_nWinBits fields are not in use anymore, at least as far back as 2013, when the heading files were moved around Change-Id: Ie3299a5999976450803332aeab72d5c0e68227e2 Reviewed-on: https://gerrit.libreoffice.org/23960 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke355-505/+7
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-12Add other tests to check_change_colorslideon1-0/+7
Add tests for GridColor and FootnoteLineColor Change-Id: Ia1112cbff5fd77ae1fa83fac362e917eb35f530d Reviewed-on: https://gerrit.libreoffice.org/24001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-04-12clang-tidy performance-unnecessary-value-param in swNoel Grandin18-24/+24
Change-Id: I3e030743b640d5a5f6b3bf4a4e9ba50ccd001287
2016-04-12clang-tidy performance-unnecessary-value-param in xmloffNoel Grandin40-72/+72
Change-Id: I8e6d8e66cdab2e50ee10882e139be29c14ce50f6
2016-04-12clang-tidy performance-unnecessary-value-param in vclNoel Grandin22-31/+31
Change-Id: I403f148060891feec56d7d2ef173a9c4934baf9e Reviewed-on: https://gerrit.libreoffice.org/23995 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-12lok context menu: Include uno commands for submenus tooPranav Kant1-0/+2
Change-Id: I4ba49ba94a3270a5d53754320e5fbd49e3f5c848
2016-04-12FwkTabWindow is unused since d6d86237b1b438919609988049ac4a152612fee1Maxim Monastirsky3-487/+0
Change-Id: Ifad573ac687548a889165012e7b7bb2f4b82750c
2016-04-12SaveToolbarController: Better support of readonly docsMaxim Monastirsky1-38/+41
The sfx2 impl. of XStorable::isReadonly isn't really helpful for files w/o write permissions that were switched to edit mode, as it returns the state of the UI. So instead let's just rely on the state of the .uno:Save slot. Change-Id: I3b033be3c9424a4479e9224f02d186960b540d21
2016-04-11don't install qstart.desktop if it's disabled (--disable-systray)Rene Engelhard2-1/+2
Change-Id: I21a53381ad4018034de3833e8e244d0d7a7d28b8
2016-04-12SaveToolbarController: Blacklist in Basic IDE tooMaxim Monastirsky1-0/+11
Save as/to remote don't work there. Still would be nice to have the modified state icon change there too, but that's for a future investigation. Change-Id: Id119a40c39f9c69738b1e61e23ffe3424276229e
2016-04-12SaveToolbarController: Blacklist RelationDesign in officecfgMaxim Monastirsky2-8/+12
Change-Id: I8aa14bb76a26aa12771000b393bee37d26ba85e7
2016-04-11tdf#88206: use variadic variants for cppu helperStefan Weiberg7-13/+13
Change-Id: I58a00f721cbb37f97fdbc599d57c26b1e89f4c73 Reviewed-on: https://gerrit.libreoffice.org/23998 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-04-11Lock member access in Frame::disposingStephan Bergmann1-65/+107
What a mess. Ideally, Frame would use its own rBHelper.rMutex, not SolarMutex. But much of the framework code it calls into uses SolarMutex, too, making it difficult to change that without running into the risk of deadlock. And then, some member variables are cleared early in Frame::disposing, while others are only cleared en bloc at the end. Be conservative and keep it that way (as other Frame functions recursively called from within Frame::disposing could observe the difference and rely on the current behavior), even if that means creating lots of small, independent locked regions within Frame::disposing (which can be detrimental to both performance and correctness). Change-Id: I28f9a379ce03ed661e96c7deb8eb73cb58fb2cf7
2016-04-11Turn disableLayoutManager into a member functionStephan Bergmann1-5/+6
Change-Id: I489859a53f98a1e70f8a79c3a974dd0d8954ccd1
2016-04-11Remove leftover commentsStephan Bergmann1-21/+0
Change-Id: Iabecc0d240c499ef81d8b85c8d0b37383813b06a
2016-04-11Remove obsolete commentStephan Bergmann1-3/+2
Change-Id: I43b65f48d75e293c3fe721e6d5a401f1e176df12
2016-04-11Combine successive private blocksStephan Bergmann1-4/+0
Change-Id: Id0da294261d9f42e4ba31864827e38e29bf44ea0
2016-04-11protected -> privateStephan Bergmann1-2/+0
Change-Id: Ic021240bbc2069d6d47b51c0b8e0d81739a72151
2016-04-11Fold impl_initializePropInfo into initListenersStephan Bergmann1-45/+33
Change-Id: I14d6461d442a8e0ff1efd719e7e2233ffbc523a5
2016-04-11No need to lock SolarMutex hereStephan Bergmann1-3/+0
Change-Id: Id626dc7c5c75b885b3665e06596b7a58d225cd4c
2016-04-11clang-tidy performance-unnecessary-value-param in vbahelperNoel Grandin4-6/+6
Change-Id: Ifbe78c4a43b9d77d6ecf481bb1a9aaac6bcd01a6
2016-04-11clang-tidy performance-unnecessary-value-param in unotoolsNoel Grandin5-25/+25
Change-Id: Ife11111b0265da5d5a8a98766a94f3b640b357f5
2016-04-11clang-tidy performance-unnecessary-value-param in ucbhelperNoel Grandin2-2/+2
Change-Id: I595485e8804d6f2e4e0f9bc8a78c8cb132411f7d
2016-04-11clang-tidy performance-unnecessary-value-param in toolsNoel Grandin2-2/+2
Change-Id: I57b2fd191dfd937f3327f148b27767b364acf667
2016-04-11clang-tidy performance-unnecessary-value-param in toolkitNoel Grandin3-9/+9
Change-Id: Ic08723ef15f2bc31031e3887b9916ecc7e2205da
2016-04-11clang-tidy performance-unnecessary-value-param in svxNoel Grandin22-33/+33
Change-Id: I3e8cd7cedb3e7b7ef05760d21b10994ce615324b
2016-04-11clang-tidy performance-unnecessary-value-param in svtoolsNoel Grandin9-9/+9
Change-Id: I6360a780aac9a387fed3a1c9a086196dbba0b089
2016-04-11clang-tidy performance-unnecessary-value-param in saxNoel Grandin2-4/+4
Change-Id: I46aad7b0a96210e5f3f278c3f6f3a945825b7cae
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-25 15:17:15 +0000