summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNoel Grandin <noel@peralex.com>2016-04-12 11:54:45 +0200
committerNoel Grandin <noel@peralex.com>2016-04-12 11:54:45 +0200
commit9649026cf50533595c172cd81b96acd45603d86b (patch)
treee7dade92b6674fe445ab36492afc2db02a827f05
parent6a8873c874db41e8818a74eb6bf2561dfdb296db (diff)
clang-tidy performance-unnecessary-value-param in sd
Change-Id: Id55410931305a9695a001977a5227b430a984e99
-rw-r--r--sd/inc/CustomAnimationEffect.hxx12
-rw-r--r--sd/inc/CustomAnimationPreset.hxx4
-rw-r--r--sd/source/core/CustomAnimationEffect.cxx12
-rw-r--r--sd/source/core/CustomAnimationPreset.cxx4
-rw-r--r--sd/source/filter/eppt/eppt.cxx4
-rw-r--r--sd/source/filter/eppt/epptooxml.hxx36
-rw-r--r--sd/source/filter/eppt/pptx-epptooxml.cxx50
-rw-r--r--sd/source/filter/xml/sdxmlwrp.cxx6
-rw-r--r--sd/source/ui/animations/CustomAnimationList.cxx10
-rw-r--r--sd/source/ui/animations/CustomAnimationList.hxx4
-rw-r--r--sd/source/ui/animations/CustomAnimationPane.cxx8
-rw-r--r--sd/source/ui/animations/CustomAnimationPane.hxx4
-rw-r--r--sd/source/ui/annotations/annotationmanager.cxx6
-rw-r--r--sd/source/ui/annotations/annotationmanagerimpl.hxx6
-rw-r--r--sd/source/ui/dlg/PhotoAlbumDialog.cxx4
-rw-r--r--sd/source/ui/dlg/PhotoAlbumDialog.hxx4
-rw-r--r--sd/source/ui/dlg/RemoteDialogClientBox.cxx2
-rw-r--r--sd/source/ui/dlg/RemoteDialogClientBox.hxx2
-rw-r--r--sd/source/ui/dlg/dlgass.cxx4
-rw-r--r--sd/source/ui/func/fuinsfil.cxx2
-rw-r--r--sd/source/ui/inc/RemoteServer.hxx6
-rw-r--r--sd/source/ui/inc/SlideSorterViewShell.hxx2
-rw-r--r--sd/source/ui/inc/View.hxx2
-rw-r--r--sd/source/ui/inc/ViewShell.hxx2
-rw-r--r--sd/source/ui/inc/tools/SdGlobalResourceContainer.hxx2
-rw-r--r--sd/source/ui/inc/unosrch.hxx8
-rw-r--r--sd/source/ui/remotecontrol/Server.cxx4
-rw-r--r--sd/source/ui/slidesorter/cache/SlsPageCacheManager.cxx10
-rw-r--r--sd/source/ui/slidesorter/inc/cache/SlsPageCacheManager.hxx10
-rw-r--r--sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx2
-rw-r--r--sd/source/ui/slidesorter/view/SlsLayeredDevice.cxx2
-rw-r--r--sd/source/ui/tools/SdGlobalResourceContainer.cxx2
-rw-r--r--sd/source/ui/unoidl/unolayer.cxx2
-rw-r--r--sd/source/ui/unoidl/unomodel.cxx4
-rw-r--r--sd/source/ui/unoidl/unosrch.cxx8
-rw-r--r--sd/source/ui/unoidl/unowcntr.cxx2
-rw-r--r--sd/source/ui/unoidl/unowcntr.hxx4
-rw-r--r--sd/source/ui/view/sdview3.cxx2
-rw-r--r--sd/source/ui/view/viewshel.cxx2
39 files changed, 130 insertions, 130 deletions
diff --git a/sd/inc/CustomAnimationEffect.hxx b/sd/inc/CustomAnimationEffect.hxx
index a8dcbe5c1a42..507bd9fc8fde 100644
--- a/sd/inc/CustomAnimationEffect.hxx
+++ b/sd/inc/CustomAnimationEffect.hxx
@@ -206,7 +206,7 @@ private:
struct stl_CustomAnimationEffect_search_node_predict
{
stl_CustomAnimationEffect_search_node_predict( const css::uno::Reference< css::animations::XAnimationNode >& xSearchNode );
- bool operator()( CustomAnimationEffectPtr pEffect ) const;
+ bool operator()( const CustomAnimationEffectPtr& pEffect ) const;
const css::uno::Reference< css::animations::XAnimationNode >& mxSearchNode;
};
@@ -310,10 +310,10 @@ public:
SAL_DLLPRIVATE CustomAnimationTextGroupPtr findGroup( sal_Int32 nGroupId );
CustomAnimationTextGroupPtr createTextGroup( CustomAnimationEffectPtr pEffect, sal_Int32 nTextGrouping, double fTextGroupingAuto, bool bAnimateForm, bool bTextReverse );
- SAL_DLLPRIVATE void setTextGrouping( CustomAnimationTextGroupPtr pTextGroup, sal_Int32 nTextGrouping );
- SAL_DLLPRIVATE void setAnimateForm( CustomAnimationTextGroupPtr pTextGroup, bool bAnimateForm );
- SAL_DLLPRIVATE void setTextGroupingAuto( CustomAnimationTextGroupPtr pTextGroup, double fTextGroupingAuto );
- SAL_DLLPRIVATE void setTextReverse( CustomAnimationTextGroupPtr pTextGroup, bool bAnimateForm );
+ SAL_DLLPRIVATE void setTextGrouping( const CustomAnimationTextGroupPtr& pTextGroup, sal_Int32 nTextGrouping );
+ SAL_DLLPRIVATE void setAnimateForm( const CustomAnimationTextGroupPtr& pTextGroup, bool bAnimateForm );
+ SAL_DLLPRIVATE void setTextGroupingAuto( const CustomAnimationTextGroupPtr& pTextGroup, double fTextGroupingAuto );
+ SAL_DLLPRIVATE void setTextReverse( const CustomAnimationTextGroupPtr& pTextGroup, bool bAnimateForm );
SAL_DLLPRIVATE sal_Int32 getSequenceType() const { return mnSequenceType; }
@@ -327,7 +327,7 @@ protected:
SAL_DLLPRIVATE virtual void implRebuild();
SAL_DLLPRIVATE virtual void reset();
- SAL_DLLPRIVATE void createTextGroupParagraphEffects( CustomAnimationTextGroupPtr pTextGroup, CustomAnimationEffectPtr pEffect, bool bUsed );
+ SAL_DLLPRIVATE void createTextGroupParagraphEffects( const CustomAnimationTextGroupPtr& pTextGroup, const CustomAnimationEffectPtr& pEffect, bool bUsed );
SAL_DLLPRIVATE void notify_listeners();
diff --git a/sd/inc/CustomAnimationPreset.hxx b/sd/inc/CustomAnimationPreset.hxx
index 8c8ef2fb518c..bd3da582d849 100644
--- a/sd/inc/CustomAnimationPreset.hxx
+++ b/sd/inc/CustomAnimationPreset.hxx
@@ -45,7 +45,7 @@ class CustomAnimationPreset
public:
CustomAnimationPreset( CustomAnimationEffectPtr pEffect );
- void add( CustomAnimationEffectPtr pEffect );
+ void add( const CustomAnimationEffectPtr& pEffect );
SD_DLLPUBLIC css::uno::Reference< css::animations::XAnimationNode > create( const OUString& rstrSubType );
@@ -109,7 +109,7 @@ public:
SAL_DLLPRIVATE const PresetCategoryList& getMotionPathsPresets() const { return maMotionPathsPresets; }
SAL_DLLPRIVATE const PresetCategoryList& getMiscPresets() const { return maMiscPresets; }
- SAL_DLLPRIVATE void changePresetSubType( CustomAnimationEffectPtr pEffect, const OUString& rPresetSubType ) const;
+ SAL_DLLPRIVATE void changePresetSubType( const CustomAnimationEffectPtr& pEffect, const OUString& rPresetSubType ) const;
private:
SAL_DLLPRIVATE void importEffects();
diff --git a/sd/source/core/CustomAnimationEffect.cxx b/sd/source/core/CustomAnimationEffect.cxx
index 674f3117bd94..14c659013b34 100644
--- a/sd/source/core/CustomAnimationEffect.cxx
+++ b/sd/source/core/CustomAnimationEffect.cxx
@@ -1992,7 +1992,7 @@ stl_CustomAnimationEffect_search_node_predict::stl_CustomAnimationEffect_search_
{
}
-bool stl_CustomAnimationEffect_search_node_predict::operator()( CustomAnimationEffectPtr pEffect ) const
+bool stl_CustomAnimationEffect_search_node_predict::operator()( const CustomAnimationEffectPtr& pEffect ) const
{
return pEffect->getNode() == mxSearchNode;
}
@@ -2450,7 +2450,7 @@ CustomAnimationTextGroupPtr EffectSequenceHelper::createTextGroup( CustomAnimati
return pTextGroup;
}
-void EffectSequenceHelper::createTextGroupParagraphEffects( CustomAnimationTextGroupPtr pTextGroup, CustomAnimationEffectPtr pEffect, bool bUsed )
+void EffectSequenceHelper::createTextGroupParagraphEffects( const CustomAnimationTextGroupPtr& pTextGroup, const CustomAnimationEffectPtr& pEffect, bool bUsed )
{
Reference< XShape > xTarget( pTextGroup->maTarget );
@@ -2543,7 +2543,7 @@ void EffectSequenceHelper::createTextGroupParagraphEffects( CustomAnimationTextG
}
}
-void EffectSequenceHelper::setTextGrouping( CustomAnimationTextGroupPtr pTextGroup, sal_Int32 nTextGrouping )
+void EffectSequenceHelper::setTextGrouping( const CustomAnimationTextGroupPtr& pTextGroup, sal_Int32 nTextGrouping )
{
if( pTextGroup->mnTextGrouping == nTextGrouping )
{
@@ -2623,7 +2623,7 @@ void EffectSequenceHelper::setTextGrouping( CustomAnimationTextGroupPtr pTextGro
}
}
-void EffectSequenceHelper::setAnimateForm( CustomAnimationTextGroupPtr pTextGroup, bool bAnimateForm )
+void EffectSequenceHelper::setAnimateForm( const CustomAnimationTextGroupPtr& pTextGroup, bool bAnimateForm )
{
if( pTextGroup->mbAnimateForm == bAnimateForm )
{
@@ -2695,7 +2695,7 @@ void EffectSequenceHelper::setAnimateForm( CustomAnimationTextGroupPtr pTextGrou
}
}
-void EffectSequenceHelper::setTextGroupingAuto( CustomAnimationTextGroupPtr pTextGroup, double fTextGroupingAuto )
+void EffectSequenceHelper::setTextGroupingAuto( const CustomAnimationTextGroupPtr& pTextGroup, double fTextGroupingAuto )
{
sal_Int32 nTextGrouping = pTextGroup->mnTextGrouping;
@@ -2772,7 +2772,7 @@ bool ImplStlTextGroupSortHelper::operator()( const CustomAnimationEffectPtr& p1,
}
}
-void EffectSequenceHelper::setTextReverse( CustomAnimationTextGroupPtr pTextGroup, bool bTextReverse )
+void EffectSequenceHelper::setTextReverse( const CustomAnimationTextGroupPtr& pTextGroup, bool bTextReverse )
{
if( pTextGroup->mbTextReverse == bTextReverse )
{
diff --git a/sd/source/core/CustomAnimationPreset.cxx b/sd/source/core/CustomAnimationPreset.cxx
index 024684e24fd2..9f7bb73da750 100644
--- a/sd/source/core/CustomAnimationPreset.cxx
+++ b/sd/source/core/CustomAnimationPreset.cxx
@@ -150,7 +150,7 @@ CustomAnimationPreset::CustomAnimationPreset( CustomAnimationEffectPtr pEffect )
}
-void CustomAnimationPreset::add( CustomAnimationEffectPtr pEffect )
+void CustomAnimationPreset::add( const CustomAnimationEffectPtr& pEffect )
{
maSubTypes[ pEffect->getPresetSubType() ] = pEffect;
}
@@ -526,7 +526,7 @@ const OUString& CustomAnimationPresets::translateName( const OUString& rId, cons
return rId;
}
}
-void CustomAnimationPresets::changePresetSubType( CustomAnimationEffectPtr pEffect, const OUString& rPresetSubType ) const
+void CustomAnimationPresets::changePresetSubType( const CustomAnimationEffectPtr& pEffect, const OUString& rPresetSubType ) const
{
if( pEffect.get() && pEffect->getPresetSubType() != rPresetSubType )
{
diff --git a/sd/source/filter/eppt/eppt.cxx b/sd/source/filter/eppt/eppt.cxx
index 5d7da71a2797..5605ba33d7c5 100644
--- a/sd/source/filter/eppt/eppt.cxx
+++ b/sd/source/filter/eppt/eppt.cxx
@@ -168,7 +168,7 @@ void PPTWriter::exportPPTPost( )
mbStatus = true;
};
-void ImplExportComments( uno::Reference< drawing::XDrawPage > xPage, SvMemoryStream& rBinaryTagData10Atom );
+void ImplExportComments( const uno::Reference< drawing::XDrawPage >& xPage, SvMemoryStream& rBinaryTagData10Atom );
void PPTWriter::ImplWriteSlide( sal_uInt32 nPageNum, sal_uInt32 nMasterNum, sal_uInt16 nMode,
bool bHasBackground, Reference< XPropertySet > aXBackgroundPropSet )
@@ -1074,7 +1074,7 @@ static OUString getInitials( const OUString& rName )
return sInitials;
}
-void ImplExportComments( uno::Reference< drawing::XDrawPage > xPage, SvMemoryStream& rBinaryTagData10Atom )
+void ImplExportComments( const uno::Reference< drawing::XDrawPage >& xPage, SvMemoryStream& rBinaryTagData10Atom )
{
try
{
diff --git a/sd/source/filter/eppt/epptooxml.hxx b/sd/source/filter/eppt/epptooxml.hxx
index db07494ff1bc..d84cd66523f4 100644
--- a/sd/source/filter/eppt/epptooxml.hxx
+++ b/sd/source/filter/eppt/epptooxml.hxx
@@ -99,28 +99,28 @@ protected:
virtual ::oox::ole::VbaProject* implCreateVbaProject() const override;
bool WriteNotesMaster();
- static void WriteAnimateTo( ::sax_fastparser::FSHelperPtr pFS, const css::uno::Any& rValue, const OUString& rAttributeName );
- static void WriteAnimateValues( ::sax_fastparser::FSHelperPtr pFS, const css::uno::Reference< css::animations::XAnimate >& rXAnimate );
- static void WriteAnimationCondition( ::sax_fastparser::FSHelperPtr pFS, css::uno::Any& rAny, bool bWriteEvent, bool bMainSeqChild );
- static void WriteAnimationCondition( ::sax_fastparser::FSHelperPtr pFS, const char* pDelay, const char* pEvent, double fDelay, bool bHasFDelay );
- void WriteAnimations( ::sax_fastparser::FSHelperPtr pFS );
- static void WriteAnimationAttributeName( ::sax_fastparser::FSHelperPtr pFS, const OUString& rAttributeName );
- void WriteAnimationNode( ::sax_fastparser::FSHelperPtr pFS, const css::uno::Reference< css::animations::XAnimationNode >& rXNode, bool bMainSeqChild );
- void WriteAnimationNodeAnimate( ::sax_fastparser::FSHelperPtr pFS, const css::uno::Reference< css::animations::XAnimationNode >& rXNode, sal_Int32 nXmlNodeType, bool bMainSeqChild );
- void WriteAnimationNodeAnimateInside( ::sax_fastparser::FSHelperPtr pFS, const css::uno::Reference< css::animations::XAnimationNode >& rXNode, bool bMainSeqChild, bool bSimple );
- void WriteAnimationNodeSeq( ::sax_fastparser::FSHelperPtr pFS, const css::uno::Reference< css::animations::XAnimationNode >& rXNode, sal_Int32 nXmlNodeType, bool bMainSeqChild );
- void WriteAnimationNodeEffect( ::sax_fastparser::FSHelperPtr pFS, const css::uno::Reference< css::animations::XAnimationNode >& rXNode, sal_Int32 nXmlNodeType, bool bMainSeqChild );
- void WriteAnimationNodeCommonPropsStart( ::sax_fastparser::FSHelperPtr pFS, const css::uno::Reference< css::animations::XAnimationNode >& rXNode, bool bSingle, bool bMainSeqChild );
- static void WriteAnimationProperty( ::sax_fastparser::FSHelperPtr pFS, const css::uno::Any& rAny );
- void WriteAnimationTarget( ::sax_fastparser::FSHelperPtr pFS, const css::uno::Any& rTarget );
+ static void WriteAnimateTo( const ::sax_fastparser::FSHelperPtr& pFS, const css::uno::Any& rValue, const OUString& rAttributeName );
+ static void WriteAnimateValues( const ::sax_fastparser::FSHelperPtr& pFS, const css::uno::Reference< css::animations::XAnimate >& rXAnimate );
+ static void WriteAnimationCondition( const ::sax_fastparser::FSHelperPtr& pFS, css::uno::Any& rAny, bool bWriteEvent, bool bMainSeqChild );
+ static void WriteAnimationCondition( const ::sax_fastparser::FSHelperPtr& pFS, const char* pDelay, const char* pEvent, double fDelay, bool bHasFDelay );
+ void WriteAnimations( const ::sax_fastparser::FSHelperPtr& pFS );
+ static void WriteAnimationAttributeName( const ::sax_fastparser::FSHelperPtr& pFS, const OUString& rAttributeName );
+ void WriteAnimationNode( const ::sax_fastparser::FSHelperPtr& pFS, const css::uno::Reference< css::animations::XAnimationNode >& rXNode, bool bMainSeqChild );
+ void WriteAnimationNodeAnimate( const ::sax_fastparser::FSHelperPtr& pFS, const css::uno::Reference< css::animations::XAnimationNode >& rXNode, sal_Int32 nXmlNodeType, bool bMainSeqChild );
+ void WriteAnimationNodeAnimateInside( const ::sax_fastparser::FSHelperPtr& pFS, const css::uno::Reference< css::animations::XAnimationNode >& rXNode, bool bMainSeqChild, bool bSimple );
+ void WriteAnimationNodeSeq( const ::sax_fastparser::FSHelperPtr& pFS, const css::uno::Reference< css::animations::XAnimationNode >& rXNode, sal_Int32 nXmlNodeType, bool bMainSeqChild );
+ void WriteAnimationNodeEffect( const ::sax_fastparser::FSHelperPtr& pFS, const css::uno::Reference< css::animations::XAnimationNode >& rXNode, sal_Int32 nXmlNodeType, bool bMainSeqChild );
+ void WriteAnimationNodeCommonPropsStart( const ::sax_fastparser::FSHelperPtr& pFS, const css::uno::Reference< css::animations::XAnimationNode >& rXNode, bool bSingle, bool bMainSeqChild );
+ static void WriteAnimationProperty( const ::sax_fastparser::FSHelperPtr& pFS, const css::uno::Any& rAny );
+ void WriteAnimationTarget( const ::sax_fastparser::FSHelperPtr& pFS, const css::uno::Any& rTarget );
bool WriteComments( sal_uInt32 nPageNum );
- void ImplWriteBackground( ::sax_fastparser::FSHelperPtr pFS, css::uno::Reference< css::beans::XPropertySet > aXBackgroundPropSet );
- void WriteTransition( ::sax_fastparser::FSHelperPtr pFS );
+ void ImplWriteBackground( const ::sax_fastparser::FSHelperPtr& pFS, const css::uno::Reference< css::beans::XPropertySet >& aXBackgroundPropSet );
+ void WriteTransition( const ::sax_fastparser::FSHelperPtr& pFS );
sal_Int32 GetLayoutFileId( sal_Int32 nOffset, sal_uInt32 nMasterNum );
// shapes
- void WriteShapeTree( ::sax_fastparser::FSHelperPtr pFS, PageType ePageType, bool bMaster );
+ void WriteShapeTree( const ::sax_fastparser::FSHelperPtr& pFS, PageType ePageType, bool bMaster );
sal_uInt32 GetNewSlideId() { return mnSlideIdMax ++; }
sal_uInt32 GetNewSlideMasterId() { return mnSlideMasterIdMax ++; }
@@ -130,7 +130,7 @@ private:
// Write docProps/core.xml and docprops/custom.xml and docprops/app.xml
void writeDocumentProperties();
- void AddLayoutIdAndRelation( ::sax_fastparser::FSHelperPtr pFS, sal_Int32 nLayoutFileId );
+ void AddLayoutIdAndRelation( const ::sax_fastparser::FSHelperPtr& pFS, sal_Int32 nLayoutFileId );
virtual OUString SAL_CALL getImplementationName() throw (css::uno::RuntimeException, std::exception) override;
diff --git a/sd/source/filter/eppt/pptx-epptooxml.cxx b/sd/source/filter/eppt/pptx-epptooxml.cxx
index fdd1d4e9eb65..0132e62245ea 100644
--- a/sd/source/filter/eppt/pptx-epptooxml.cxx
+++ b/sd/source/filter/eppt/pptx-epptooxml.cxx
@@ -120,11 +120,11 @@ public:
ShapeExport& WriteNonVisualProperties( const Reference< XShape >& xShape ) override;
ShapeExport& WriteTextShape( const Reference< XShape >& xShape ) override;
ShapeExport& WriteUnknownShape( const Reference< XShape >& xShape ) override;
- ShapeExport& WritePlaceholderShape( Reference< XShape > xShape, PlaceholderType ePlaceholder );
- ShapeExport& WritePageShape( Reference< XShape > xShape, PageType ePageType, bool bPresObj );
+ ShapeExport& WritePlaceholderShape( const Reference< XShape >& xShape, PlaceholderType ePlaceholder );
+ ShapeExport& WritePageShape( const Reference< XShape >& xShape, PageType ePageType, bool bPresObj );
// helper parts
- bool WritePlaceholder( Reference< XShape > xShape, PlaceholderType ePlaceholder, bool bMaster );
+ bool WritePlaceholder( const Reference< XShape >& xShape, PlaceholderType ePlaceholder, bool bMaster );
};
enum PPTXLayout {
@@ -413,7 +413,7 @@ bool PowerPointExport::exportDocument() throw (css::uno::RuntimeException, std::
return new ::oox::ole::VbaProject( getComponentContext(), getModel(), "Impress" );
}
-void PowerPointExport::ImplWriteBackground( FSHelperPtr pFS, Reference< XPropertySet > rXPropSet )
+void PowerPointExport::ImplWriteBackground( const FSHelperPtr& pFS, const Reference< XPropertySet >& rXPropSet )
{
FillStyle aFillStyle( FillStyle_NONE );
if ( ImplGetPropertyValue( rXPropSet, "FillStyle" ) )
@@ -512,7 +512,7 @@ const char* PowerPointExport::Get8Direction( sal_uInt8 nDirection )
return pDirection;
}
-void PowerPointExport::WriteTransition( FSHelperPtr pFS )
+void PowerPointExport::WriteTransition( const FSHelperPtr& pFS )
{
FadeEffect eFadeEffect = FadeEffect_NONE;
GET( eFadeEffect, Effect );
@@ -801,7 +801,7 @@ void PowerPointExport::WriteTransition( FSHelperPtr pFS )
}
}
-void PowerPointExport::WriteAnimationProperty( FSHelperPtr pFS, const Any& rAny )
+void PowerPointExport::WriteAnimationProperty( const FSHelperPtr& pFS, const Any& rAny )
{
if( !rAny.hasValue() )
return;
@@ -817,7 +817,7 @@ void PowerPointExport::WriteAnimationProperty( FSHelperPtr pFS, const Any& rAny
}
}
-void PowerPointExport::WriteAnimateValues( FSHelperPtr pFS, const Reference< XAnimate >& rXAnimate )
+void PowerPointExport::WriteAnimateValues( const FSHelperPtr& pFS, const Reference< XAnimate >& rXAnimate )
{
const Sequence< double > aKeyTimes = rXAnimate->getKeyTimes();
if( aKeyTimes.getLength() <= 0 )
@@ -853,7 +853,7 @@ void PowerPointExport::WriteAnimateValues( FSHelperPtr pFS, const Reference< XAn
pFS->endElementNS( XML_p, XML_tavLst );
}
-void PowerPointExport::WriteAnimateTo( FSHelperPtr pFS, const Any& rValue, const OUString& rAttributeName )
+void PowerPointExport::WriteAnimateTo( const FSHelperPtr& pFS, const Any& rValue, const OUString& rAttributeName )
{
if( !rValue.hasValue() )
return;
@@ -867,7 +867,7 @@ void PowerPointExport::WriteAnimateTo( FSHelperPtr pFS, const Any& rValue, const
pFS->endElementNS( XML_p, XML_to );
}
-void PowerPointExport::WriteAnimationAttributeName( FSHelperPtr pFS, const OUString& rAttributeName )
+void PowerPointExport::WriteAnimationAttributeName( const FSHelperPtr& pFS, const OUString& rAttributeName )
{
if( rAttributeName.isEmpty() )
return;
@@ -892,7 +892,7 @@ void PowerPointExport::WriteAnimationAttributeName( FSHelperPtr pFS, const OUStr
pFS->endElementNS( XML_p, XML_attrNameLst );
}
-void PowerPointExport::WriteAnimationTarget( FSHelperPtr pFS, const Any& rTarget )
+void PowerPointExport::WriteAnimationTarget( const FSHelperPtr& pFS, const Any& rTarget )
{
sal_Int32 nBegin = -1, nEnd = -1;
bool bParagraphTarget;
@@ -916,7 +916,7 @@ void PowerPointExport::WriteAnimationTarget( FSHelperPtr pFS, const Any& rTarget
}
}
-void PowerPointExport::WriteAnimationNodeAnimate( FSHelperPtr pFS, const Reference< XAnimationNode >& rXNode, sal_Int32 nXmlNodeType, bool bMainSeqChild )
+void PowerPointExport::WriteAnimationNodeAnimate( const FSHelperPtr& pFS, const Reference< XAnimationNode >& rXNode, sal_Int32 nXmlNodeType, bool bMainSeqChild )
{
Reference< XAnimate > rXAnimate( rXNode, UNO_QUERY );
if( !rXAnimate.is() )
@@ -957,7 +957,7 @@ void PowerPointExport::WriteAnimationNodeAnimate( FSHelperPtr pFS, const Referen
pFS->endElementNS( XML_p, nXmlNodeType );
}
-void PowerPointExport::WriteAnimationNodeAnimateInside( FSHelperPtr pFS, const Reference< XAnimationNode >& rXNode, bool bMainSeqChild, bool bSimple )
+void PowerPointExport::WriteAnimationNodeAnimateInside( const FSHelperPtr& pFS, const Reference< XAnimationNode >& rXNode, bool bMainSeqChild, bool bSimple )
{
Reference< XAnimate > rXAnimate( rXNode, UNO_QUERY );
if( !rXAnimate.is() )
@@ -996,7 +996,7 @@ void PowerPointExport::WriteAnimationNodeAnimateInside( FSHelperPtr pFS, const R
WriteAnimateTo( pFS, rXAnimate->getTo(), rXAnimate->getAttributeName() );
}
-void PowerPointExport::WriteAnimationCondition( FSHelperPtr pFS, const char* pDelay, const char* pEvent, double fDelay, bool bHasFDelay )
+void PowerPointExport::WriteAnimationCondition( const FSHelperPtr& pFS, const char* pDelay, const char* pEvent, double fDelay, bool bHasFDelay )
{
if( bHasFDelay || pDelay || pEvent ) {
if( !pEvent )
@@ -1018,7 +1018,7 @@ void PowerPointExport::WriteAnimationCondition( FSHelperPtr pFS, const char* pDe
}
}
-void PowerPointExport::WriteAnimationCondition( FSHelperPtr pFS, Any& rAny, bool bWriteEvent, bool bMainSeqChild )
+void PowerPointExport::WriteAnimationCondition( const FSHelperPtr& pFS, Any& rAny, bool bWriteEvent, bool bMainSeqChild )
{
bool bHasFDelay = false;
double fDelay = 0;
@@ -1093,7 +1093,7 @@ void PowerPointExport::WriteAnimationCondition( FSHelperPtr pFS, Any& rAny, bool
WriteAnimationCondition( pFS, pDelay, pEvent, fDelay, bHasFDelay );
}
-void PowerPointExport::WriteAnimationNodeCommonPropsStart( FSHelperPtr pFS, const Reference< XAnimationNode >& rXNode, bool bSingle, bool bMainSeqChild )
+void PowerPointExport::WriteAnimationNodeCommonPropsStart( const FSHelperPtr& pFS, const Reference< XAnimationNode >& rXNode, bool bSingle, bool bMainSeqChild )
{
const char* pDuration = nullptr;
const char* pRestart = nullptr;
@@ -1283,7 +1283,7 @@ void PowerPointExport::WriteAnimationNodeCommonPropsStart( FSHelperPtr pFS, cons
pFS->endElementNS( XML_p, XML_cTn );
}
-void PowerPointExport::WriteAnimationNodeSeq( FSHelperPtr pFS, const Reference< XAnimationNode >& rXNode, sal_Int32, bool bMainSeqChild )
+void PowerPointExport::WriteAnimationNodeSeq( const FSHelperPtr& pFS, const Reference< XAnimationNode >& rXNode, sal_Int32, bool bMainSeqChild )
{
DBG(printf ("write animation node SEQ\n"));
@@ -1302,7 +1302,7 @@ void PowerPointExport::WriteAnimationNodeSeq( FSHelperPtr pFS, const Reference<
pFS->endElementNS( XML_p, XML_seq );
}
-void PowerPointExport::WriteAnimationNodeEffect( FSHelperPtr pFS, const Reference< XAnimationNode >& rXNode, sal_Int32, bool bMainSeqChild )
+void PowerPointExport::WriteAnimationNodeEffect( const FSHelperPtr& pFS, const Reference< XAnimationNode >& rXNode, sal_Int32, bool bMainSeqChild )
{
DBG(printf ("write animation node FILTER\n"));
@@ -1321,11 +1321,11 @@ void PowerPointExport::WriteAnimationNodeEffect( FSHelperPtr pFS, const Referenc
}
}
-void PowerPointExport::WriteAnimationNode( FSHelperPtr pFS, const Reference< XAnimationNode >& rXNode, bool bMainSeqChild )
+void PowerPointExport::WriteAnimationNode( const FSHelperPtr& pFS, const Reference< XAnimationNode >& rXNode, bool bMainSeqChild )
{
DBG(printf ("export node type: %d\n", rXNode->getType()));
sal_Int32 xmlNodeType = -1;
- typedef void (PowerPointExport::*AnimationNodeWriteMethod)( FSHelperPtr, const Reference< XAnimationNode >&, sal_Int32, bool );
+ typedef void (PowerPointExport::*AnimationNodeWriteMethod)( const FSHelperPtr&, const Reference< XAnimationNode >&, sal_Int32, bool );
AnimationNodeWriteMethod pMethod = nullptr;
switch( rXNode->getType() ) {
@@ -1364,7 +1364,7 @@ void PowerPointExport::WriteAnimationNode( FSHelperPtr pFS, const Reference< XAn
pFS->endElementNS( XML_p, xmlNodeType );
}
-void PowerPointExport::WriteAnimations( FSHelperPtr pFS )
+void PowerPointExport::WriteAnimations( const FSHelperPtr& pFS )
{
Reference< XAnimationNodeSupplier > xNodeSupplier( mXDrawPage, UNO_QUERY );
if( xNodeSupplier.is() ) {
@@ -1648,7 +1648,7 @@ void PowerPointExport::ImplWriteNotes( sal_uInt32 nPageNum )
DBG(printf("----------------\n"));
}
-void PowerPointExport::AddLayoutIdAndRelation( FSHelperPtr pFS, sal_Int32 nLayoutFileId )
+void PowerPointExport::AddLayoutIdAndRelation( const FSHelperPtr& pFS, sal_Int32 nLayoutFileId )
{
// add implicit relation of slide master to slide layout
OUString sRelId = addRelation( pFS->getOutputStream(),
@@ -1850,7 +1850,7 @@ void PowerPointExport::ImplWritePPTXLayout( sal_Int32 nOffset, sal_uInt32 nMaste
xDrawPages->remove( xSlide );
}
-void PowerPointExport::WriteShapeTree( FSHelperPtr pFS, PageType ePageType, bool bMaster )
+void PowerPointExport::WriteShapeTree( const FSHelperPtr& pFS, PageType ePageType, bool bMaster )
{
PowerPointShapeExport aDML( pFS, &maShapeMap, this );
aDML.SetMaster( bMaster );
@@ -1879,7 +1879,7 @@ void PowerPointExport::WriteShapeTree( FSHelperPtr pFS, PageType ePageType, bool
pFS->endElementNS( XML_p, XML_spTree );
}
-ShapeExport& PowerPointShapeExport::WritePageShape( Reference< XShape > xShape, PageType ePageType, bool bPresObj )
+ShapeExport& PowerPointShapeExport::WritePageShape( const Reference< XShape >& xShape, PageType ePageType, bool bPresObj )
{
if( ( ePageType == NOTICE && bPresObj ) || ePageType == LAYOUT )
return WritePlaceholderShape( xShape, SlideImage );
@@ -1887,7 +1887,7 @@ ShapeExport& PowerPointShapeExport::WritePageShape( Reference< XShape > xShape,
return WriteTextShape( xShape );
}
-bool PowerPointShapeExport::WritePlaceholder( Reference< XShape > xShape, PlaceholderType ePlaceholder, bool bMaster )
+bool PowerPointShapeExport::WritePlaceholder( const Reference< XShape >& xShape, PlaceholderType ePlaceholder, bool bMaster )
{
DBG(printf("WritePlaceholder %d %d\n", bMaster, ShapeExport::NonEmptyText( xShape )));
if( bMaster && ShapeExport::NonEmptyText( xShape ) ) {
@@ -1899,7 +1899,7 @@ bool PowerPointShapeExport::WritePlaceholder( Reference< XShape > xShape, Placeh
return false;
}
-ShapeExport& PowerPointShapeExport::WritePlaceholderShape( Reference< XShape > xShape, PlaceholderType ePlaceholder )
+ShapeExport& PowerPointShapeExport::WritePlaceholderShape( const Reference< XShape >& xShape, PlaceholderType ePlaceholder )
{
mpFS->startElementNS( XML_p, XML_sp, FSEND );
diff --git a/sd/source/filter/xml/sdxmlwrp.cxx b/sd/source/filter/xml/sdxmlwrp.cxx
index 7d9fbf74012a..c49b96c60736 100644
--- a/sd/source/filter/xml/sdxmlwrp.cxx
+++ b/sd/source/filter/xml/sdxmlwrp.cxx
@@ -170,8 +170,8 @@ namespace
{
sal_Int32 ReadThroughComponent(
- Reference<io::XInputStream> xInputStream,
- Reference<XComponent> xModelComponent,
+ const Reference<io::XInputStream>& xInputStream,
+ const Reference<XComponent>& xModelComponent,
const OUString& rStreamName,
Reference<uno::XComponentContext> & rxContext,
const sal_Char* pFilterName,
@@ -312,7 +312,7 @@ sal_Int32 ReadThroughComponent(
sal_Int32 ReadThroughComponent(
const uno::Reference < embed::XStorage >& xStorage,
- Reference<XComponent> xModelComponent,
+ const Reference<XComponent>& xModelComponent,
const sal_Char* pStreamName,
const sal_Char* pCompatibilityStreamName,
Reference<uno::XComponentContext> & rxContext,
diff --git a/sd/source/ui/animations/CustomAnimationList.cxx b/sd/source/ui/animations/CustomAnimationList.cxx
index 0c64fededbdf..328478a47584 100644
--- a/sd/source/ui/animations/CustomAnimationList.cxx
+++ b/sd/source/ui/animations/CustomAnimationList.cxx
@@ -522,7 +522,7 @@ void CustomAnimationList::KeyInput( const KeyEvent& rKEvt )
/** selects or deselects the given effect.
Selections of other effects are not changed */
-void CustomAnimationList::select( CustomAnimationEffectPtr pEffect )
+void CustomAnimationList::select( const CustomAnimationEffectPtr& pEffect )
{
CustomAnimationListEntry* pEntry = static_cast< CustomAnimationListEntry* >(First());
while( pEntry )
@@ -551,7 +551,7 @@ void CustomAnimationList::clear()
mxLastTargetShape = nullptr;
}
-void CustomAnimationList::update( MainSequencePtr pMainSequence )
+void CustomAnimationList::update( const MainSequencePtr& pMainSequence )
{
if( mpMainSequence.get() )
mpMainSequence->removeListener( this );
@@ -566,11 +566,11 @@ void CustomAnimationList::update( MainSequencePtr pMainSequence )
struct stl_append_effect_func : public std::unary_function<CustomAnimationEffectPtr, void>
{
explicit stl_append_effect_func( CustomAnimationList& rList ) : mrList( rList ) {}
- void operator()(CustomAnimationEffectPtr pEffect);
+ void operator()(const CustomAnimationEffectPtr& pEffect);
CustomAnimationList& mrList;
};
-void stl_append_effect_func::operator()(CustomAnimationEffectPtr pEffect)
+void stl_append_effect_func::operator()(const CustomAnimationEffectPtr& pEffect)
{
mrList.append( pEffect );
}
@@ -790,7 +790,7 @@ void CustomAnimationList::append( CustomAnimationEffectPtr pEffect )
}
}
-void selectShape( SvTreeListBox* pTreeList, Reference< XShape > xShape )
+void selectShape( SvTreeListBox* pTreeList, const Reference< XShape >& xShape )
{
CustomAnimationListEntry* pEntry = static_cast< CustomAnimationListEntry* >(pTreeList->First());
while( pEntry )
diff --git a/sd/source/ui/animations/CustomAnimationList.hxx b/sd/source/ui/animations/CustomAnimationList.hxx
index 376934509790..e72bf4bfc3c6 100644
--- a/sd/source/ui/animations/CustomAnimationList.hxx
+++ b/sd/source/ui/animations/CustomAnimationList.hxx
@@ -58,10 +58,10 @@ public:
/** selects or deselects the given effect.
Selections of other effects are not changed */
- void select( CustomAnimationEffectPtr pEffect );
+ void select( const CustomAnimationEffectPtr& pEffect );
/** populates the list with all effects from the given MainSequence */
- void update( MainSequencePtr pMainSequence );
+ void update( const MainSequencePtr& pMainSequence );
void update();
diff --git a/sd/source/ui/animations/CustomAnimationPane.cxx b/sd/source/ui/animations/CustomAnimationPane.cxx
index 0d7b55259fbb..66f64e8e2776 100644
--- a/sd/source/ui/animations/CustomAnimationPane.cxx
+++ b/sd/source/ui/animations/CustomAnimationPane.cxx
@@ -759,7 +759,7 @@ void CustomAnimationPane::updateControls()
updateMotionPathTags();
}
-static bool updateMotionPathImpl( CustomAnimationPane& rPane, ::sd::View& rView, EffectSequence::iterator aIter, EffectSequence::iterator aEnd, MotionPathTagVector& rOldTags, MotionPathTagVector& rNewTags )
+static bool updateMotionPathImpl( CustomAnimationPane& rPane, ::sd::View& rView, EffectSequence::iterator aIter, const EffectSequence::iterator& aEnd, MotionPathTagVector& rOldTags, MotionPathTagVector& rNewTags )
{
bool bChanges = false;
while( aIter != aEnd )
@@ -940,7 +940,7 @@ void addValue( STLPropertySet* pSet, sal_Int32 nHandle, const Any& rValue )
}
}
-static sal_Int32 calcMaxParaDepth( Reference< XShape > xTargetShape )
+static sal_Int32 calcMaxParaDepth( const Reference< XShape >& xTargetShape )
{
sal_Int32 nMaxParaDepth = -1;
@@ -970,7 +970,7 @@ static sal_Int32 calcMaxParaDepth( Reference< XShape > xTargetShape )
return nMaxParaDepth + 1;
}
-Any CustomAnimationPane::getProperty1Value( sal_Int32 nType, CustomAnimationEffectPtr pEffect )
+Any CustomAnimationPane::getProperty1Value( sal_Int32 nType, const CustomAnimationEffectPtr& pEffect )
{
switch( nType )
{
@@ -1025,7 +1025,7 @@ Any CustomAnimationPane::getProperty1Value( sal_Int32 nType, CustomAnimationEffe
return aAny;
}
-bool CustomAnimationPane::setProperty1Value( sal_Int32 nType, CustomAnimationEffectPtr pEffect, const Any& rValue )
+bool CustomAnimationPane::setProperty1Value( sal_Int32 nType, const CustomAnimationEffectPtr& pEffect, const Any& rValue )
{
bool bEffectChanged = false;
switch( nType )
diff --git a/sd/source/ui/animations/CustomAnimationPane.hxx b/sd/source/ui/animations/CustomAnimationPane.hxx
index c124c1591c0c..7729fd9058fb 100644
--- a/sd/source/ui/animations/CustomAnimationPane.hxx
+++ b/sd/source/ui/animations/CustomAnimationPane.hxx
@@ -113,8 +113,8 @@ private:
STLPropertySet* createSelectionSet();
void changeSelection( STLPropertySet* pResultSet, STLPropertySet* pOldSet );
- static css::uno::Any getProperty1Value( sal_Int32 nType, CustomAnimationEffectPtr pEffect );
- bool setProperty1Value( sal_Int32 nType, CustomAnimationEffectPtr pEffect, const css::uno::Any& rValue );
+ static css::uno::Any getProperty1Value( sal_Int32 nType, const CustomAnimationEffectPtr& pEffect );
+ bool setProperty1Value( sal_Int32 nType, const CustomAnimationEffectPtr& pEffect, const css::uno::Any& rValue );
void UpdateLook();
sal_uInt32 fillAnimationLB();
diff --git a/sd/source/ui/annotations/annotationmanager.cxx b/sd/source/ui/annotations/annotationmanager.cxx
index f4ae8aa3e738..20e565669b1a 100644
--- a/sd/source/ui/annotations/annotationmanager.cxx
+++ b/sd/source/ui/annotations/annotationmanager.cxx
@@ -478,7 +478,7 @@ void AnnotationManagerImpl::ExecuteReplyToAnnotation( SfxRequest& rReq )
}
}
-void AnnotationManagerImpl::DeleteAnnotation( Reference< XAnnotation > xAnnotation )
+void AnnotationManagerImpl::DeleteAnnotation( const Reference< XAnnotation >& xAnnotation )
{
SdPage* pPage = GetCurrentPage();
@@ -719,7 +719,7 @@ void AnnotationManagerImpl::onTagDeselected( AnnotationTag& rTag )
}
}
-void AnnotationManagerImpl::SelectAnnotation( css::uno::Reference< css::office::XAnnotation > xAnnotation, bool bEdit /* = sal_False */ )
+void AnnotationManagerImpl::SelectAnnotation( const css::uno::Reference< css::office::XAnnotation >& xAnnotation, bool bEdit /* = sal_False */ )
{
mxSelectedAnnotation = xAnnotation;
@@ -901,7 +901,7 @@ IMPL_LINK_TYPED(AnnotationManagerImpl,EventMultiplexerListener,
}
}
-void AnnotationManagerImpl::ExecuteAnnotationContextMenu( Reference< XAnnotation > xAnnotation, vcl::Window* pParent, const Rectangle& rContextRect, bool bButtonMenu /* = false */ )
+void AnnotationManagerImpl::ExecuteAnnotationContextMenu( const Reference< XAnnotation >& xAnnotation, vcl::Window* pParent, const Rectangle& rContextRect, bool bButtonMenu /* = false */ )
{
SfxDispatcher* pDispatcher( getDispatcher( mrBase ) );
if( !pDispatcher )
diff --git a/sd/source/ui/annotations/annotationmanagerimpl.hxx b/sd/source/ui/annotations/annotationmanagerimpl.hxx
index 643d3a02c0ce..5f6a6d409775 100644
--- a/sd/source/ui/annotations/annotationmanagerimpl.hxx
+++ b/sd/source/ui/annotations/annotationmanagerimpl.hxx
@@ -70,15 +70,15 @@ public:
void SelectNextAnnotation(bool bForeward);
- void SelectAnnotation( css::uno::Reference< css::office::XAnnotation > xAnnotation, bool bEdit = false );
+ void SelectAnnotation( const css::uno::Reference< css::office::XAnnotation >& xAnnotation, bool bEdit = false );
void GetSelectedAnnotation( css::uno::Reference< css::office::XAnnotation >& xAnnotation );
void InsertAnnotation();
- void DeleteAnnotation( css::uno::Reference< css::office::XAnnotation > xAnnotation );
+ void DeleteAnnotation( const css::uno::Reference< css::office::XAnnotation >& xAnnotation );
void DeleteAnnotationsByAuthor( const OUString& sAuthor );
void DeleteAllAnnotations();
- void ExecuteAnnotationContextMenu( css::uno::Reference< css::office::XAnnotation > xAnnotation, vcl::Window* pParent, const Rectangle& rContextRect, bool bButtonMenu = false );
+ void ExecuteAnnotationContextMenu( const css::uno::Reference< css::office::XAnnotation >& xAnnotation, vcl::Window* pParent, const Rectangle& rContextRect, bool bButtonMenu = false );
static Color GetColorDark(sal_uInt16 aAuthorIndex);
static Color GetColorLight(sal_uInt16 aAuthorIndex);
diff --git a/sd/source/ui/dlg/PhotoAlbumDialog.cxx b/sd/source/ui/dlg/PhotoAlbumDialog.cxx
index 962b05a72f15..e92c9399273d 100644
--- a/sd/source/ui/dlg/PhotoAlbumDialog.cxx
+++ b/sd/source/ui/dlg/PhotoAlbumDialog.cxx
@@ -636,7 +636,7 @@ IMPL_LINK_NOARG_TYPED(SdPhotoAlbumDialog, SelectHdl, ListBox&, void)
}
Reference< drawing::XDrawPage > SdPhotoAlbumDialog::appendNewSlide(AutoLayout aLayout,
- Reference< drawing::XDrawPages > xDrawPages
+ const Reference< drawing::XDrawPages >& xDrawPages
)
{
Reference< drawing::XDrawPage > xSlide; // Create the slide
@@ -690,7 +690,7 @@ void SdPhotoAlbumDialog::createCaption(const awt::Size& aPageSize )
}
Reference< graphic::XGraphic> SdPhotoAlbumDialog::createXGraphicFromUrl(const OUString& sUrl,
- Reference< graphic::XGraphicProvider> xProvider
+ const Reference< graphic::XGraphicProvider>& xProvider
)
{
// The same as above, except this returns an XGraphic from the image URL
diff --git a/sd/source/ui/dlg/PhotoAlbumDialog.hxx b/sd/source/ui/dlg/PhotoAlbumDialog.hxx
index cdcbf44a9028..8c35d5594025 100644
--- a/sd/source/ui/dlg/PhotoAlbumDialog.hxx
+++ b/sd/source/ui/dlg/PhotoAlbumDialog.hxx
@@ -81,12 +81,12 @@ private:
DECL_LINK_TYPED(SelectHdl, ListBox&, void);
Reference< drawing::XDrawPage > appendNewSlide(AutoLayout aLayout,
- Reference< drawing::XDrawPages > xDrawPages);
+ const Reference< drawing::XDrawPages >& xDrawPages);
static awt::Size createASRSize(const awt::Size& aPicSize, const awt::Size& aMaxSize);
void createCaption(const awt::Size& aPageSize);
static Reference< graphic::XGraphic> createXGraphicFromUrl(const OUString& sUrl,
- Reference< graphic::XGraphicProvider> xProvider);
+ const Reference< graphic::XGraphicProvider>& xProvider);
void EnableDisableButtons();
diff --git a/sd/source/ui/dlg/RemoteDialogClientBox.cxx b/sd/source/ui/dlg/RemoteDialogClientBox.cxx
index 0d7e63241c7e..b18c70e96462 100644
--- a/sd/source/ui/dlg/RemoteDialogClientBox.cxx
+++ b/sd/source/ui/dlg/RemoteDialogClientBox.cxx
@@ -631,7 +631,7 @@ bool ClientBox::Notify( NotifyEvent& rNEvt )
return true;
}
-long ClientBox::addEntry( std::shared_ptr<ClientInfo> pClientInfo )
+long ClientBox::addEntry( const std::shared_ptr<ClientInfo>& pClientInfo )
{
long nPos = 0;
diff --git a/sd/source/ui/dlg/RemoteDialogClientBox.hxx b/sd/source/ui/dlg/RemoteDialogClientBox.hxx
index 5751e05f6cd2..c125efe040ef 100644
--- a/sd/source/ui/dlg/RemoteDialogClientBox.hxx
+++ b/sd/source/ui/dlg/RemoteDialogClientBox.hxx
@@ -147,7 +147,7 @@ public:
void RecalcAll();
void selectEntry( const long nPos );
- long addEntry(std::shared_ptr<ClientInfo> pClientInfo);
+ long addEntry(const std::shared_ptr<ClientInfo>& pClientInfo);
void clearEntries();
OUString getPin();
diff --git a/sd/source/ui/dlg/dlgass.cxx b/sd/source/ui/dlg/dlgass.cxx
index 11268d11eb14..75d8f7e45874 100644
--- a/sd/source/ui/dlg/dlgass.cxx
+++ b/sd/source/ui/dlg/dlgass.cxx
@@ -161,7 +161,7 @@ public:
VclPtr<vcl::Window> mpWindow;
- void SavePassword( SfxObjectShellLock xDoc, const OUString& rPath );
+ void SavePassword( const SfxObjectShellLock& xDoc, const OUString& rPath );
void RestorePassword( SfxItemSet* pSet, const OUString& rPath );
uno::Sequence < beans::NamedValue > GetPassword( const OUString& rPath );
void DeletePasswords();
@@ -1555,7 +1555,7 @@ void AssistentDlgImpl::UpdatePreview( bool bDocPreview )
mbPreviewUpdating = false;
}
-void AssistentDlgImpl::SavePassword( SfxObjectShellLock xDoc, const OUString& rPath )
+void AssistentDlgImpl::SavePassword( const SfxObjectShellLock& xDoc, const OUString& rPath )
{
if(xDoc.Is())
{
diff --git a/sd/source/ui/func/fuinsfil.cxx b/sd/source/ui/func/fuinsfil.cxx
index 04aba7188a9d..113c46e7965a 100644
--- a/sd/source/ui/func/fuinsfil.cxx
+++ b/sd/source/ui/func/fuinsfil.cxx
@@ -97,7 +97,7 @@ OUString lcl_GetExtensionsList ( ::std::vector< FilterDesc > const& rFilterDescL
}
void lcl_AddFilter ( ::std::vector< FilterDesc >& rFilterDescList,
- std::shared_ptr<const SfxFilter> pFilter )
+ const std::shared_ptr<const SfxFilter>& pFilter )
{
if (pFilter)
rFilterDescList.push_back( ::std::make_pair( pFilter->GetUIName(), pFilter->GetDefaultExtension() ) );
diff --git a/sd/source/ui/inc/RemoteServer.hxx b/sd/source/ui/inc/RemoteServer.hxx
index e6bc07ac938a..97fb55c2b515 100644
--- a/sd/source/ui/inc/RemoteServer.hxx
+++ b/sd/source/ui/inc/RemoteServer.hxx
@@ -70,9 +70,9 @@ namespace sd
// For the control dialog
SD_DLLPUBLIC static std::vector< std::shared_ptr< ClientInfo > > getClients();
- SD_DLLPUBLIC static bool connectClient( std::shared_ptr< ClientInfo > pClient,
- const OUString& aPin );
- SD_DLLPUBLIC static void deauthoriseClient( std::shared_ptr< ClientInfo > pClient );
+ SD_DLLPUBLIC static bool connectClient( const std::shared_ptr< ClientInfo >& pClient,
+ const OUString& aPin );
+ SD_DLLPUBLIC static void deauthoriseClient( const std::shared_ptr< ClientInfo >& pClient );
/// ensure that discoverability (eg. for Bluetooth) is enabled
SD_DLLPUBLIC static void ensureDiscoverable();
diff --git a/sd/source/ui/inc/SlideSorterViewShell.hxx b/sd/source/ui/inc/SlideSorterViewShell.hxx
index 833821114f5a..4a9f544b2e9d 100644
--- a/sd/source/ui/inc/SlideSorterViewShell.hxx
+++ b/sd/source/ui/inc/SlideSorterViewShell.hxx
@@ -185,7 +185,7 @@ public:
virtual css::uno::Reference<css::accessibility::XAccessible>
CreateAccessibleDocumentView (::sd::Window* pWindow) override;
// handle SlideSorterView specially because AccessibleSlideSorterView doesn't inherit from AccessibleDocumentViewBase
- virtual void SwitchViewFireFocus( css::uno::Reference< css::accessibility::XAccessible > xAcc ) override;
+ virtual void SwitchViewFireFocus( const css::uno::Reference< css::accessibility::XAccessible >& xAcc ) override;
// Exported for unit test
SD_DLLPUBLIC SlideSorter& GetSlideSorter() const;
diff --git a/sd/source/ui/inc/View.hxx b/sd/source/ui/inc/View.hxx
index 17e6fe6e2005..c1b97b34e9f9 100644
--- a/sd/source/ui/inc/View.hxx
+++ b/sd/source/ui/inc/View.hxx
@@ -153,7 +153,7 @@ public:
SdrMediaObj* InsertMediaObj( const OUString& rURL, const OUString& rMimeType, sal_Int8& rAction,
const Point& rPos, const Size& rSize );
- bool PasteRTFTable( ::tools::SvRef<SotStorageStream> xStm, SdrPage* pPage, SdrInsertFlags nPasteOptions );
+ bool PasteRTFTable( const ::tools::SvRef<SotStorageStream>& xStm, SdrPage* pPage, SdrInsertFlags nPasteOptions );
bool IsPresObjSelected(bool bOnPage = true, bool bOnMasterPage = true, bool bCheckPresObjListOnly = false, bool bCheckLayoutOnly = false) const;
diff --git a/sd/source/ui/inc/ViewShell.hxx b/sd/source/ui/inc/ViewShell.hxx
index ff51ab593d70..9b50fcdf2cbe 100644
--- a/sd/source/ui/inc/ViewShell.hxx
+++ b/sd/source/ui/inc/ViewShell.hxx
@@ -292,7 +292,7 @@ public:
virtual css::uno::Reference<css::accessibility::XAccessible>
CreateAccessibleDocumentView (::sd::Window* pWindow);
- virtual void SwitchViewFireFocus( css::uno::Reference< css::accessibility::XAccessible > xAcc );
+ virtual void SwitchViewFireFocus( const css::uno::Reference< css::accessibility::XAccessible >& xAcc );
void SwitchActiveViewFireFocus( );
// Move these two methods from DrawViewShell to enable slide show view
void NotifyAccUpdate();
diff --git a/sd/source/ui/inc/tools/SdGlobalResourceContainer.hxx b/sd/source/ui/inc/tools/SdGlobalResourceContainer.hxx
index 3f33bf98b052..e1c483eec439 100644
--- a/sd/source/ui/inc/tools/SdGlobalResourceContainer.hxx
+++ b/sd/source/ui/inc/tools/SdGlobalResourceContainer.hxx
@@ -73,7 +73,7 @@ public:
time of the destruction of SgGlobalResourceContainer no other
references exist the resource is destroyed as well.
*/
- void AddResource (std::shared_ptr<SdGlobalResource> pResource);
+ void AddResource (const std::shared_ptr<SdGlobalResource>& pResource);
/** Add a resource that is implemented as UNO object. Destruction
(when the sd modules is unloaded) is done by a) calling dispose()
diff --git a/sd/source/ui/inc/unosrch.hxx b/sd/source/ui/inc/unosrch.hxx
index 016d3b62eeb4..650912ba5fa6 100644
--- a/sd/source/ui/inc/unosrch.hxx
+++ b/sd/source/ui/inc/unosrch.hxx
@@ -45,11 +45,11 @@ protected:
css::drawing::XShape* mpShape;
css::drawing::XDrawPage* mpPage;
- css::uno::Reference< css::text::XTextRange > Search( css::uno::Reference< css::text::XTextRange > xText, SdUnoSearchReplaceDescriptor* pDescr ) throw();
+ css::uno::Reference< css::text::XTextRange > Search( const css::uno::Reference< css::text::XTextRange >& xText, SdUnoSearchReplaceDescriptor* pDescr ) throw();
bool Search( const OUString& rText, sal_Int32& nStartPos, sal_Int32& nEndPos, SdUnoSearchReplaceDescriptor* pDescr ) throw();
- static ESelection GetSelection( css::uno::Reference< css::text::XTextRange > xTextRange ) throw();
- static css::uno::Reference< css::drawing::XShape > GetShape( css::uno::Reference< css::text::XTextRange > xTextRange ) throw();
- css::uno::Reference< css::drawing::XShape > GetNextShape( css::uno::Reference< css::container::XIndexAccess > xShapes, css::uno::Reference< css::drawing::XShape > xCurrentShape ) throw();
+ static ESelection GetSelection( const css::uno::Reference< css::text::XTextRange >& xTextRange ) throw();
+ static css::uno::Reference< css::drawing::XShape > GetShape( const css::uno::Reference< css::text::XTextRange >& xTextRange ) throw();
+ css::uno::Reference< css::drawing::XShape > GetNextShape( const css::uno::Reference< css::container::XIndexAccess >& xShapes, const css::uno::Reference< css::drawing::XShape >& xCurrentShape ) throw();
css::uno::Reference< css::drawing::XShape > GetCurrentShape() const throw();
public:
diff --git a/sd/source/ui/remotecontrol/Server.cxx b/sd/source/ui/remotecontrol/Server.cxx
index f0ebbff1acd3..f58d69f9b71b 100644
--- a/sd/source/ui/remotecontrol/Server.cxx
+++ b/sd/source/ui/remotecontrol/Server.cxx
@@ -270,7 +270,7 @@ std::vector< std::shared_ptr< ClientInfo > > RemoteServer::getClients()
return aClients;
}
-bool RemoteServer::connectClient( std::shared_ptr< ClientInfo > pClient, const OUString& aPin )
+bool RemoteServer::connectClient( const std::shared_ptr< ClientInfo >& pClient, const OUString& aPin )
{
SAL_INFO( "sdremote", "RemoteServer::connectClient called" );
if ( !spServer )
@@ -337,7 +337,7 @@ bool RemoteServer::connectClient( std::shared_ptr< ClientInfo > pClient, const O
}
}
-void RemoteServer::deauthoriseClient( std::shared_ptr< ClientInfo > pClient )
+void RemoteServer::deauthoriseClient( const std::shared_ptr< ClientInfo >& pClient )
{
// TODO: we probably want to forcefully disconnect at this point too?
// But possibly via a separate function to allow just disconnecting from
diff --git a/sd/source/ui/slidesorter/cache/SlsPageCacheManager.cxx b/sd/source/ui/slidesorter/cache/SlsPageCacheManager.cxx
index 52048b77e641..3919dad3a59b 100644
--- a/sd/source/ui/slidesorter/cache/SlsPageCacheManager.cxx
+++ b/sd/source/ui/slidesorter/cache/SlsPageCacheManager.cxx
@@ -190,7 +190,7 @@ PageCacheManager::~PageCacheManager()
}
std::shared_ptr<PageCacheManager::Cache> PageCacheManager::GetCache (
- DocumentKey pDocument,
+ const DocumentKey& pDocument,
const Size& rPreviewSize)
{
std::shared_ptr<Cache> pResult;
@@ -223,7 +223,7 @@ std::shared_ptr<PageCacheManager::Cache> PageCacheManager::GetCache (
void PageCacheManager::Recycle (
const std::shared_ptr<Cache>& rpCache,
- DocumentKey pDocument,
+ const DocumentKey& pDocument,
const Size& rPreviewSize)
{
BestFittingPageCaches aCaches;
@@ -315,7 +315,7 @@ std::shared_ptr<PageCacheManager::Cache> PageCacheManager::ChangeSize (
}
bool PageCacheManager::InvalidatePreviewBitmap (
- DocumentKey pDocument,
+ const DocumentKey& pDocument,
const SdrPage* pKey)
{
bool bHasChanged (false);
@@ -343,7 +343,7 @@ bool PageCacheManager::InvalidatePreviewBitmap (
return bHasChanged;
}
-void PageCacheManager::InvalidateAllPreviewBitmaps (DocumentKey pDocument)
+void PageCacheManager::InvalidateAllPreviewBitmaps (const DocumentKey& pDocument)
{
if (pDocument == nullptr)
return;
@@ -387,7 +387,7 @@ void PageCacheManager::ReleasePreviewBitmap (const SdrPage* pPage)
}
std::shared_ptr<PageCacheManager::Cache> PageCacheManager::GetRecentlyUsedCache (
- DocumentKey pDocument,
+ const DocumentKey& pDocument,
const Size& rPreviewSize)
{
std::shared_ptr<Cache> pCache;
diff --git a/sd/source/ui/slidesorter/inc/cache/SlsPageCacheManager.hxx b/sd/source/ui/slidesorter/inc/cache/SlsPageCacheManager.hxx
index 47ce0de0b61f..97e6d426c6e0 100644
--- a/sd/source/ui/slidesorter/inc/cache/SlsPageCacheManager.hxx
+++ b/sd/source/ui/slidesorter/inc/cache/SlsPageCacheManager.hxx
@@ -58,7 +58,7 @@ public:
pointer and the ReleaseCache() method has not been called.
*/
std::shared_ptr<Cache> GetCache (
- DocumentKey pDocument,
+ const DocumentKey& pDocument,
const Size& rPreviewSize);
/** Tell the cache manager to release its own reference to the specified
@@ -82,14 +82,14 @@ public:
the next time.
*/
bool InvalidatePreviewBitmap (
- DocumentKey pDocument,
+ const DocumentKey& pDocument,
const SdrPage* pPage);
/** Invalidate the preview bitmaps for all slides that belong to the
specified document. This is necessary after model changes that
affect e.g. page number fields.
*/
- void InvalidateAllPreviewBitmaps (DocumentKey pDocument);
+ void InvalidateAllPreviewBitmaps (const DocumentKey& pDocument);
/** Invalidate all the caches that are currently in use and destroy
those that are not. This is used for example when the high contrast
@@ -131,7 +131,7 @@ private:
friend class Deleter;
std::shared_ptr<Cache> GetRecentlyUsedCache(
- DocumentKey pDocument,
+ const DocumentKey& pDocument,
const Size& rSize);
/** Add the given cache to the list of recently used caches for the
@@ -148,7 +148,7 @@ private:
*/
void Recycle (
const std::shared_ptr<Cache>& rpCache,
- DocumentKey pDocument,
+ const DocumentKey& pDocument,
const Size& rPreviewSize);
};
diff --git a/sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx b/sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx
index 9fc0c14aa63b..3393c5a8f182 100644
--- a/sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx
+++ b/sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx
@@ -268,7 +268,7 @@ css::uno::Reference<css::accessibility::XAccessible>
return xRet;
}
-void SlideSorterViewShell::SwitchViewFireFocus(css::uno::Reference< css::accessibility::XAccessible > xAcc )
+void SlideSorterViewShell::SwitchViewFireFocus(const css::uno::Reference< css::accessibility::XAccessible >& xAcc )
{
if (xAcc.get())
{
diff --git a/sd/source/ui/slidesorter/view/SlsLayeredDevice.cxx b/sd/source/ui/slidesorter/view/SlsLayeredDevice.cxx
index 67dfc709a4e0..46d1c24d80f5 100644
--- a/sd/source/ui/slidesorter/view/SlsLayeredDevice.cxx
+++ b/sd/source/ui/slidesorter/view/SlsLayeredDevice.cxx
@@ -74,7 +74,7 @@ void DeviceCopy (
rSourceDevice);
}
-void ForAllRectangles (const vcl::Region& rRegion, ::std::function<void (const Rectangle&)> aFunction)
+void ForAllRectangles (const vcl::Region& rRegion, const std::function<void (const Rectangle&)>& aFunction)
{
OSL_ASSERT(aFunction);
RectangleVector aRectangles;
diff --git a/sd/source/ui/tools/SdGlobalResourceContainer.cxx b/sd/source/ui/tools/SdGlobalResourceContainer.cxx
index 4eb35b221d73..358266c75ad2 100644
--- a/sd/source/ui/tools/SdGlobalResourceContainer.cxx
+++ b/sd/source/ui/tools/SdGlobalResourceContainer.cxx
@@ -89,7 +89,7 @@ void SdGlobalResourceContainer::AddResource (
}
void SdGlobalResourceContainer::AddResource (
- std::shared_ptr<SdGlobalResource> pResource)
+ const std::shared_ptr<SdGlobalResource>& pResource)
{
::osl::MutexGuard aGuard (mpImpl->maMutex);
diff --git a/sd/source/ui/unoidl/unolayer.cxx b/sd/source/ui/unoidl/unolayer.cxx
index d088e4629cc3..b556ae33f120 100644
--- a/sd/source/ui/unoidl/unolayer.cxx
+++ b/sd/source/ui/unoidl/unolayer.cxx
@@ -734,7 +734,7 @@ namespace
@return
Return </True> if both pointers point to the same object.
*/
-bool compare_layers (uno::WeakReference<uno::XInterface> xRef, void* pSearchData)
+bool compare_layers (const uno::WeakReference<uno::XInterface>& xRef, void* pSearchData)
{
uno::Reference<uno::XInterface> xLayer (xRef);
if (xLayer.is())
diff --git a/sd/source/ui/unoidl/unomodel.cxx b/sd/source/ui/unoidl/unomodel.cxx
index bb58cd2b426f..9380a183852c 100644
--- a/sd/source/ui/unoidl/unomodel.cxx
+++ b/sd/source/ui/unoidl/unomodel.cxx
@@ -1601,7 +1601,7 @@ sal_Int32 ImplPDFGetBookmarkPage( const OUString& rBookmark, SdDrawDocument& rDo
return nPage;
}
-void ImplPDFExportComments( uno::Reference< drawing::XDrawPage > xPage, vcl::PDFExtOutDevData& rPDFExtOutDevData )
+void ImplPDFExportComments( const uno::Reference< drawing::XDrawPage >& xPage, vcl::PDFExtOutDevData& rPDFExtOutDevData )
{
try
{
@@ -1636,7 +1636,7 @@ void ImplPDFExportComments( uno::Reference< drawing::XDrawPage > xPage, vcl::PDF
}
}
-void ImplPDFExportShapeInteraction( uno::Reference< drawing::XShape > xShape, SdDrawDocument& rDoc, vcl::PDFExtOutDevData& rPDFExtOutDevData )
+void ImplPDFExportShapeInteraction( const uno::Reference< drawing::XShape >& xShape, SdDrawDocument& rDoc, vcl::PDFExtOutDevData& rPDFExtOutDevData )
{
if ( xShape->getShapeType() == "com.sun.star.drawing.GroupShape" )
{
diff --git a/sd/source/ui/unoidl/unosrch.cxx b/sd/source/ui/unoidl/unosrch.cxx
index dffab997c61a..a4353007c9fa 100644
--- a/sd/source/ui/unoidl/unosrch.cxx
+++ b/sd/source/ui/unoidl/unosrch.cxx
@@ -400,7 +400,7 @@ uno::Reference< css::uno::XInterface > SAL_CALL SdUnoSearchReplaceShape::findNex
/** this method returns the shape that follows xCurrentShape in the shape collection xShapes.
It steps recursive into groupshapes and returns the xCurrentShape if it is the last
shape in this collection */
-uno::Reference< drawing::XShape > SdUnoSearchReplaceShape::GetNextShape( uno::Reference< container::XIndexAccess > xShapes, uno::Reference< drawing::XShape > xCurrentShape ) throw()
+uno::Reference< drawing::XShape > SdUnoSearchReplaceShape::GetNextShape( const uno::Reference< container::XIndexAccess >& xShapes, const uno::Reference< drawing::XShape >& xCurrentShape ) throw()
{
uno::Reference< drawing::XShape > xFound;
@@ -457,7 +457,7 @@ uno::Reference< drawing::XShape > SdUnoSearchReplaceShape::GetNextShape( uno::R
return xFound;
}
-uno::Reference< text::XTextRange > SdUnoSearchReplaceShape::Search( uno::Reference< text::XTextRange > xText, SdUnoSearchReplaceDescriptor* pDescr ) throw()
+uno::Reference< text::XTextRange > SdUnoSearchReplaceShape::Search( const uno::Reference< text::XTextRange >& xText, SdUnoSearchReplaceDescriptor* pDescr ) throw()
{
if(!xText.is())
return uno::Reference< text::XTextRange > ();
@@ -658,7 +658,7 @@ bool SdUnoSearchReplaceShape::Search( const OUString& rText, sal_Int32& nStartPo
return false;
}
-ESelection SdUnoSearchReplaceShape::GetSelection( uno::Reference< text::XTextRange > xTextRange ) throw()
+ESelection SdUnoSearchReplaceShape::GetSelection( const uno::Reference< text::XTextRange >& xTextRange ) throw()
{
ESelection aSel;
SvxUnoTextRangeBase* pRange = SvxUnoTextRangeBase::getImplementation( xTextRange );
@@ -669,7 +669,7 @@ ESelection SdUnoSearchReplaceShape::GetSelection( uno::Reference< text::XTextRan
return aSel;
}
-uno::Reference< drawing::XShape > SdUnoSearchReplaceShape::GetShape( uno::Reference< text::XTextRange > xTextRange ) throw()
+uno::Reference< drawing::XShape > SdUnoSearchReplaceShape::GetShape( const uno::Reference< text::XTextRange >& xTextRange ) throw()
{
uno::Reference< drawing::XShape > xShape;
diff --git a/sd/source/ui/unoidl/unowcntr.cxx b/sd/source/ui/unoidl/unowcntr.cxx
index a34d3020e633..759d7ecaabec 100644
--- a/sd/source/ui/unoidl/unowcntr.cxx
+++ b/sd/source/ui/unoidl/unowcntr.cxx
@@ -35,7 +35,7 @@ SvUnoWeakContainer::~SvUnoWeakContainer() throw()
}
/** inserts the given ref into this container */
-void SvUnoWeakContainer::insert( uno::WeakReference< uno::XInterface > xRef ) throw()
+void SvUnoWeakContainer::insert( const uno::WeakReference< uno::XInterface >& xRef ) throw()
{
for ( WeakRefList::iterator it = maList.begin(); it != maList.end(); )
{
diff --git a/sd/source/ui/unoidl/unowcntr.hxx b/sd/source/ui/unoidl/unowcntr.hxx
index fdf35c88fc51..53a5e98c1c8e 100644
--- a/sd/source/ui/unoidl/unowcntr.hxx
+++ b/sd/source/ui/unoidl/unowcntr.hxx
@@ -23,7 +23,7 @@
#include <cppuhelper/weakref.hxx>
#include <list>
-typedef bool (*weakref_searchfunc)( css::uno::WeakReference< css::uno::XInterface > xRef, void* pSearchData );
+typedef bool (*weakref_searchfunc)( const css::uno::WeakReference< css::uno::XInterface >& xRef, void* pSearchData );
typedef ::std::list< css::uno::WeakReference< css::uno::XInterface >* > WeakRefList;
@@ -37,7 +37,7 @@ public:
~SvUnoWeakContainer() throw();
/** inserts the given ref into this container */
- void insert( css::uno::WeakReference< css::uno::XInterface > xRef ) throw();
+ void insert( const css::uno::WeakReference< css::uno::XInterface >& xRef ) throw();
/** searches the container for a ref that returns true on the given
search function
diff --git a/sd/source/ui/view/sdview3.cxx b/sd/source/ui/view/sdview3.cxx
index 2403cbc646ac..dce7d92f98f7 100644
--- a/sd/source/ui/view/sdview3.cxx
+++ b/sd/source/ui/view/sdview3.cxx
@@ -1518,7 +1518,7 @@ bool View::InsertData( const TransferableDataHelper& rDataHelper,
return bReturn;
}
-bool View::PasteRTFTable( ::tools::SvRef<SotStorageStream> xStm, SdrPage* pPage, SdrInsertFlags nPasteOptions )
+bool View::PasteRTFTable( const ::tools::SvRef<SotStorageStream>& xStm, SdrPage* pPage, SdrInsertFlags nPasteOptions )
{
std::unique_ptr<SdDrawDocument> pModel(new SdDrawDocument( DOCUMENT_TYPE_IMPRESS, mpDocSh ));
pModel->NewOrLoadCompleted(NEW_DOC);
diff --git a/sd/source/ui/view/viewshel.cxx b/sd/source/ui/view/viewshel.cxx
index 30b9f30637e5..15de98760b2f 100644
--- a/sd/source/ui/view/viewshel.cxx
+++ b/sd/source/ui/view/viewshel.cxx
@@ -1539,7 +1539,7 @@ bool ViewShell::RelocateToParentWindow (vcl::Window* pParentWindow)
return true;
}
-void ViewShell::SwitchViewFireFocus(css::uno::Reference< css::accessibility::XAccessible > xAcc )
+void ViewShell::SwitchViewFireFocus(const css::uno::Reference< css::accessibility::XAccessible >& xAcc )
{
if (xAcc.get())
{