summaryrefslogtreecommitdiff
path: root/sfx2
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2020-08-18 09:43:04 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2020-08-18 16:02:25 +0200
commit65ae6af9f460b1a28f3e07480347ff7f90adae38 (patch)
tree49bfeb1e25724d3b5539b7b5843d38b7531cf65f /sfx2
parentc7d1bb119d88faaafb53d65ad8907ede97d89c8c (diff)
loplugin:unusedvarsglobal
tackle some read-only vars. Mark some of them const to make it obvious they are not really used, and to make the constantparam plugin see more data. Change-Id: Ia25927745866746aa1aa9d5affd5857ad9f9ee24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100895 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sfx2')
-rw-r--r--sfx2/source/view/classificationhelper.cxx5
1 files changed, 2 insertions, 3 deletions
diff --git a/sfx2/source/view/classificationhelper.cxx b/sfx2/source/view/classificationhelper.cxx
index 097cc20b4bdb..95126d996288 100644
--- a/sfx2/source/view/classificationhelper.cxx
+++ b/sfx2/source/view/classificationhelper.cxx
@@ -624,9 +624,8 @@ const OUString& SfxClassificationHelper::GetAbbreviatedBACName(const OUString& s
OUString SfxClassificationHelper::GetBACNameForIdentifier(const OUString& sIdentifier)
{
- OUString aRet;
if (sIdentifier.isEmpty())
- return aRet;
+ return "";
for (const auto& category : m_pImpl->m_aCategories)
{
@@ -634,7 +633,7 @@ OUString SfxClassificationHelper::GetBACNameForIdentifier(const OUString& sIdent
return category.m_aName;
}
- return aRet;
+ return "";
}
OUString SfxClassificationHelper::GetHigherClass(const OUString& first, const OUString& second)