loplugin:unusedfields in sc part1

in ScNavigatorDlg::ScNavigatorDlg, we replace the assignment of nAreaId
with an assignment to nDataId instead, which is never initialized but
used, whereas nAreaId was initialized but never used.

Change-Id: I9681af7f7d515d4891c9b52d3809e88e3d5e8256
Reviewed-on: https://gerrit.libreoffice.org/39062
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 6 insertions, 9 deletions

diff --git a/sc/source/ui/dbgui/consdlg.cxx b/sc/source/ui/dbgui/consdlg.cxx
index 475137ee6fde..e45c2cb31b63 100644
--- a/sc/source/ui/dbgui/consdlg.cxx
+++ b/sc/source/ui/dbgui/consdlg.cxx
@@ -40,20 +40,17 @@ class ScAreaData
 {
 public:
     ScAreaData()
-        : bIsDbArea(false)
     {
     }
 
-    void Set( const OUString& rName, const OUString& rArea, bool bDb )
-                {
-                    aStrName  = rName;
-                    aStrArea  = rArea;
-                    bIsDbArea = bDb;
-                }
+    void Set( const OUString& rName, const OUString& rArea )
+    {
+        aStrName  = rName;
+        aStrArea  = rArea;
+    }
 
     OUString  aStrName;
     OUString  aStrArea;
-    bool  bIsDbArea;
 };
 
 ScConsolidateDlg::ScConsolidateDlg( SfxBindings* pB, SfxChildWindow* pCW, vcl::Window* pParent,
@@ -218,7 +215,7 @@ void ScConsolidateDlg::Init()
         while ( aIter.Next( aStrName, aRange ) )
         {
             OUString aStrArea(aRange.Format(ScRefFlags::ADDR_ABS_3D, pDoc, eConv));
-            pAreaData[nAt++].Set( aStrName, aStrArea, aIter.WasDBName() );
+            pAreaData[nAt++].Set( aStrName, aStrArea );
         }
     }