diff options
| author | Noel Grandin <noel@peralex.com> | 2014-03-17 09:13:09 +0200 |
|---|---|---|
| committer | Noel Grandin <noel@peralex.com> | 2014-03-17 13:30:50 +0200 |
| commit | 71c88f02a019dee180686ac9ec88d8c7c1f7f534 (patch) | |
| tree | 601702c26d9fc4fd97a88e8625e580871c5f9d01 /sc/source/ui/Accessibility | |
| parent | 236d6cd67e5024ecbe9baccc8f1db597bea4bfa9 (diff) | |
sc: prefer passing OUString by reference
Change-Id: I85e8823e872bf53182ce90576225e462edb1930a
Diffstat (limited to 'sc/source/ui/Accessibility')
| -rw-r--r-- | sc/source/ui/Accessibility/AccessibleCell.cxx | 31 |
1 files changed, 14 insertions, 17 deletions
diff --git a/sc/source/ui/Accessibility/AccessibleCell.cxx b/sc/source/ui/Accessibility/AccessibleCell.cxx index 540960ee05dc..38a437c7e2c9 100644 --- a/sc/source/ui/Accessibility/AccessibleCell.cxx +++ b/sc/source/ui/Accessibility/AccessibleCell.cxx @@ -485,29 +485,26 @@ void ScAccessibleCell::AddRelation(const ScRange& rRange, } } -static OUString ReplaceOneChar(OUString oldOUString, OUString replacedChar, OUString replaceStr) +static OUString ReplaceOneChar(const OUString& oldOUString, const OUString& replacedChar, const OUString& replaceStr) { - int iReplace = -1; - iReplace = oldOUString.lastIndexOf(replacedChar); - if (iReplace > -1) + int iReplace = oldOUString.lastIndexOf(replacedChar); + OUString aRet = oldOUString; + while(iReplace > -1) { - for(;iReplace>-1;) - { - oldOUString = oldOUString.replaceAt(iReplace,1, replaceStr); - iReplace=oldOUString.lastIndexOf(replacedChar,iReplace); - } + aRet = aRet.replaceAt(iReplace, 1, replaceStr); + iReplace = aRet.lastIndexOf(replacedChar, iReplace); } - return oldOUString; + return aRet; } -static OUString ReplaceFourChar(OUString oldOUString) +static OUString ReplaceFourChar(const OUString& oldOUString) { - oldOUString = ReplaceOneChar(oldOUString, "\\", "\\\\"); - oldOUString = ReplaceOneChar(oldOUString, ";", "\\;"); - oldOUString = ReplaceOneChar(oldOUString, "=", "\\="); - oldOUString = ReplaceOneChar(oldOUString, ",", "\\,"); - oldOUString = ReplaceOneChar(oldOUString, ":", "\\:"); - return oldOUString; + OUString aRet = ReplaceOneChar(oldOUString, "\\", "\\\\"); + aRet = ReplaceOneChar(aRet, ";", "\\;"); + aRet = ReplaceOneChar(aRet, "=", "\\="); + aRet = ReplaceOneChar(aRet, ",", "\\,"); + aRet = ReplaceOneChar(aRet, ":", "\\:"); + return aRet; } uno::Any SAL_CALL ScAccessibleCell::getExtendedAttributes() |