loplugin:flatten in l10ntools..lotuswordpro

Change-Id: Ie6de142db1987094fdf538148ac5ee33379a3e4b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127275
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 16 insertions, 16 deletions

diff --git a/l10ntools/source/xmlparse.cxx b/l10ntools/source/xmlparse.cxx
index d533d8db07ba..10f52fdcb3d7 100644
--- a/l10ntools/source/xmlparse.cxx
+++ b/l10ntools/source/xmlparse.cxx
@@ -394,28 +394,28 @@ XMLFile::XMLFile( const XMLFile& rObj )
 
 XMLFile& XMLFile::operator=(const XMLFile& rObj)
 {
-    if( this != &rObj )
-    {
-        XMLParentNode::operator=(rObj);
+    if( this == &rObj )
+        return *this;
 
-        m_aNodes_localize = rObj.m_aNodes_localize;
-        m_vOrder = rObj.m_vOrder;
+    XMLParentNode::operator=(rObj);
 
-        m_pXMLStrings.reset();
+    m_aNodes_localize = rObj.m_aNodes_localize;
+    m_vOrder = rObj.m_vOrder;
 
-        if( rObj.m_pXMLStrings )
+    m_pXMLStrings.reset();
+
+    if( rObj.m_pXMLStrings )
+    {
+        m_pXMLStrings.reset( new XMLHashMap );
+        for (auto const& pos : *rObj.m_pXMLStrings)
         {
-            m_pXMLStrings.reset( new XMLHashMap );
-            for (auto const& pos : *rObj.m_pXMLStrings)
+            LangHashMap* pElem=pos.second;
+            LangHashMap* pNewelem = new LangHashMap;
+            for (auto const& pos2 : *pElem)
             {
-                LangHashMap* pElem=pos.second;
-                LangHashMap* pNewelem = new LangHashMap;
-                for (auto const& pos2 : *pElem)
-                {
-                    (*pNewelem)[ pos2.first ] = new XMLElement( *pos2.second );
-                }
-                (*m_pXMLStrings)[ pos.first ] = pNewelem;
+                (*pNewelem)[ pos2.first ] = new XMLElement( *pos2.second );
             }
+            (*m_pXMLStrings)[ pos.first ] = pNewelem;
         }
     }
     return *this;