summaryrefslogtreecommitdiff
path: root/hwpfilter
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2013-12-19 11:12:03 +0000
committerCaolán McNamara <caolanm@redhat.com>2013-12-19 11:31:14 +0000
commit2f0a036745828dde5b2b63d4a59e5a6fd677e097 (patch)
treeac2cceb8d8111b2c8c4d232fab7ffa24c36b4cb8 /hwpfilter
parent47bda1cfc9f31d95ee88fd56aaa3235e60270922 (diff)
CID#982610 inefficient iterator usage confusing coverity
Change-Id: I79142f5f1723fa2db0e729cb0dacb201e41077bc
Diffstat (limited to 'hwpfilter')
-rw-r--r--hwpfilter/source/hwpreader.cxx10
1 files changed, 1 insertions, 9 deletions
diff --git a/hwpfilter/source/hwpreader.cxx b/hwpfilter/source/hwpreader.cxx
index 15aa3bfcb330..8347fd4503e2 100644
--- a/hwpfilter/source/hwpreader.cxx
+++ b/hwpfilter/source/hwpreader.cxx
@@ -3444,16 +3444,8 @@ void HwpReader::makeTable(TxtBox * hbox)
// ----------- cell ---------------- //
int j = -1, k = -1;
- for (int i = 0 ; i < static_cast<int>(tbl->cells.size()); i++)
+ for (std::list<TCell*>::iterator it = tbl->cells.begin(), aEnd = tbl->cells.end(); it != aEnd; ++it)
{
- std::list<TCell*>::iterator it = tbl->cells.begin();
-
- for( int ii = 0; it != tbl->cells.end(); ++it, ii++ )
- {
- if( ii == i )
- break;
- }
-
TCell *tcell = *it;
if( tcell->nRowIndex > j )
{