diff options
author | Noel Grandin <noel@peralex.com> | 2016-04-12 11:25:03 +0200 |
---|---|---|
committer | Noel Grandin <noel@peralex.com> | 2016-04-12 11:25:18 +0200 |
commit | 6a8873c874db41e8818a74eb6bf2561dfdb296db (patch) | |
tree | a34620db09e026d3e3c2a7da7ea3c2d8e9cd5c12 /filter | |
parent | dbd1f4b75a22150af80a6fbd8de1a38d5dc4b4c3 (diff) |
clang-tidy performance-unnecessary-value-param in filter
Change-Id: I6818f6c9593bfe7105cc194fcf6f69131046e4f3
Diffstat (limited to 'filter')
21 files changed, 38 insertions, 38 deletions
diff --git a/filter/source/flash/swfexporter.cxx b/filter/source/flash/swfexporter.cxx index 075bd7fe5618..4aa4845b0fca 100644 --- a/filter/source/flash/swfexporter.cxx +++ b/filter/source/flash/swfexporter.cxx @@ -129,7 +129,7 @@ const sal_uInt16 cBackgroundObjectsDepth = 3; const sal_uInt16 cPageObjectsDepth = 4; const sal_uInt16 cWaitButtonDepth = 10; -bool FlashExporter::exportAll( Reference< XComponent > xDoc, Reference< XOutputStream > &xOutputStream, Reference< XStatusIndicator> &xStatusIndicator ) +bool FlashExporter::exportAll( const Reference< XComponent >& xDoc, Reference< XOutputStream > &xOutputStream, Reference< XStatusIndicator> &xStatusIndicator ) { Reference< XServiceInfo > xDocServInfo( xDoc, UNO_QUERY ); if( xDocServInfo.is() ) @@ -272,7 +272,7 @@ bool FlashExporter::exportAll( Reference< XComponent > xDoc, Reference< XOutputS } -bool FlashExporter::exportSlides( Reference< XDrawPage > xDrawPage, Reference< XOutputStream > &xOutputStream, sal_uInt16 /* nPage */ ) +bool FlashExporter::exportSlides( const Reference< XDrawPage >& xDrawPage, Reference< XOutputStream > &xOutputStream, sal_uInt16 /* nPage */ ) { Reference< XPropertySet > xPropSet( xDrawPage, UNO_QUERY ); if( !xDrawPage.is() || !xPropSet.is() ) @@ -308,7 +308,7 @@ bool FlashExporter::exportSlides( Reference< XDrawPage > xDrawPage, Reference< X return true; } -sal_uInt16 FlashExporter::exportBackgrounds( Reference< XDrawPage > xDrawPage, Reference< XOutputStream > &xOutputStream, sal_uInt16 nPage, bool bExportObjects ) +sal_uInt16 FlashExporter::exportBackgrounds( const Reference< XDrawPage >& xDrawPage, Reference< XOutputStream > &xOutputStream, sal_uInt16 nPage, bool bExportObjects ) { Reference< XPropertySet > xPropSet( xDrawPage, UNO_QUERY ); if( !xDrawPage.is() || !xPropSet.is() ) diff --git a/filter/source/flash/swfexporter.hxx b/filter/source/flash/swfexporter.hxx index b369312759fd..5bf4f512062b 100644 --- a/filter/source/flash/swfexporter.hxx +++ b/filter/source/flash/swfexporter.hxx @@ -128,9 +128,9 @@ public: void Flush(); - bool exportAll( css::uno::Reference< css::lang::XComponent > xDoc, css::uno::Reference< css::io::XOutputStream > &xOutputStream, css::uno::Reference< css::task::XStatusIndicator> &xStatusIndicator ); - bool exportSlides( css::uno::Reference< css::drawing::XDrawPage > xDrawPage, css::uno::Reference< css::io::XOutputStream > &xOutputStream, sal_uInt16 nPage); - sal_uInt16 exportBackgrounds( css::uno::Reference< css::drawing::XDrawPage > xDrawPage, css::uno::Reference< css::io::XOutputStream > &xOutputStream, sal_uInt16 nPage, bool bExportObjects ); + bool exportAll( const css::uno::Reference< css::lang::XComponent >& xDoc, css::uno::Reference< css::io::XOutputStream > &xOutputStream, css::uno::Reference< css::task::XStatusIndicator> &xStatusIndicator ); + bool exportSlides( const css::uno::Reference< css::drawing::XDrawPage >& xDrawPage, css::uno::Reference< css::io::XOutputStream > &xOutputStream, sal_uInt16 nPage); + sal_uInt16 exportBackgrounds( const css::uno::Reference< css::drawing::XDrawPage >& xDrawPage, css::uno::Reference< css::io::XOutputStream > &xOutputStream, sal_uInt16 nPage, bool bExportObjects ); sal_uInt16 exportBackgrounds( css::uno::Reference< css::drawing::XDrawPage > xDrawPage, sal_uInt16 nPage, bool bExportObjects ); ChecksumCache gMasterCache; diff --git a/filter/source/flash/swffilter.cxx b/filter/source/flash/swffilter.cxx index 0976193e666b..3fad7e58ea88 100644 --- a/filter/source/flash/swffilter.cxx +++ b/filter/source/flash/swffilter.cxx @@ -186,7 +186,7 @@ FlashExportFilter::FlashExportFilter(const Reference< XComponentContext > &rxCon { } -OUString exportBackground(FlashExporter &aFlashExporter, Reference< XDrawPage > xDrawPage, const OUString& sPath, sal_uInt32 nPage, const char* suffix) +OUString exportBackground(FlashExporter &aFlashExporter, const Reference< XDrawPage >& xDrawPage, const OUString& sPath, sal_uInt32 nPage, const char* suffix) { OUString filename = STR("slide") + VAL(nPage+1) + STR(suffix) + STR(".swf"); OUString fullpath = sPath + STR("/") + filename; diff --git a/filter/source/msfilter/escherex.cxx b/filter/source/msfilter/escherex.cxx index b51989eda217..cf6ce7a4ced8 100644 --- a/filter/source/msfilter/escherex.cxx +++ b/filter/source/msfilter/escherex.cxx @@ -1124,7 +1124,7 @@ void EscherPropertyContainer::CreateLineProperties( } } -static Size lcl_SizeToEmu(Size aPrefSize, MapMode aPrefMapMode) +static Size lcl_SizeToEmu(Size aPrefSize, const MapMode& aPrefMapMode) { Size aRetSize; if (aPrefMapMode == MAP_PIXEL) diff --git a/filter/source/msfilter/msdffimp.cxx b/filter/source/msfilter/msdffimp.cxx index c8fd4dce63b3..29ae6d8cb76a 100644 --- a/filter/source/msfilter/msdffimp.cxx +++ b/filter/source/msfilter/msdffimp.cxx @@ -3691,7 +3691,7 @@ OUString SvxMSDffManager::MSDFFReadZString(SvStream& rIn, return comphelper::string::stripEnd(sBuf, 0); } -static Size lcl_GetPrefSize(const Graphic& rGraf, MapMode aWanted) +static Size lcl_GetPrefSize(const Graphic& rGraf, const MapMode& aWanted) { MapMode aPrefMapMode(rGraf.GetPrefMapMode()); if (aPrefMapMode == aWanted) diff --git a/filter/source/msfilter/svdfppt.cxx b/filter/source/msfilter/svdfppt.cxx index ebea1c297280..af3d57fde104 100644 --- a/filter/source/msfilter/svdfppt.cxx +++ b/filter/source/msfilter/svdfppt.cxx @@ -7343,7 +7343,7 @@ void GetLinePositions( const SdrObject* pObj, const std::set< sal_Int32 >& rRows } } -void CreateTableRows( Reference< XTableRows > xTableRows, const std::set< sal_Int32 >& rRows, sal_Int32 nTableBottom ) +void CreateTableRows( const Reference< XTableRows >& xTableRows, const std::set< sal_Int32 >& rRows, sal_Int32 nTableBottom ) { if ( rRows.size() > 1 ) xTableRows->insertByIndex( 0, rRows.size() - 1 ); @@ -7367,7 +7367,7 @@ void CreateTableRows( Reference< XTableRows > xTableRows, const std::set< sal_In } } -void CreateTableColumns( Reference< XTableColumns > xTableColumns, const std::set< sal_Int32 >& rColumns, sal_Int32 nTableRight ) +void CreateTableColumns( const Reference< XTableColumns >& xTableColumns, const std::set< sal_Int32 >& rColumns, sal_Int32 nTableRight ) { if ( rColumns.size() > 1 ) xTableColumns->insertByIndex( 0, rColumns.size() - 1 ); diff --git a/filter/source/placeware/exporter.cxx b/filter/source/placeware/exporter.cxx index 6deaec9bfb8f..fd6e84ea7877 100644 --- a/filter/source/placeware/exporter.cxx +++ b/filter/source/placeware/exporter.cxx @@ -179,7 +179,7 @@ static OString convertString( const OUString& aInput ) return aRet; } -static void createSlideFile( Reference< XComponent > xDoc, PlacewareZipFile& rZipFile, const OUString& rURL, vector< PageEntry* >& rPageEntries ) throw( css::uno::Exception, std::exception ) +static void createSlideFile( const Reference< XComponent >& xDoc, PlacewareZipFile& rZipFile, const OUString& rURL, vector< PageEntry* >& rPageEntries ) throw( css::uno::Exception, std::exception ) { OString aInfo; @@ -282,8 +282,8 @@ static void createSlideFile( Reference< XComponent > xDoc, PlacewareZipFile& rZi //#define PLACEWARE_DEBUG 1 -bool PlaceWareExporter::doExport( Reference< XComponent > xDoc, Reference < XOutputStream > xOutputStream, - const OUString& rURL, Reference < XInterface > /* xHandler */, Reference < XStatusIndicator >& xStatusIndicator ) +bool PlaceWareExporter::doExport( const Reference< XComponent >& xDoc, Reference < XOutputStream > xOutputStream, + const OUString& rURL, const Reference < XInterface >& /* xHandler */, Reference < XStatusIndicator >& xStatusIndicator ) { bool bRet = false; diff --git a/filter/source/placeware/exporter.hxx b/filter/source/placeware/exporter.hxx index c70bd7e5e8f8..a855a977ddf3 100644 --- a/filter/source/placeware/exporter.hxx +++ b/filter/source/placeware/exporter.hxx @@ -35,10 +35,10 @@ public: explicit PlaceWareExporter( const css::uno::Reference< css::uno::XComponentContext >& rxContext ); ~PlaceWareExporter(); - bool doExport( css::uno::Reference< css::lang::XComponent > xDoc, + bool doExport( const css::uno::Reference< css::lang::XComponent >& xDoc, css::uno::Reference < css::io::XOutputStream > xOutputStream, const OUString& rURL, - css::uno::Reference < css::uno::XInterface > xHandler, + const css::uno::Reference < css::uno::XInterface >& xHandler, css::uno::Reference < css::task::XStatusIndicator >& rxStatusIndicator ); private: diff --git a/filter/source/svg/svgexport.cxx b/filter/source/svg/svgexport.cxx index 17a88281d3d5..c2a53540a8e8 100644 --- a/filter/source/svg/svgexport.cxx +++ b/filter/source/svg/svgexport.cxx @@ -118,7 +118,7 @@ public: { pSVGExport->AddAttribute( XML_NAMESPACE_NONE, "class", getClassName() ); } - void insertMasterPage( Reference< XDrawPage> xMasterPage ) + void insertMasterPage( const Reference< XDrawPage>& xMasterPage ) { mMasterPageSet.insert( xMasterPage ); } @@ -907,7 +907,7 @@ template< typename TextFieldType > OUString implGenerateFieldId( std::vector< TextField* > & aFieldSet, const TextFieldType & aField, const OUString & sOOOElemField, - Reference< XDrawPage > xMasterPage ) + const Reference< XDrawPage >& xMasterPage ) { bool bFound = false; sal_Int32 i; diff --git a/filter/source/svg/svgfilter.cxx b/filter/source/svg/svgfilter.cxx index 503510a92a5c..2c5769ebf15f 100644 --- a/filter/source/svg/svgfilter.cxx +++ b/filter/source/svg/svgfilter.cxx @@ -304,7 +304,7 @@ void SAL_CALL SVGFilter::setTargetDocument( const Reference< XComponent >& xDoc mxDstDoc = xDoc; } -bool SVGFilter::isStreamGZip(uno::Reference<io::XInputStream> xInput) +bool SVGFilter::isStreamGZip(const uno::Reference<io::XInputStream>& xInput) { uno::Reference<io::XSeekable> xSeek(xInput, uno::UNO_QUERY); if(xSeek.is()) @@ -321,7 +321,7 @@ bool SVGFilter::isStreamGZip(uno::Reference<io::XInputStream> xInput) return false; } -bool SVGFilter::isStreamSvg(uno::Reference<io::XInputStream> xInput) +bool SVGFilter::isStreamSvg(const uno::Reference<io::XInputStream>& xInput) { uno::Reference<io::XSeekable> xSeek(xInput, uno::UNO_QUERY); if(xSeek.is()) diff --git a/filter/source/svg/svgfilter.hxx b/filter/source/svg/svgfilter.hxx index 83417a62fa38..0d4008c14707 100644 --- a/filter/source/svg/svgfilter.hxx +++ b/filter/source/svg/svgfilter.hxx @@ -289,8 +289,8 @@ private: const Reference< XPropertySetInfo > & rxPropSetInfo ); DECL_LINK_TYPED( CalcFieldHdl, EditFieldInfo*, void ); - static bool isStreamGZip(css::uno::Reference<css::io::XInputStream> xInput); - static bool isStreamSvg(css::uno::Reference<css::io::XInputStream> xInput); + static bool isStreamGZip(const css::uno::Reference<css::io::XInputStream>& xInput); + static bool isStreamSvg(const css::uno::Reference<css::io::XInputStream>& xInput); protected: diff --git a/filter/source/xsltdialog/typedetectionexport.cxx b/filter/source/xsltdialog/typedetectionexport.cxx index bb307e14910a..53446dad77bf 100644 --- a/filter/source/xsltdialog/typedetectionexport.cxx +++ b/filter/source/xsltdialog/typedetectionexport.cxx @@ -72,7 +72,7 @@ static OUString createRelativeURL( const OUString& rFilterName, const OUString& } } -void TypeDetectionExporter::doExport( Reference< XOutputStream > xOS, const XMLFilterVector& rFilters ) +void TypeDetectionExporter::doExport( const Reference< XOutputStream >& xOS, const XMLFilterVector& rFilters ) { try { @@ -218,7 +218,7 @@ void TypeDetectionExporter::doExport( Reference< XOutputStream > xOS, const XML } } -void TypeDetectionExporter::addProperty( Reference< XWriter > xHandler, const OUString& rName, const OUString& rValue ) +void TypeDetectionExporter::addProperty( const Reference< XWriter >& xHandler, const OUString& rName, const OUString& rValue ) { try { @@ -248,7 +248,7 @@ void TypeDetectionExporter::addProperty( Reference< XWriter > xHandler, const OU } } -void TypeDetectionExporter::addLocaleProperty( Reference< XWriter > xHandler, const OUString& rName, const OUString& rValue ) +void TypeDetectionExporter::addLocaleProperty( const Reference< XWriter >& xHandler, const OUString& rName, const OUString& rValue ) { try { diff --git a/filter/source/xsltdialog/typedetectionexport.hxx b/filter/source/xsltdialog/typedetectionexport.hxx index dcb0ca068968..7081a1441f94 100644 --- a/filter/source/xsltdialog/typedetectionexport.hxx +++ b/filter/source/xsltdialog/typedetectionexport.hxx @@ -30,11 +30,11 @@ class TypeDetectionExporter public: explicit TypeDetectionExporter( css::uno::Reference< css::uno::XComponentContext >& mxContext ); - void doExport(css::uno::Reference < css::io::XOutputStream > xOS, const XMLFilterVector& rFilters ); + void doExport(const css::uno::Reference < css::io::XOutputStream >& xOS, const XMLFilterVector& rFilters ); private: - static void addProperty( css::uno::Reference< css::xml::sax::XWriter > xWriter, const OUString& rName, const OUString& rValue ); - static void addLocaleProperty( css::uno::Reference< css::xml::sax::XWriter > xWriter, const OUString& rName, const OUString& rValue ); + static void addProperty( const css::uno::Reference< css::xml::sax::XWriter >& xWriter, const OUString& rName, const OUString& rValue ); + static void addLocaleProperty( const css::uno::Reference< css::xml::sax::XWriter >& xWriter, const OUString& rName, const OUString& rValue ); css::uno::Reference< css::uno::XComponentContext > mxContext; }; diff --git a/filter/source/xsltdialog/typedetectionimport.cxx b/filter/source/xsltdialog/typedetectionimport.cxx index 0865121dd0ec..fbe10b594855 100644 --- a/filter/source/xsltdialog/typedetectionimport.cxx +++ b/filter/source/xsltdialog/typedetectionimport.cxx @@ -47,7 +47,7 @@ TypeDetectionImporter::~TypeDetectionImporter() { } -void TypeDetectionImporter::doImport( const Reference< XComponentContext >& rxContext, Reference< XInputStream > xIS, XMLFilterVector& rFilters ) +void TypeDetectionImporter::doImport( const Reference< XComponentContext >& rxContext, const Reference< XInputStream >& xIS, XMLFilterVector& rFilters ) { try { diff --git a/filter/source/xsltdialog/typedetectionimport.hxx b/filter/source/xsltdialog/typedetectionimport.hxx index 9d2be2d2aaf4..ccdcd6d054c3 100644 --- a/filter/source/xsltdialog/typedetectionimport.hxx +++ b/filter/source/xsltdialog/typedetectionimport.hxx @@ -64,7 +64,7 @@ public: TypeDetectionImporter(); virtual ~TypeDetectionImporter(); - static void doImport( const css::uno::Reference< css::uno::XComponentContext >& rxContext, css::uno::Reference < css::io::XInputStream > xOS, XMLFilterVector& rFilters ); + static void doImport( const css::uno::Reference< css::uno::XComponentContext >& rxContext, const css::uno::Reference < css::io::XInputStream >& xOS, XMLFilterVector& rFilters ); virtual void SAL_CALL startDocument( ) throw(css::xml::sax::SAXException, css::uno::RuntimeException, std::exception) override; diff --git a/filter/source/xsltdialog/xmlfiltercommon.hxx b/filter/source/xsltdialog/xmlfiltercommon.hxx index 7a73ba8fc511..952cd1e9cc20 100644 --- a/filter/source/xsltdialog/xmlfiltercommon.hxx +++ b/filter/source/xsltdialog/xmlfiltercommon.hxx @@ -32,7 +32,7 @@ extern OUString string_encode( const OUString & rText ); extern OUString string_decode( const OUString & rText ); -bool copyStreams( css::uno::Reference< css::io::XInputStream > xIS, css::uno::Reference< css::io::XOutputStream > xOS ); +bool copyStreams( const css::uno::Reference< css::io::XInputStream >& xIS, const css::uno::Reference< css::io::XOutputStream >& xOS ); bool createDirectory( OUString& rURL ); diff --git a/filter/source/xsltdialog/xmlfilterjar.cxx b/filter/source/xsltdialog/xmlfilterjar.cxx index f5a44eb616b5..effc2fb45131 100644 --- a/filter/source/xsltdialog/xmlfilterjar.cxx +++ b/filter/source/xsltdialog/xmlfilterjar.cxx @@ -303,7 +303,7 @@ void XMLFilterJarHelper::openPackage( const OUString& rPackageURL, XMLFilterVect } } -bool XMLFilterJarHelper::copyFiles( Reference< XHierarchicalNameAccess > xIfc, filter_info_impl* pFilter ) +bool XMLFilterJarHelper::copyFiles( const Reference< XHierarchicalNameAccess >& xIfc, filter_info_impl* pFilter ) { bool bOk = copyFile( xIfc, pFilter->maExportXSLT, sXSLTPath ); @@ -316,7 +316,7 @@ bool XMLFilterJarHelper::copyFiles( Reference< XHierarchicalNameAccess > xIfc, f return bOk; } -bool XMLFilterJarHelper::copyFile( Reference< XHierarchicalNameAccess > xIfc, OUString& rURL, const OUString& rTargetURL ) +bool XMLFilterJarHelper::copyFile( const Reference< XHierarchicalNameAccess >& xIfc, OUString& rURL, const OUString& rTargetURL ) { if( !rURL.matchIgnoreAsciiCase( sVndSunStarPackage ) ) return true; diff --git a/filter/source/xsltdialog/xmlfilterjar.hxx b/filter/source/xsltdialog/xmlfilterjar.hxx index 0da990ebb94a..4a57ce8b961a 100644 --- a/filter/source/xsltdialog/xmlfilterjar.hxx +++ b/filter/source/xsltdialog/xmlfilterjar.hxx @@ -40,8 +40,8 @@ public: private: void addFile( css::uno::Reference< css::uno::XInterface > xRootFolder, css::uno::Reference< css::lang::XSingleServiceFactory > xFactory, const OUString& rSourceFile ) throw( css::uno::Exception, std::exception ); - bool copyFile( css::uno::Reference< css::container::XHierarchicalNameAccess > xIfc, OUString& rURL, const OUString& rTargetURL ); - bool copyFiles( css::uno::Reference< css::container::XHierarchicalNameAccess > xIfc, filter_info_impl* pFilter ); + bool copyFile( const css::uno::Reference< css::container::XHierarchicalNameAccess >& xIfc, OUString& rURL, const OUString& rTargetURL ); + bool copyFiles( const css::uno::Reference< css::container::XHierarchicalNameAccess >& xIfc, filter_info_impl* pFilter ); css::uno::Reference< css::uno::XComponentContext > mxContext; diff --git a/filter/source/xsltdialog/xmlfiltersettingsdialog.cxx b/filter/source/xsltdialog/xmlfiltersettingsdialog.cxx index 60e084799d8e..8583483df7b1 100644 --- a/filter/source/xsltdialog/xmlfiltersettingsdialog.cxx +++ b/filter/source/xsltdialog/xmlfiltersettingsdialog.cxx @@ -1617,7 +1617,7 @@ OUString string_decode( const OUString & rText ) return Uri::decode( rText, rtl_UriDecodeWithCharset, RTL_TEXTENCODING_UTF8 ); } -bool copyStreams( Reference< XInputStream > xIS, Reference< XOutputStream > xOS ) +bool copyStreams( const Reference< XInputStream >& xIS, const Reference< XOutputStream >& xOS ) { try { diff --git a/filter/source/xsltdialog/xmlfiltertestdialog.cxx b/filter/source/xsltdialog/xmlfiltertestdialog.cxx index 613ada3b798f..826244942ca5 100644 --- a/filter/source/xsltdialog/xmlfiltertestdialog.cxx +++ b/filter/source/xsltdialog/xmlfiltertestdialog.cxx @@ -441,7 +441,7 @@ void XMLFilterTestDialog::onExportCurrentDocument() doExport( getFrontMostDocument( m_pFilterInfo->maDocumentService ) ); } -void XMLFilterTestDialog::doExport( Reference< XComponent > xComp ) +void XMLFilterTestDialog::doExport( const Reference< XComponent >& xComp ) { try { diff --git a/filter/source/xsltdialog/xmlfiltertestdialog.hxx b/filter/source/xsltdialog/xmlfiltertestdialog.hxx index 09998d0d58ac..39261c4d07d8 100644 --- a/filter/source/xsltdialog/xmlfiltertestdialog.hxx +++ b/filter/source/xsltdialog/xmlfiltertestdialog.hxx @@ -55,7 +55,7 @@ private: css::uno::Reference< css::lang::XComponent > getFrontMostDocument( const OUString& rServiceName ); void import( const OUString& rURL ); static void displayXMLFile( const OUString& rURL ); - void doExport( css::uno::Reference< css::lang::XComponent > xComp ); + void doExport( const css::uno::Reference< css::lang::XComponent >& xComp ); private: css::uno::Reference< css::uno::XComponentContext > mxContext; |