Clean up SvxChartColorTable

* nNextElementNumber is unused since d57dfa29c2ba47293eb12a853cdccf4196565ef7
  "Improvement of adding and removing color charts".

* There appears to be no compelling reason to store sDefaultNamePre-/Postfix as
  members (but which are not even copied by the copy ctor).  Just compute them
  whenever they are needed in getDefaultName (which is understood to not be a
  hot code path).

* With those changes, the user-provided default and copy ctor can be left
  implicitly-declared, which avoids -Wdeprecated-copy (because the copy
  assignment op was implicitly-declared while the copy ctor was not) with GCC
  trunk towards GCC 9.

Change-Id: I2bfa5f19c967e24407bf5b79adaf171200822f45
Reviewed-on: https://gerrit.libreoffice.org/56666
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

1 files changed, 0 insertions, 6 deletions

diff --git a/cui/source/options/cfgchart.hxx b/cui/source/options/cfgchart.hxx
index b5e783d8ad5d..eba4a7fda42e 100644
--- a/cui/source/options/cfgchart.hxx
+++ b/cui/source/options/cfgchart.hxx
@@ -30,14 +30,8 @@ class SvxChartColorTable
 {
 private:
     std::vector< XColorEntry >     m_aColorEntries;
-    int                              nNextElementNumber;
-    OUString                         sDefaultNamePrefix;
-    OUString                         sDefaultNamePostfix;
 
 public:
-    SvxChartColorTable();
-    explicit SvxChartColorTable( const SvxChartColorTable & _rSource );
-
     // accessors
     size_t size() const;
     const XColorEntry & operator[]( size_t _nIndex ) const;