diff options
| author | Mike Kaganski <mike.kaganski@collabora.com> | 2017-12-17 23:00:24 +0300 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-12-18 07:36:32 +0100 |
| commit | 4e144751f12a06e358e4f7efa7c8f13954e6cfd7 (patch) | |
| tree | c6df66d58d02ecaf5caa437a944665fe83959402 /basic | |
| parent | 39c618caf5aa19da95285bec6cab7108bee3984c (diff) | |
loplugin:unusedindex
Change-Id: I256a807dd2a4c81126b5a76f3d472e31b8224146
Reviewed-on: https://gerrit.libreoffice.org/46652
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'basic')
| -rw-r--r-- | basic/source/comp/exprtree.cxx | 4 | ||||
| -rw-r--r-- | basic/source/comp/token.cxx | 5 | ||||
| -rw-r--r-- | basic/source/uno/dlgcont.cxx | 6 |
3 files changed, 5 insertions, 10 deletions
diff --git a/basic/source/comp/exprtree.cxx b/basic/source/comp/exprtree.cxx index 43fac26a6e22..6c960170870b 100644 --- a/basic/source/comp/exprtree.cxx +++ b/basic/source/comp/exprtree.cxx @@ -138,10 +138,8 @@ static SbiSymDef* AddSym ( SbiToken eTok, SbiSymPool& rPool, SbiExprType eCurExp if( pPar ) { // generate dummy parameters - sal_Int32 n = 1; - for( short i = 0; i < pPar->GetSize(); i++ ) + for( sal_Int32 n = 1; n <= pPar->GetSize(); n++ ) { - n += 1; OUStringBuffer aPar("PAR"); aPar.append(n); pProc->GetParams().AddSym( aPar.makeStringAndClear() ); diff --git a/basic/source/comp/token.cxx b/basic/source/comp/token.cxx index b5e2babb3181..371c9bb4269f 100644 --- a/basic/source/comp/token.cxx +++ b/basic/source/comp/token.cxx @@ -195,9 +195,8 @@ TokenLabelInfo::TokenLabelInfo() // Token accepted as label by VBA static const SbiToken eLabelToken[] = { ACCESS, ALIAS, APPEND, BASE, BINARY, CLASSMODULE, COMPARE, COMPATIBLE, DEFERR, ERROR_, BASIC_EXPLICIT, LIB, LINE, LPRINT, NAME, - TOBJECT, OUTPUT, PROPERTY, RANDOM, READ, STEP, STOP, TEXT, VBASUPPORT, NIL }; - SbiToken eTok; - for( const SbiToken* pTok = eLabelToken ; (eTok = *pTok) != NIL ; ++pTok ) + TOBJECT, OUTPUT, PROPERTY, RANDOM, READ, STEP, STOP, TEXT, VBASUPPORT }; + for( SbiToken eTok : eLabelToken ) { m_pTokenCanBeLabelTab[eTok] = true; } diff --git a/basic/source/uno/dlgcont.cxx b/basic/source/uno/dlgcont.cxx index 1faac70c0fe1..5e3fd9c7995d 100644 --- a/basic/source/uno/dlgcont.cxx +++ b/basic/source/uno/dlgcont.cxx @@ -243,12 +243,10 @@ void SfxDialogLibraryContainer::storeLibrariesToStorage( const uno::Reference< e // Export the images to the storage Reference< document::XGraphicObjectResolver > xGraphicResolver = document::GraphicObjectResolver::createWithStorage( mxContext, xStorage ); - std::vector< OUString >::iterator it = vEmbeddedImageURLs.begin(); - std::vector< OUString >::iterator it_end = vEmbeddedImageURLs.end(); if ( xGraphicResolver.is() ) { - for ( sal_Int32 count = 0; it != it_end; ++it, ++count ) - xGraphicResolver->resolveGraphicObjectURL( *it ); + for ( const OUString& rURL : vEmbeddedImageURLs ) + xGraphicResolver->resolveGraphicObjectURL( rURL ); } } } |