summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2020-09-13 17:02:35 +0100
committerCaolán McNamara <caolanm@redhat.com>2020-09-13 22:12:32 +0200
commitbee46dbfd9986f324f20852987c05ac4339d4d25 (patch)
tree232fed1ed1b352f09cd2ef342d5334e369299df7
parent399609c352b3f354e6857ae1beee6283018516e2 (diff)
RangeNameBufferWK3 always dereferences its arg
Change-Id: I40c7c73d8d8fa2f9126f5895f8a6ed67a72bdf6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102592 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
-rw-r--r--sc/source/filter/inc/namebuff.hxx2
-rw-r--r--sc/source/filter/lotus/lotus.cxx2
-rw-r--r--sc/source/filter/lotus/tool.cxx4
3 files changed, 4 insertions, 4 deletions
diff --git a/sc/source/filter/inc/namebuff.hxx b/sc/source/filter/inc/namebuff.hxx
index 9f3c66bfb1dd..b56fee1d169e 100644
--- a/sc/source/filter/inc/namebuff.hxx
+++ b/sc/source/filter/inc/namebuff.hxx
@@ -97,7 +97,7 @@ private:
std::vector<Entry> maEntries;
public:
- RangeNameBufferWK3(const ScDocument* pDoc);
+ RangeNameBufferWK3(const ScDocument& rDoc);
~RangeNameBufferWK3();
void Add( const ScDocument* pDoc, const OUString& rName, const ScComplexRefData& rCRD );
inline void Add( const ScDocument* pDoc, const OUString& rName, const ScRange& aScRange );
diff --git a/sc/source/filter/lotus/lotus.cxx b/sc/source/filter/lotus/lotus.cxx
index b900c22a58b4..cbdb43e6be33 100644
--- a/sc/source/filter/lotus/lotus.cxx
+++ b/sc/source/filter/lotus/lotus.cxx
@@ -94,7 +94,7 @@ LotusContext::LotusContext(ScDocument* pDocP, rtl_TextEncoding eQ)
, maRangeNames()
, eFirstType( Lotus123Typ::X)
, eActType( Lotus123Typ::X)
- , pRngNmBffWK3( new RangeNameBufferWK3(pDocP) )
+ , pRngNmBffWK3( new RangeNameBufferWK3(*pDocP) )
, maAttrTable( *this )
{
}
diff --git a/sc/source/filter/lotus/tool.cxx b/sc/source/filter/lotus/tool.cxx
index 891eaaa556e0..dd868ee98996 100644
--- a/sc/source/filter/lotus/tool.cxx
+++ b/sc/source/filter/lotus/tool.cxx
@@ -426,8 +426,8 @@ void LotusRangeList::Append( const ScDocument* pDoc, std::unique_ptr<LotusRange>
nIdCnt++;
}
-RangeNameBufferWK3::RangeNameBufferWK3(const ScDocument* pDoc)
- : pScTokenArray( new ScTokenArray(*pDoc) )
+RangeNameBufferWK3::RangeNameBufferWK3(const ScDocument& rDoc)
+ : pScTokenArray( new ScTokenArray(rDoc) )
{
nIntCount = 1;
}