diff options
author | Caolán McNamara <caolanm@redhat.com> | 2022-05-23 12:23:22 +0100 |
---|---|---|
committer | Caolán McNamara <caolanm@redhat.com> | 2022-05-23 20:12:10 +0200 |
commit | 97d90a9da36965f4f50293d50c8b2e5e043d3d9a (patch) | |
tree | de14c9f4e426519562856ee0b0d5677c633630ea | |
parent | 2106dff67921ba9d8555bee285f55a4157662d33 (diff) |
gtk: fix leak in treeview tooltip
Change-Id: Ib268729abf501da7e9f217ac3c3700cd853dfd43
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134815
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
-rw-r--r-- | vcl/unx/gtk3/gtkinst.cxx | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx index bc2fbc8a5c1f..481bb8b573f7 100644 --- a/vcl/unx/gtk3/gtkinst.cxx +++ b/vcl/unx/gtk3/gtkinst.cxx @@ -14077,12 +14077,13 @@ private: return false; #endif OUString aTooltip = pThis->signal_query_tooltip(GtkInstanceTreeIter(iter)); - if (aTooltip.isEmpty()) - return false; - gtk_tooltip_set_text(tooltip, OUStringToOString(aTooltip, RTL_TEXTENCODING_UTF8).getStr()); - gtk_tree_view_set_tooltip_row(pTreeView, tooltip, pPath); + if (!aTooltip.isEmpty()) + { + gtk_tooltip_set_text(tooltip, OUStringToOString(aTooltip, RTL_TEXTENCODING_UTF8).getStr()); + gtk_tree_view_set_tooltip_row(pTreeView, tooltip, pPath); + } gtk_tree_path_free(pPath); - return true; + return !aTooltip.isEmpty(); } void last_child(GtkTreeModel* pModel, GtkTreeIter* result, GtkTreeIter* pParent, int nChildren) const |