loplugin:moveparam in ucb

Change-Id: I61a7910f3ef15b251b1763b7c56848ccbb22fe91
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123352
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

11 files changed, 42 insertions, 42 deletions

diff --git a/ucb/qa/cppunit/webdav/webdav_propfindcache.cxx b/ucb/qa/cppunit/webdav/webdav_propfindcache.cxx
index 29ccf8a462be..03ccdbe7aae7 100644
--- a/ucb/qa/cppunit/webdav/webdav_propfindcache.cxx
+++ b/ucb/qa/cppunit/webdav/webdav_propfindcache.cxx
@@ -78,7 +78,7 @@ namespace
         std::vector< DAVResourceInfo > aProps { aSingleInfo };
         std::vector< DAVResourceInfo > aRetProp;
 
-        aPropsNames.setPropertiesNames( aProps );
+        aPropsNames.setPropertiesNames( std::vector(aProps) );
         aRetProp = aPropsNames.getPropertiesNames();
         CPPUNIT_ASSERT_EQUAL( true, ( aProps == aRetProp ) );
 
@@ -112,7 +112,7 @@ namespace
         std::vector< DAVResourceInfo > aProps { aSingleInfo };
 
         // add the cache an element
-        aPropsNames.setPropertiesNames( aProps );
+        aPropsNames.setPropertiesNames( std::vector(aProps) );
         PropCache.addCachePropertyNames( aPropsNames );
 
         PropertyNames aRetPropsNames;
diff --git a/ucb/source/ucp/cmis/cmis_repo_content.cxx b/ucb/source/ucp/cmis/cmis_repo_content.cxx
index fc5472bafce2..c55b670526b8 100644
--- a/ucb/source/ucp/cmis/cmis_repo_content.cxx
+++ b/ucb/source/ucp/cmis/cmis_repo_content.cxx
@@ -50,11 +50,11 @@ namespace cmis
 {
     RepoContent::RepoContent( const uno::Reference< uno::XComponentContext >& rxContext,
         ContentProvider *pProvider, const uno::Reference< ucb::XContentIdentifier >& Identifier,
-        std::vector< libcmis::RepositoryPtr > const & aRepos )
+        std::vector< libcmis::RepositoryPtr > && aRepos )
         : ContentImplHelper( rxContext, pProvider, Identifier ),
         m_pProvider( pProvider ),
         m_aURL( Identifier->getContentIdentifier( ) ),
-        m_aRepositories( aRepos )
+        m_aRepositories( std::move(aRepos) )
     {
         // Split the URL into bits
         OUString sURL = m_xIdentifier->getContentIdentifier( );
@@ -399,7 +399,7 @@ namespace cmis
                 aUrl.setObjectPath( STD_TO_OUSTR( rRepo->getId( ) ) );
 
                 uno::Reference< ucb::XContentIdentifier > xId = new ucbhelper::ContentIdentifier( aUrl.asString( ) );
-                uno::Reference< ucb::XContent > xContent = new RepoContent( m_xContext, m_pProvider, xId, m_aRepositories );
+                uno::Reference< ucb::XContent > xContent = new RepoContent( m_xContext, m_pProvider, xId, std::vector(m_aRepositories) );
 
                 result.push_back( xContent );
             }
diff --git a/ucb/source/ucp/cmis/cmis_repo_content.hxx b/ucb/source/ucp/cmis/cmis_repo_content.hxx
index 00fc4e244960..efd13d7d8cbf 100644
--- a/ucb/source/ucp/cmis/cmis_repo_content.hxx
+++ b/ucb/source/ucp/cmis/cmis_repo_content.hxx
@@ -75,7 +75,7 @@ public:
     RepoContent( const css::uno::Reference<
         css::uno::XComponentContext >& rxContext, ContentProvider *pProvider,
         const css::uno::Reference< css::ucb::XContentIdentifier >& Identifier,
-        std::vector< libcmis::RepositoryPtr > const & aRepos = std::vector< libcmis::RepositoryPtr > ( ) );
+        std::vector< libcmis::RepositoryPtr > && aRepos = std::vector< libcmis::RepositoryPtr > ( ) );
 
     virtual ~RepoContent() override;
 
diff --git a/ucb/source/ucp/file/filnot.cxx b/ucb/source/ucp/file/filnot.cxx
index f63f83f9e515..728d48eea6ec 100644
--- a/ucb/source/ucp/file/filnot.cxx
+++ b/ucb/source/ucp/file/filnot.cxx
@@ -34,11 +34,11 @@ using namespace com::sun::star::ucb;
 ContentEventNotifier::ContentEventNotifier( TaskManager* pMyShell,
                                             const uno::Reference< XContent >& xCreatorContent,
                                             const uno::Reference< XContentIdentifier >& xCreatorId,
-                                            const std::vector< uno::Reference< uno::XInterface > >& sListeners )
+                                            std::vector< uno::Reference< uno::XInterface > >&& sListeners )
     : m_pMyShell( pMyShell ),
       m_xCreatorContent( xCreatorContent ),
       m_xCreatorId( xCreatorId ),
-      m_sListeners( sListeners )
+      m_sListeners( std::move(sListeners) )
 {
 }
 
@@ -47,12 +47,12 @@ ContentEventNotifier::ContentEventNotifier( TaskManager* pMyShell,
                                             const uno::Reference< XContent >& xCreatorContent,
                                             const uno::Reference< XContentIdentifier >& xCreatorId,
                                             const uno::Reference< XContentIdentifier >& xOldId,
-                                            const std::vector< uno::Reference< uno::XInterface > >& sListeners )
+                                            std::vector< uno::Reference< uno::XInterface > >&& sListeners )
     : m_pMyShell( pMyShell ),
       m_xCreatorContent( xCreatorContent ),
       m_xCreatorId( xCreatorId ),
       m_xOldId( xOldId ),
-      m_sListeners( sListeners )
+      m_sListeners( std::move(sListeners) )
 {
 }
 
@@ -141,9 +141,9 @@ void ContentEventNotifier::notifyExchanged() const
 
 PropertySetInfoChangeNotifier::PropertySetInfoChangeNotifier(
     const uno::Reference< XContent >& xCreatorContent,
-    const std::vector< uno::Reference< uno::XInterface > >& sListeners )
+    std::vector< uno::Reference< uno::XInterface > >&& sListeners )
     : m_xCreatorContent( xCreatorContent ),
-      m_sListeners( sListeners )
+      m_sListeners( std::move(sListeners) )
 {
 
 }
diff --git a/ucb/source/ucp/file/filnot.hxx b/ucb/source/ucp/file/filnot.hxx
index bae7f6a038dd..a34d1bc07462 100644
--- a/ucb/source/ucp/file/filnot.hxx
+++ b/ucb/source/ucp/file/filnot.hxx
@@ -46,14 +46,14 @@ namespace fileaccess {
             TaskManager* pMyShell,
             const css::uno::Reference< css::ucb::XContent >& xCreatorContent,
             const css::uno::Reference< css::ucb::XContentIdentifier >& xCreatorId,
-            const std::vector< css::uno::Reference< css::uno::XInterface > >& sListeners );
+            std::vector< css::uno::Reference< css::uno::XInterface > >&& sListeners );
 
         ContentEventNotifier(
             TaskManager* pMyShell,
             const css::uno::Reference< css::ucb::XContent >& xCreatorContent,
             const css::uno::Reference< css::ucb::XContentIdentifier >& xCreatorId,
             const css::uno::Reference< css::ucb::XContentIdentifier >& xOldId,
-            const std::vector< css::uno::Reference< css::uno::XInterface > >& sListeners );
+            std::vector< css::uno::Reference< css::uno::XInterface > >&& sListeners );
 
         void notifyChildInserted( const OUString& aChildName ) const;
         void notifyDeleted() const;
@@ -70,7 +70,7 @@ namespace fileaccess {
     public:
         PropertySetInfoChangeNotifier(
             const css::uno::Reference< css::ucb::XContent >& xCreatorContent,
-            const std::vector< css::uno::Reference< css::uno::XInterface > >& sListeners );
+            std::vector< css::uno::Reference< css::uno::XInterface > >&& sListeners );
 
         void notifyPropertyAdded( const OUString & aPropertyName ) const;
         void notifyPropertyRemoved( const OUString & aPropertyName ) const;
diff --git a/ucb/source/ucp/ftp/ftpcontent.cxx b/ucb/source/ucp/ftp/ftpcontent.cxx
index ca38f16ae08c..eb9219b9a5c1 100644
--- a/ucb/source/ucp/ftp/ftpcontent.cxx
+++ b/ucb/source/ucp/ftp/ftpcontent.cxx
@@ -199,11 +199,11 @@ void SAL_CALL FTPContent::abort( sal_Int32 /*CommandId*/ )
 ResultSetFactory::ResultSetFactory(const Reference<XComponentContext >&  rxContext,
                   const Reference<XContentProvider >&  xProvider,
                   const Sequence<Property>& seq,
-                  const std::vector<FTPDirentry>& dirvec)
+                  std::vector<FTPDirentry>&& dirvec)
         : m_xContext(rxContext),
           m_xProvider(xProvider),
           m_seq(seq),
-          m_dirvec(dirvec)
+          m_dirvec(std::move(dirvec))
 {
 }
 
@@ -489,7 +489,7 @@ Any SAL_CALL FTPContent::execute( const Command& aCommand,
                             std::make_unique<ResultSetFactory>(m_xContext,
                                                  m_xProvider.get(),
                                                  aOpenCommand.Properties,
-                                                 resvec));
+                                                 std::move(resvec)));
                     aRet <<= xSet;
                 }
                 else if(aOpenCommand.Mode ==
diff --git a/ucb/source/ucp/ftp/ftpresultsetfactory.hxx b/ucb/source/ucp/ftp/ftpresultsetfactory.hxx
index 85f9f164732c..d521c570dcc4 100644
--- a/ucb/source/ucp/ftp/ftpresultsetfactory.hxx
+++ b/ucb/source/ucp/ftp/ftpresultsetfactory.hxx
@@ -41,7 +41,7 @@ public:
     ResultSetFactory(const css::uno::Reference<css::uno::XComponentContext >&  rxContext,
                       const css::uno::Reference<css::ucb::XContentProvider >&  xProvider,
                       const css::uno::Sequence<css::beans::Property>& seq,
-                      const std::vector<FTPDirentry>& dirvec);
+                    std::vector<FTPDirentry>&& dirvec);
 
     rtl::Reference<ResultSetBase> createResultSet();
 private:
diff --git a/ucb/source/ucp/webdav-neon/DAVRequestEnvironment.hxx b/ucb/source/ucp/webdav-neon/DAVRequestEnvironment.hxx
index 22c149d559a8..9059f6162804 100644
--- a/ucb/source/ucp/webdav-neon/DAVRequestEnvironment.hxx
+++ b/ucb/source/ucp/webdav-neon/DAVRequestEnvironment.hxx
@@ -49,11 +49,11 @@ struct DAVRequestEnvironment
 
 DAVRequestEnvironment( const OUString & rRequestURI,
                            const rtl::Reference< DAVAuthListener > & xListener,
-                           const DAVRequestHeaders & rRequestHeaders,
+                           DAVRequestHeaders && rRequestHeaders,
                            const uno::Reference< ucb::XCommandEnvironment > & xEnv)
     : m_aRequestURI( rRequestURI ),
       m_xAuthListener( xListener ),
-      m_aRequestHeaders( rRequestHeaders ),
+      m_aRequestHeaders( std::move(rRequestHeaders) ),
       m_xEnv( xEnv ){}
 
     DAVRequestEnvironment() {}
diff --git a/ucb/source/ucp/webdav-neon/DAVResourceAccess.cxx b/ucb/source/ucp/webdav-neon/DAVResourceAccess.cxx
index 4a239bd80d07..b13edc253c0c 100644
--- a/ucb/source/ucp/webdav-neon/DAVResourceAccess.cxx
+++ b/ucb/source/ucp/webdav-neon/DAVResourceAccess.cxx
@@ -189,7 +189,7 @@ void DAVResourceAccess::OPTIONS(
                                  DAVRequestEnvironment(
                                      getRequestURI(),
                                      new DAVAuthListener_Impl( xEnv, m_aURL ),
-                                     aHeaders, xEnv ) );
+                                     std::move(aHeaders), xEnv ) );
         }
         catch ( const DAVException & e )
         {
@@ -231,7 +231,7 @@ void DAVResourceAccess::PROPFIND(
                                   DAVRequestEnvironment(
                                       getRequestURI(),
                                       new DAVAuthListener_Impl( xEnv, m_aURL ),
-                                      aHeaders, xEnv ) );
+                                      std::move(aHeaders), xEnv ) );
         }
         catch ( const DAVException & e )
         {
@@ -271,7 +271,7 @@ void DAVResourceAccess::PROPFIND(
                                   DAVRequestEnvironment(
                                       getRequestURI(),
                                       new DAVAuthListener_Impl( xEnv, m_aURL ),
-                                      aHeaders, xEnv ) ) ;
+                                      std::move(aHeaders), xEnv ) ) ;
         }
         catch ( const DAVException & e )
         {
@@ -309,7 +309,7 @@ void DAVResourceAccess::PROPPATCH(
                                    DAVRequestEnvironment(
                                        getRequestURI(),
                                        new DAVAuthListener_Impl( xEnv, m_aURL ),
-                                       aHeaders, xEnv ) );
+                                       std::move(aHeaders), xEnv ) );
         }
         catch ( const DAVException & e )
         {
@@ -349,7 +349,7 @@ void DAVResourceAccess::HEAD(
                               DAVRequestEnvironment(
                                   getRequestURI(),
                                   new DAVAuthListener_Impl( xEnv, m_aURL ),
-                                  aHeaders, xEnv ) );
+                                  std::move(aHeaders), xEnv ) );
         }
         catch ( const DAVException & e )
         {
@@ -387,7 +387,7 @@ uno::Reference< io::XInputStream > DAVResourceAccess::GET(
                                            getRequestURI(),
                                            new DAVAuthListener_Impl(
                                                xEnv, m_aURL ),
-                                           aHeaders, xEnv ) );
+                                           std::move(aHeaders), xEnv ) );
         }
         catch ( const DAVException & e )
         {
@@ -427,7 +427,7 @@ void DAVResourceAccess::GET(
                              DAVRequestEnvironment(
                                  getRequestURI(),
                                  new DAVAuthListener_Impl( xEnv, m_aURL ),
-                                 aHeaders, xEnv ) );
+                                 std::move(aHeaders), xEnv ) );
         }
         catch ( const DAVException & e )
         {
@@ -468,7 +468,7 @@ uno::Reference< io::XInputStream > DAVResourceAccess::GET(
                                            getRequestURI(),
                                            new DAVAuthListener_Impl(
                                                xEnv, m_aURL ),
-                                           aHeaders, xEnv ) );
+                                           std::move(aHeaders), xEnv ) );
         }
         catch ( const DAVException & e )
         {
@@ -511,7 +511,7 @@ void DAVResourceAccess::GET0(
                                   getRequestURI(),
                                   new DAVAuthListener_Impl(
                                       xEnv, m_aURL ),
-                                  rRequestHeaders, xEnv ) );
+                                  DAVRequestHeaders(rRequestHeaders), xEnv ) );
         }
         catch ( const DAVException & e )
         {
@@ -553,7 +553,7 @@ void DAVResourceAccess::GET(
                              DAVRequestEnvironment(
                                  getRequestURI(),
                                  new DAVAuthListener_Impl( xEnv, m_aURL ),
-                                 aHeaders, xEnv ) );
+                                 std::move(aHeaders), xEnv ) );
         }
         catch ( const DAVException & e )
         {
@@ -634,7 +634,7 @@ void DAVResourceAccess::PUT(
                              DAVRequestEnvironment(
                                  getRequestURI(),
                                  new DAVAuthListener_Impl( xEnv, m_aURL ),
-                                 aHeaders, xEnv ) );
+                                 std::move(aHeaders), xEnv ) );
         }
         catch ( const DAVException & e )
         {
@@ -688,7 +688,7 @@ uno::Reference< io::XInputStream > DAVResourceAccess::POST(
                                             getRequestURI(),
                                             new DAVAuthListener_Impl(
                                                 xEnv, m_aURL ),
-                                            aHeaders, xEnv ) );
+                                            std::move(aHeaders), xEnv ) );
         }
         catch ( const DAVException & e )
         {
@@ -750,7 +750,7 @@ void DAVResourceAccess::POST(
                               DAVRequestEnvironment(
                                   getRequestURI(),
                                   new DAVAuthListener_Impl( xEnv, m_aURL ),
-                                  aHeaders, xEnv ) );
+                                  std::move(aHeaders), xEnv ) );
         }
         catch ( const DAVException & e )
         {
@@ -793,7 +793,7 @@ void DAVResourceAccess::MKCOL(
                                DAVRequestEnvironment(
                                    getRequestURI(),
                                    new DAVAuthListener_Impl( xEnv, m_aURL ),
-                                   aHeaders, xEnv ) );
+                                   std::move(aHeaders), xEnv ) );
         }
         catch ( const DAVException & e )
         {
@@ -833,7 +833,7 @@ void DAVResourceAccess::COPY(
                               DAVRequestEnvironment(
                                   getRequestURI(),
                                   new DAVAuthListener_Impl( xEnv, m_aURL ),
-                                  aHeaders, xEnv ),
+                                  std::move(aHeaders), xEnv ),
                               bOverwrite );
         }
         catch ( const DAVException & e )
@@ -874,7 +874,7 @@ void DAVResourceAccess::MOVE(
                               DAVRequestEnvironment(
                                   getRequestURI(),
                                   new DAVAuthListener_Impl( xEnv, m_aURL ),
-                                  aHeaders, xEnv ),
+                                  std::move(aHeaders), xEnv ),
                               bOverwrite );
         }
         catch ( const DAVException & e )
@@ -911,7 +911,7 @@ void DAVResourceAccess::DESTROY(
                                  DAVRequestEnvironment(
                                      getRequestURI(),
                                      new DAVAuthListener_Impl( xEnv, m_aURL ),
-                                     aHeaders, xEnv ) );
+                                     std::move(aHeaders), xEnv ) );
         }
         catch ( const DAVException & e )
         {
@@ -950,7 +950,7 @@ void DAVResourceAccess::LOCK(
                               DAVRequestEnvironment(
                                   getRequestURI(),
                                   new DAVAuthListener_Impl( xEnv, m_aURL ),
-                                  aHeaders, xEnv ) );
+                                  std::move(aHeaders), xEnv ) );
         }
         catch ( const DAVException & e )
         {
@@ -985,7 +985,7 @@ void DAVResourceAccess::UNLOCK(
                                 DAVRequestEnvironment(
                                     getRequestURI(),
                                     new DAVAuthListener_Impl( xEnv, m_aURL ),
-                                    aHeaders, xEnv ) );
+                                    std::move(aHeaders), xEnv ) );
         }
         catch ( const DAVException & e )
         {
diff --git a/ucb/source/ucp/webdav-neon/PropfindCache.hxx b/ucb/source/ucp/webdav-neon/PropfindCache.hxx
index b2e4008dc682..f78d526a7fe0 100644
--- a/ucb/source/ucp/webdav-neon/PropfindCache.hxx
+++ b/ucb/source/ucp/webdav-neon/PropfindCache.hxx
@@ -47,7 +47,7 @@ namespace webdav_ucp
         OUString& getURL() { return m_sURL; };
 
         const std::vector< DAVResourceInfo >& getPropertiesNames() const { return m_aPropertiesNames; };
-        void setPropertiesNames( const std::vector< DAVResourceInfo >& aPropertiesNames ) { m_aPropertiesNames = aPropertiesNames; };
+        void setPropertiesNames( std::vector< DAVResourceInfo >&& aPropertiesNames ) { m_aPropertiesNames = std::move(aPropertiesNames); };
     };
 
     // Define the PropertyNames cache
diff --git a/ucb/source/ucp/webdav-neon/webdavcontentcaps.cxx b/ucb/source/ucp/webdav-neon/webdavcontentcaps.cxx
index d8ff4ff6fb03..ddeeec03fe28 100644
--- a/ucb/source/ucp/webdav-neon/webdavcontentcaps.cxx
+++ b/ucb/source/ucp/webdav-neon/webdavcontentcaps.cxx
@@ -331,7 +331,7 @@ uno::Sequence< beans::Property > Content::getProperties(
                 {
 
                     xResAccess->PROPFIND( DAVZERO, props, xEnv );
-                    aPropsNames.setPropertiesNames( props );
+                    aPropsNames.setPropertiesNames( std::vector(props) );
 
                     aStaticPropertyNamesCache.addCachePropertyNames( aPropsNames );
                 }