summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2019-10-18 15:45:43 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2019-10-21 19:32:13 +0200
commit5dcee37fc47b898bc69c65dfaac3a3c20dba1913 (patch)
treeacd7a6c545c16ad0b4b5489e6b2cf1e112e54941
parent501233bf55cc89b146e2dca9a37d749d14486a18 (diff)
loplugin:virtualdead unused param in IControlActionListener
Change-Id: I2ce8df6a9a1ac2e6d6c5de08b32fb671bf10cd17 Reviewed-on: https://gerrit.libreoffice.org/81244 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-rw-r--r--compilerplugins/clang/virtualdead.unusedparams.results3
-rw-r--r--dbaccess/source/ui/app/AppController.cxx2
-rw-r--r--dbaccess/source/ui/app/AppController.hxx2
-rw-r--r--dbaccess/source/ui/browser/dsbrowserDnD.cxx2
-rw-r--r--dbaccess/source/ui/control/dbtreelistbox.cxx4
-rw-r--r--dbaccess/source/ui/inc/callbacks.hxx2
-rw-r--r--dbaccess/source/ui/inc/unodatbr.hxx2
7 files changed, 7 insertions, 10 deletions
diff --git a/compilerplugins/clang/virtualdead.unusedparams.results b/compilerplugins/clang/virtualdead.unusedparams.results
index 73874d79ef24..ef67c180b642 100644
--- a/compilerplugins/clang/virtualdead.unusedparams.results
+++ b/compilerplugins/clang/virtualdead.unusedparams.results
@@ -49,9 +49,6 @@ dbaccess/source/core/api/CacheSet.hxx:176
dbaccess/source/core/inc/containerapprove.hxx:53
void dbaccess::IContainerApprove::approveElement(const class rtl::OUString &,const class com::sun::star::uno::Reference<class com::sun::star::uno::XInterface> &,)
10
-dbaccess/source/ui/inc/callbacks.hxx:53
- _Bool dbaui::IControlActionListener::requestDrag(signed char,const class Point &,)
- 01
desktop/source/deployment/registry/inc/dp_backend.h:84
void dp_registry::backend::Package::processPackage_(class osl::ResettableGuard<class osl::Mutex> &,_Bool,_Bool,const class rtl::Reference<class dp_misc::AbortChannel> &,const class com::sun::star::uno::Reference<class com::sun::star::ucb::XCommandEnvironment> &,)
01111
diff --git a/dbaccess/source/ui/app/AppController.cxx b/dbaccess/source/ui/app/AppController.cxx
index b3e753800b73..f79c6d3e030f 100644
--- a/dbaccess/source/ui/app/AppController.cxx
+++ b/dbaccess/source/ui/app/AppController.cxx
@@ -2267,7 +2267,7 @@ bool OApplicationController::requestQuickHelp( const SvTreeListEntry* /*_pEntry*
return false;
}
-bool OApplicationController::requestDrag( sal_Int8 /*_nAction*/, const Point& /*_rPosPixel*/ )
+bool OApplicationController::requestDrag( const Point& /*_rPosPixel*/ )
{
rtl::Reference<TransferableHelper> pTransfer;
if ( getContainer() && getContainer()->getSelectionCount() )
diff --git a/dbaccess/source/ui/app/AppController.hxx b/dbaccess/source/ui/app/AppController.hxx
index a05b7367dc3b..2aacb412d9f8 100644
--- a/dbaccess/source/ui/app/AppController.hxx
+++ b/dbaccess/source/ui/app/AppController.hxx
@@ -484,7 +484,7 @@ namespace dbaui
// IControlActionListener overridables
virtual bool requestQuickHelp( const SvTreeListEntry* _pEntry, OUString& _rText ) const override;
- virtual bool requestDrag( sal_Int8 _nAction, const Point& _rPosPixel ) override;
+ virtual bool requestDrag( const Point& _rPosPixel ) override;
virtual sal_Int8 queryDrop( const AcceptDropEvent& _rEvt, const DataFlavorExVector& _rFlavors ) override;
virtual sal_Int8 executeDrop( const ExecuteDropEvent& _rEvt ) override;
diff --git a/dbaccess/source/ui/browser/dsbrowserDnD.cxx b/dbaccess/source/ui/browser/dsbrowserDnD.cxx
index ea22ebab8fe7..32228090bec6 100644
--- a/dbaccess/source/ui/browser/dsbrowserDnD.cxx
+++ b/dbaccess/source/ui/browser/dsbrowserDnD.cxx
@@ -173,7 +173,7 @@ namespace dbaui
return DND_ACTION_NONE;
}
- bool SbaTableQueryBrowser::requestDrag( sal_Int8 /*_nAction*/, const Point& _rPosPixel )
+ bool SbaTableQueryBrowser::requestDrag( const Point& _rPosPixel )
{
// get the affected list entry
// ensure that the entry which the user clicked at is selected
diff --git a/dbaccess/source/ui/control/dbtreelistbox.cxx b/dbaccess/source/ui/control/dbtreelistbox.cxx
index 0bc9e569dbb4..ea9283add4ac 100644
--- a/dbaccess/source/ui/control/dbtreelistbox.cxx
+++ b/dbaccess/source/ui/control/dbtreelistbox.cxx
@@ -268,12 +268,12 @@ sal_Int8 DBTreeListBox::ExecuteDrop( const ExecuteDropEvent& _rEvt )
return DND_ACTION_NONE;
}
-void DBTreeListBox::StartDrag( sal_Int8 _nAction, const Point& _rPosPixel )
+void DBTreeListBox::StartDrag( sal_Int8 /*_nAction*/, const Point& _rPosPixel )
{
if ( m_pActionListener )
{
m_pDragedEntry = GetEntry(_rPosPixel);
- if ( m_pDragedEntry && m_pActionListener->requestDrag( _nAction, _rPosPixel ) )
+ if ( m_pDragedEntry && m_pActionListener->requestDrag( _rPosPixel ) )
{
// if the (asynchronous) drag started, stop the selection timer
implStopSelectionTimer();
diff --git a/dbaccess/source/ui/inc/callbacks.hxx b/dbaccess/source/ui/inc/callbacks.hxx
index bd4498dc5175..f80f5aee7d2f 100644
--- a/dbaccess/source/ui/inc/callbacks.hxx
+++ b/dbaccess/source/ui/inc/callbacks.hxx
@@ -50,7 +50,7 @@ namespace dbaui
/** handler for StartDrag requests
@return <TRUE/> if a drag operation was started
*/
- virtual bool requestDrag( sal_Int8 _nAction, const Point& _rPosPixel ) = 0;
+ virtual bool requestDrag( const Point& _rPosPixel ) = 0;
/** check whether or not a drop request should be accepted
*/
diff --git a/dbaccess/source/ui/inc/unodatbr.hxx b/dbaccess/source/ui/inc/unodatbr.hxx
index 3c806697dc85..48f1b5217577 100644
--- a/dbaccess/source/ui/inc/unodatbr.hxx
+++ b/dbaccess/source/ui/inc/unodatbr.hxx
@@ -226,7 +226,7 @@ namespace dbaui
// IControlActionListener overridables
virtual bool requestQuickHelp( const SvTreeListEntry* _pEntry, OUString& _rText ) const override;
- virtual bool requestDrag( sal_Int8 _nAction, const Point& _rPosPixel ) override;
+ virtual bool requestDrag( const Point& _rPosPixel ) override;
virtual sal_Int8 queryDrop( const AcceptDropEvent& _rEvt, const DataFlavorExVector& _rFlavors ) override;
virtual sal_Int8 executeDrop( const ExecuteDropEvent& _rEvt ) override;